From: "Clément Chigot" <chigot@adacore.com>
To: binutils@sourceware.org
Cc: pinskia@gmail.com, nickc@redhat.com
Subject: Re: [PATCH v2] configure: remove dependencies on gmp and mpfr when gdb is disabled
Date: Thu, 5 Jan 2023 09:06:43 +0100 [thread overview]
Message-ID: <CAJ307EjppfaNs3Pd41ZbeUzqtUXkfPWTgahe1S9VK+ANhy=k9Q@mail.gmail.com> (raw)
In-Reply-To: <20230103162543.2412854-1-chigot@adacore.com>
Hi Nick, Andrew,
On Tue, Jan 3, 2023 at 5:25 PM Clément Chigot <chigot@adacore.com> wrote:
>
> Since 991180627851801f1999d1ebbc0e569a17e47c74, the configure checks
> about GMP and MPFR for gdb builds have been moved to the toplevel
> configure.
> However, it doesn't take into account the --disable-gdb option. Meaning
> that a build without gdb will require these libraries even if not
> needed.
>
> ChangeLog:
>
> * configure.ac: Skip GMP and MPFR when --disable-gdb is
> provided.
> * configure: Regenerate.
> ---
> configure | 4 +++-
> configure.ac | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 417fc5a970c..9cb953a197e 100755
> --- a/configure
> +++ b/configure
> @@ -8032,7 +8032,9 @@ if test -d ${srcdir}/gcc ; then
> require_mpc=yes
> fi
> if test -d ${srcdir}/gdb ; then
> - require_gmp=yes
> + if test "x$enable_gdb" != xno; then
> + require_gmp=yes
> + fi
> fi
>
> gmplibs="-lmpfr -lgmp"
> diff --git a/configure.ac b/configure.ac
> index 3a1eb0357e5..e95a9ed116e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1585,7 +1585,9 @@ if test -d ${srcdir}/gcc ; then
> require_mpc=yes
> fi
> if test -d ${srcdir}/gdb ; then
> - require_gmp=yes
> + if test "x$enable_gdb" != xno; then
> + require_gmp=yes
> + fi
> fi
>
> gmplibs="-lmpfr -lgmp"
> --
> 2.25.1
Would you mind reviewing/approving this patch, please ?
Thanks in advance,
Clément
next prev parent reply other threads:[~2023-01-05 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 16:25 Clément Chigot
2023-01-05 8:06 ` Clément Chigot [this message]
2023-01-05 20:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ307EjppfaNs3Pd41ZbeUzqtUXkfPWTgahe1S9VK+ANhy=k9Q@mail.gmail.com' \
--to=chigot@adacore.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).