From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 594DB3858D35 for ; Thu, 5 Jan 2023 08:06:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 594DB3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-pl1-x62e.google.com with SMTP id d3so38611399plr.10 for ; Thu, 05 Jan 2023 00:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8iPaqx0+2/lSNLufNsgsMlHLT1krjZmZcwqepZ3sy4k=; b=ZNLwmXquOw8wTUb9stnoN1R4jo8Qcs1G0K5ik+PaPnxN3d2Nb7HwrcspPcoMq2nkq6 6PMfSA42+116/ru/hq0T1vZlvammO9MWfQLQucu8P2pDCB79Ap+lwBA37Vz4Dx43X0pr YYc5aw5JDxNbndLPGLlcRYtZoYF8rrgMZtjS8KHvgBa273K0r/lHv8U0pgppniR2CEhb 2BuJq0XS5rmH9zmDEuhGMoaz4p2wPe1Exslt+NrTiD9vCRiWNoQMCOcnef5ZsVQndZjJ vXniErN0NOKcRSxDPlG/cLINE53HcuSIkmAmxmyV5kVw68lQTJ8Cou9i6ZXfrplOU7Zg vajw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8iPaqx0+2/lSNLufNsgsMlHLT1krjZmZcwqepZ3sy4k=; b=tNiet+VjZme3VJtu9lbv3m64L+yGuuJBi/kd1sR7fMhLDzVrab3lTYw7M1aiC+qkUv QZC0Pbg6d3ittA0KQPOQfTu4aYJ0JbCZ2wzQAFL4r3u2KW5nJnv346xJrtyheGpWZdP/ GT2uO3wq9ZdXO1G/nbO77wjDQcgcBjwHnAR8OJngwwUf95BWC7aO2OJYrgRgw3+17+Ht 9XIPhhayWuJ6zgaTRfQbV+CSKetm5M27bwi/pV8t42+CzIGlPlNQF1xZ3nt0yoJ7AgmQ DcYcJL9BPHsAyLziOZ4S2a9g7FWsbKbw+cXw9UlRwFezLTbTo2nElW0DswO2Po+eskCd VOUA== X-Gm-Message-State: AFqh2kpIDDsQUDpkHDf6WSSk14e396tcG07XGVROk0JFVNLYMjSYZ7EH Lx5pct6jg7sBQYmO7nfEmGrZVKdNu0yB3ta5hl86bEPNCadPJg== X-Google-Smtp-Source: AMrXdXsvLeQOOf0WsahRzgLAAy1Z4r400m5CdbVuBAivPvIsUBhIcStOMnGhgok4YiMyJW/kdLeVk7GSvomlitl19EA= X-Received: by 2002:a17:902:db07:b0:192:ab97:633c with SMTP id m7-20020a170902db0700b00192ab97633cmr1015366plx.69.1672906014276; Thu, 05 Jan 2023 00:06:54 -0800 (PST) MIME-Version: 1.0 References: <20230103162543.2412854-1-chigot@adacore.com> In-Reply-To: <20230103162543.2412854-1-chigot@adacore.com> From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= Date: Thu, 5 Jan 2023 09:06:43 +0100 Message-ID: Subject: Re: [PATCH v2] configure: remove dependencies on gmp and mpfr when gdb is disabled To: binutils@sourceware.org Cc: pinskia@gmail.com, nickc@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, Andrew, On Tue, Jan 3, 2023 at 5:25 PM Cl=C3=A9ment Chigot wro= te: > > Since 991180627851801f1999d1ebbc0e569a17e47c74, the configure checks > about GMP and MPFR for gdb builds have been moved to the toplevel > configure. > However, it doesn't take into account the --disable-gdb option. Meaning > that a build without gdb will require these libraries even if not > needed. > > ChangeLog: > > * configure.ac: Skip GMP and MPFR when --disable-gdb is > provided. > * configure: Regenerate. > --- > configure | 4 +++- > configure.ac | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 417fc5a970c..9cb953a197e 100755 > --- a/configure > +++ b/configure > @@ -8032,7 +8032,9 @@ if test -d ${srcdir}/gcc ; then > require_mpc=3Dyes > fi > if test -d ${srcdir}/gdb ; then > - require_gmp=3Dyes > + if test "x$enable_gdb" !=3D xno; then > + require_gmp=3Dyes > + fi > fi > > gmplibs=3D"-lmpfr -lgmp" > diff --git a/configure.ac b/configure.ac > index 3a1eb0357e5..e95a9ed116e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1585,7 +1585,9 @@ if test -d ${srcdir}/gcc ; then > require_mpc=3Dyes > fi > if test -d ${srcdir}/gdb ; then > - require_gmp=3Dyes > + if test "x$enable_gdb" !=3D xno; then > + require_gmp=3Dyes > + fi > fi > > gmplibs=3D"-lmpfr -lgmp" > -- > 2.25.1 Would you mind reviewing/approving this patch, please ? Thanks in advance, Cl=C3=A9ment