[PATCH 1/4] binutils/testsuite: Replace set ::env with setenv

[PATCH 1/4] binutils/testsuite: Replace set ::env with setenv

[Aaron Merey]

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: 0001-binutils-testsuite-Replace-set-env-with-setenv.patch --]
[-- Type: text/x-patch, Size: 1099 bytes --]

binutils/testsuite: Replace set ::env with setenv.

	* binutils/testsuite/binutils-all/debuginfod.exp:
	Replace set ::env with setenv.
---
 binutils/testsuite/binutils-all/debuginfod.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/binutils/testsuite/binutils-all/debuginfod.exp b/binutils/testsuite/binutils-all/debuginfod.exp
index 596fcf58df..d73073ef17 100644
--- a/binutils/testsuite/binutils-all/debuginfod.exp
+++ b/binutils/testsuite/binutils-all/debuginfod.exp
@@ -78,9 +78,9 @@ set port [exec sh -c "while true; do PORT=`expr '(' \$RANDOM % 1000 ')' + 9000`;
 # Specify the directory that files retrieved from the server are written to.
 set cache [file join [pwd] "tmpdir/.debuginfod_cache"]
 
-set ::env(DEBUGINFOD_URLS) http://127.0.0.1:$port
-set ::env(DEBUGINFOD_TIMEOUT) 30
-set ::env(DEBUGINFOD_CACHE_PATH) $cache
+setenv DEBUGINFOD_URLS http://127.0.0.1:$port
+setenv DEBUGINFOD_TIMEOUT 30
+setenv DEBUGINFOD_CACHE_PATH $cache
 
 # Move debug files into another directory so that readelf and objdump cannot
 # find them without debuginfod.
-- 
2.23.0

Re: [PATCH 1/4] binutils/testsuite: Replace set ::env with setenv

[Nick Clifton]

Hi Aaron,

  I have applied all four of your patches.

Cheers
  Nick

binutils/ChangeLog
2020-02-10  Aaron Merey  <amerey@redhat.com>

	* binutils/testsuite/binutils-all/debuginfod.exp:
	Replace set ::env with setenv.
	Start server before setting environment variable.
	Specify tmpdir as the location of the server's
	database.
	Check additional server metrics at start-up.