From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by sourceware.org (Postfix) with ESMTPS id B76313858D32 for ; Thu, 25 May 2023 15:35:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B76313858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57234646F0 for ; Thu, 25 May 2023 15:35:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B737FC4339E for ; Thu, 25 May 2023 15:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685028916; bh=VYlv3hpJPi2pWVAFCDNlPXMDn3zY7ZMH3SzWuaTwtHc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Y6cQyNGC0SFMQsyhAqVTlAIIagKGM/wjc0OY3Yj+rlxATgk4qA9auPdCvDq7mTKMx JOZn3+4MO6FwGChHAYGLfkdIZfhNRHQoc8EtG4Toa/wUArzxwP881FjCkKLIvIu1od MFmcRkfZFquFw8aOP1xy5QR0aLADD11zlptAn0asI44ybRMcoiGWkgcN3fNRtrY7h+ HsQx2n5EBdU9cneVrCTHYiEkmFlv8+s8vCVYl6qKMhLYhrk+NYwK+/nqAji/2vxaIY +g8puGN2Y2Z2kwyEj68xoMNLnCYGhxrm7FLYSZWOd6nP0kVYqMvnZd4ieT2/gPsWUe 1xEgfNzEi47CA== Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-96fe88cd2fcso143106366b.1 for ; Thu, 25 May 2023 08:35:16 -0700 (PDT) X-Gm-Message-State: AC+VfDzwGKLKm1tRq5AJJ2AU/DbVupLdGp7mpc7UOXEJ//KDeXbHMU8N W+nGbzYkMZYbifgPkU46AGIpIMLbs5qMuNb3tZ4= X-Google-Smtp-Source: ACHHUZ7CwPVi+f4qUbrDbsJ84hm7nBKFRGH4qEcxBGwxW3ZjtKLp8yRmQTrCMt80DHyYaztigGr1+mBPvD5r0uJowdQ= X-Received: by 2002:a17:907:86a0:b0:968:2bb1:f39d with SMTP id qa32-20020a17090786a000b009682bb1f39dmr2660766ejc.36.1685028914961; Thu, 25 May 2023 08:35:14 -0700 (PDT) MIME-Version: 1.0 References: <20230519034835.664-1-shihua@iscas.ac.cn> <20230519034835.664-4-shihua@iscas.ac.cn> In-Reply-To: <20230519034835.664-4-shihua@iscas.ac.cn> From: Guo Ren Date: Thu, 25 May 2023 23:35:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 3/4] RISC-V : Add rv64 ilp32 support in disassemble To: Liao Shihua Cc: binutils@sourceware.org, kito.cheng@sifive.com, jiawei@iscas.ac.cn, palmer@dabbelt.com, wuwei2016@iscas.ac.cn, shiyulong@iscas.ac.cn, chenyixuan@iscas.ac.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, May 19, 2023 at 11:49=E2=80=AFAM Liao Shihua w= rote: > > This patch supports rv64 ilp32 in disassemble. > > > opcodes/ChangeLog: > > * riscv-dis.c (print_insn_args): > (riscv_disassemble_insn): > --- > opcodes/riscv-dis.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c > index f25993d1e45..550cabf875e 100644 > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -263,7 +263,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma= pc, disassemble_info *info > case 'j': > if (((l & MASK_C_ADDI) =3D=3D MATCH_C_ADDI) && rd !=3D 0) > maybe_print_address (pd, rd, EXTRACT_CITYPE_IMM (l), 0); > - if (info->mach =3D=3D bfd_mach_riscv64 > + if ((info->mach =3D=3D bfd_mach_riscv64 || info->mach =3D= =3D bfd_mach_riscv64x32) > && ((l & MASK_C_ADDIW) =3D=3D MATCH_C_ADDIW) && rd !=3D= 0) > maybe_print_address (pd, rd, EXTRACT_CITYPE_IMM (l), 1); > print (info->stream, dis_style_immediate, "%d", > @@ -463,7 +463,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma= pc, disassemble_info *info > if (((l & MASK_ADDI) =3D=3D MATCH_ADDI && rs1 !=3D 0) > || (l & MASK_JALR) =3D=3D MATCH_JALR) > maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 0); > - if (info->mach =3D=3D bfd_mach_riscv64 > + if ((info->mach =3D=3D bfd_mach_riscv64 || info->mach =3D=3D bf= d_mach_riscv64x32) keep the name of bfd_mach_riscv64ilp32 > && ((l & MASK_ADDIW) =3D=3D MATCH_ADDIW) && rs1 !=3D 0) > maybe_print_address (pd, rs1, EXTRACT_ITYPE_IMM (l), 1); > print (info->stream, dis_style_immediate, "%d", > @@ -724,7 +724,7 @@ riscv_disassemble_insn (bfd_vma memaddr, > if (op !=3D NULL) > { > /* If XLEN is not known, get its value from the ELF class. */ > - if (info->mach =3D=3D bfd_mach_riscv64) > + if (info->mach =3D=3D bfd_mach_riscv64 || info->mach =3D=3D bfd_ma= ch_riscv64x32) > xlen =3D 64; > else if (info->mach =3D=3D bfd_mach_riscv32) > xlen =3D 32; > -- > 2.38.1.windows.1 > --=20 Best Regards Guo Ren