From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id ED3FC3858402 for ; Fri, 24 Dec 2021 08:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED3FC3858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ua1-x932.google.com with SMTP id i6so14209032uae.6 for ; Fri, 24 Dec 2021 00:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QBOAJO+2vfXD7KcVJAepRB7fU6ZtNY4GKj72jvE0ivY=; b=iaMGS6qaIxS2I1A9ECzd1brNbC2VNGFpF7V5f7xYAsy/4SyMgwrFxfIRsLA7TNkfd2 RGE1IKTcIOYfAbwH+g3e/w1PL2py3tyoH8A5s+R9DHavwxsSsgI7cC0MV1z5ETKUFeva zIUsLejiruFkrTuMGQ9yf6nm4Fa8tgJAD1MVB6+PKAcFbSEUUqhumC6WGJ1YoCft0MrT 2qpcwKuDLCJpyyKVYcQ18qrZz5ZqJ8m2xwAEop3gqMlopyUSfrT3kC2h4DBtRvW1RF1y 0T49tx85J2ni6gQTiWOep6xtaCNYgUOCOkWsVA1QTQabTRE8WBGOuIRNZ1uUZ6souIn8 Waag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QBOAJO+2vfXD7KcVJAepRB7fU6ZtNY4GKj72jvE0ivY=; b=cow+5XRuaiCz/3IyMzNBAUpBQqYThUQrMt0eH+zLn50LFQv5incnWpggzAXdWsE3j5 Iu/gmVcpGs/s0ju2RO0VyaitCA7m7WPT1EHTuK/sHQOuvxTWBmZmtw2PpWc4foETtk9E 9f8hLdo9VSEfLHHo0WcPREx3ONU6jd63iMYP0mp+0zoVQKoHlX2cvMRascT2846EFH9l dtCDUugaJ3kTTl45GtRMSYq6PyrlLwW6hlyuZZY0qphVkn3OYPoWYKUX8Iit+bbPU0jh WktcOy4bB32Ejmi950rlBr1xpH+dH8+pN/9BzPsUYdqqqlUDrVa2xhajGsI3uZVpH58A G8hg== X-Gm-Message-State: AOAM533daQqcZRZtXawvt69eOpWlcfRRAkgdGQs6Jz1Q+QtU8ejVhzrz l244kis3cwjx23ncAZYo3qW3JzCRD1f1RVUALvCy+Q== X-Google-Smtp-Source: ABdhPJxUZ6CWjF459x4zJ4fWhc/b9GP5GXEwEDeVJ+YDLLgLAS537lljttSQITf1pFWVLlc5tuv2thG0WF+qs2UsZe8= X-Received: by 2002:ab0:15af:: with SMTP id i44mr1856101uae.17.1640335900488; Fri, 24 Dec 2021 00:51:40 -0800 (PST) MIME-Version: 1.0 References: <20211221023415.2211328-1-vineetg@rivosinc.com> In-Reply-To: From: Nelson Chu Date: Fri, 24 Dec 2021 16:51:29 +0800 Message-ID: Subject: Re: [v1 0/4]riscv/binutils support Hypervisor Extension To: Palmer Dabbelt Cc: Vineet Gupta , Binutils , Kito Cheng , Jim Wilson Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2021 08:51:42 -0000 Hi Palmer, Hi Vineet, Thanks for all the series of patches, looks good to me, except some minor issues, so I leave some comments in the related patches. But since I need to commit the rewritten csr testcases, I committed Vineet patches with the minor changes directly. Thanks Nelson On Thu, Dec 23, 2021 at 9:35 AM Palmer Dabbelt wrote: > > On Mon, 20 Dec 2021 18:34:11 PST (-0800), Vineet Gupta wrote: > > Hi, > > > > This patchset adds support for Hypervisor Extension ratified recently > > [1]. > > > > Changes since RFC [2]: > > > > - Drop support for single-letter arch string "h". > > 'H' extension is currently supported unconditionally so keep status quo. > > WFM: there's no name for this, so just keeping it as part of the base > ISA seems like the best we can do. It certainly matches the precedent > we've set a bunch of times before, and holding this up because we can't > name it is just silly. > > > - H-ext support in Priv spec 1.9.1 dropped, broken out as seperate patch. > > > > Please review/comment ! > > I think I said this in the RFC, but we generally don't drop support for > stuff we have. In theory removing the 1.9.1 CSRs is something that > would break users, but I think we're pretty safe here because these > vestigial bits of the hypervisor extension never really did anything so > > Reviewed-by: Palmer Dabbelt > > In the unlikely event that anyone's actually using this, now's the time > to speak up! > > Thanks! > > > Thx, > > -Vineet > > > > [1] https://wiki.riscv.org/display/TECH/Recently+Ratified+Extensions > > [2] https://sourceware.org/pipermail/binutils/2021-December/118914.html > > > > Vineet Gupta (4): > > RISC-V: Hypervisor ext: drop Privileged Spec 1.9.1 > > implementation/tests > > RISC-V: Hypervisor ext: support Privileged Spec 1.12 > > RISC-V: Hypervisor Ext: Add tests > > RISC-V: fix a comment for adding CSR entry and annotate switch-break > > > > bfd/cpu-riscv.c | 1 + > > bfd/cpu-riscv.h | 1 + > > bfd/elfxx-riscv.c | 6 + > > gas/config/tc-riscv.c | 10 +- > > gas/testsuite/gas/riscv/csr-dw-regnums.d | 10 -- > > gas/testsuite/gas/riscv/csr-dw-regnums.s | 10 -- > > gas/testsuite/gas/riscv/h-ext-32.d | 74 ++++++++++++ > > gas/testsuite/gas/riscv/h-ext-32.s | 64 ++++++++++ > > gas/testsuite/gas/riscv/h-ext-64.d | 73 ++++++++++++ > > gas/testsuite/gas/riscv/h-ext-64.s | 63 ++++++++++ > > .../gas/riscv/priv-reg-fail-read-only-01.s | 10 -- > > .../gas/riscv/priv-reg-fail-version-1p10.l | 10 -- > > .../gas/riscv/priv-reg-fail-version-1p11.l | 10 -- > > .../gas/riscv/priv-reg-version-1p10.d | 10 -- > > .../gas/riscv/priv-reg-version-1p11.d | 10 -- > > .../gas/riscv/priv-reg-version-1p9p1.d | 10 -- > > gas/testsuite/gas/riscv/priv-reg.s | 10 -- > > gas/testsuite/gas/riscv/svinval-and-h.d | 15 +++ > > gas/testsuite/gas/riscv/svinval-and-h.s | 5 + > > include/opcode/riscv-opc.h | 110 ++++++++++++++---- > > include/opcode/riscv.h | 2 + > > opcodes/riscv-opc.c | 26 ++++- > > 22 files changed, 423 insertions(+), 117 deletions(-) > > create mode 100644 gas/testsuite/gas/riscv/h-ext-32.d > > create mode 100644 gas/testsuite/gas/riscv/h-ext-32.s > > create mode 100644 gas/testsuite/gas/riscv/h-ext-64.d > > create mode 100644 gas/testsuite/gas/riscv/h-ext-64.s > > create mode 100644 gas/testsuite/gas/riscv/svinval-and-h.d > > create mode 100644 gas/testsuite/gas/riscv/svinval-and-h.s