From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by sourceware.org (Postfix) with ESMTPS id 99E0D3835686 for ; Wed, 22 Jun 2022 10:39:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99E0D3835686 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-vk1-xa32.google.com with SMTP id h26so1037790vkc.2 for ; Wed, 22 Jun 2022 03:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zOQbA1VKYfqNwZ7136KV9BpGQ3uMVuqV39uwluHwn4c=; b=KbyAyL0mIwjrrFzqPQEJCrgaGHNv8wjIwsTidPT+Tls0NQ8Bkspaqptm/1zu+CrTK1 f1l/aLv4NlOM392OOooe/EaheVyWxBkgv5XHKmH2ld8Zq3VObsPr30JjlFvjkEZnipWH gWOUksTff9yJr9IX2YSZKV0PMoQBDOiJoi3/CpvmEQs0IbZWdqx/ICl4JML3cBOxNQ3U ah/2yd3Zeb8XkRoRtXgxnYhrartl6H5sNuXXHWy6pW8GmdHE+783LXpZ/2S9CBW3QAr/ GEopVMj09VmEZ/dX+G32Q+2WMgEIXRXJGAWvDGMlT+Un5IeM4UMU5MnggiF9dUyHDi/N b+zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zOQbA1VKYfqNwZ7136KV9BpGQ3uMVuqV39uwluHwn4c=; b=MTcBvGI9yR7aO1GjxbYR6g0vNrRdMg9KN08/BhcMjl7QBlQ4Dj/qUV750w1ziwy5vB VNE5KiYGJ4EjdA7IGJPeWmrZwjhf030P7R52e95nHPCW5pNo9B7zca7n0HAIM4qKg6FF pfQA5WtEuBwjJiDj48ybP7nT4V5ZsBAo83TVgRG2XP9YanDN+ORZp6yem6Dwvxya34x1 xNlLgaVn569TEbO4dzUPgrrKPdHYW8sROceNC/YJoJVYPqw9hWES+yZuGT3mlEkUmcHH cvlsIkDQJg2r7V/1Dz1W0voVUcOfMWogMlnGgxpSoIe+WXlH5WhuDJ8flKi+XN7MTM7l PYXA== X-Gm-Message-State: AJIora8DVqFM6IysWd3jIPBRc7YmgUHzBlsTfJjawDD9o4ISd8Hf+vaN dY2IUiS7xRo6QPb33MW7ayNl/GqYI5tnOr6MgWs0auTqSgDZsIYk X-Google-Smtp-Source: AGRyM1t/RIM/NG6wrNV2CUbEj0XiBP+uf9zx9+5wmEa45h0AjhyPYCnAvKVLY+dNlAbVlVji65CFgVvbn9fg49LT/lo= X-Received: by 2002:ac5:ce0b:0:b0:36c:34b3:d800 with SMTP id j11-20020ac5ce0b000000b0036c34b3d800mr5477016vki.13.1655894380994; Wed, 22 Jun 2022 03:39:40 -0700 (PDT) MIME-Version: 1.0 References: <3fa500788dfcdcfc9faffb04f1a470fe08ad21b8.1654404125.git.research_trasio@irq.a4lg.com> In-Reply-To: <3fa500788dfcdcfc9faffb04f1a470fe08ad21b8.1654404125.git.research_trasio@irq.a4lg.com> From: Nelson Chu Date: Wed, 22 Jun 2022 18:39:30 +0800 Message-ID: Subject: Re: [PATCH 1/2] RISC-V: Add 'H' to canonical extension ordering To: Tsukasa OI Cc: Palmer Dabbelt , Kito Cheng , Weiwei Li , Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 10:39:43 -0000 Sorry for being late, I have been busy recently. I didn't notice that the isa spec had been updated, anyway, the h is a single extension after v, rather than the multi-letter extension for now. So LGTM, committed. Besides, please give me some time to review other patches, I've been busy with other things for a while... Thanks Nelson On Sun, Jun 5, 2022 at 12:43 PM Tsukasa OI wrote: > > This commit adds 'H' to canonical extension ordering based on current > consensus (not officially ratified as a new ISA specification manual > but discussion for software compatibility is made). > > bfd/ChangeLog > > * elfxx-riscv.c (riscv_ext_canonical_order): Add 'H' for > canonical extension ordering based on current consensus. > --- > bfd/elfxx-riscv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c > index 92ad03feea0..5c2c616a760 100644 > --- a/bfd/elfxx-riscv.c > +++ b/bfd/elfxx-riscv.c > @@ -1345,7 +1345,7 @@ riscv_recognized_prefixed_ext (const char *ext) > } > > /* Canonical order for single letter extensions. */ > -static const char riscv_ext_canonical_order[] = "eigmafdqlcbkjtpvn"; > +static const char riscv_ext_canonical_order[] = "eigmafdqlcbkjtpvnh"; > > /* Array is used to compare the orders of standard extensions quickly. */ > static int riscv_ext_order[26] = {0}; > -- > 2.34.1 >