From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id B72EC3857BA8 for ; Wed, 22 Jun 2022 10:36:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B72EC3857BA8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-vk1-xa30.google.com with SMTP id b5so4807263vkp.4 for ; Wed, 22 Jun 2022 03:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CWglIyY6tTo7+SPHNPbxO1qNMWdEWXUzvmYsH15hOcI=; b=Bx/SfwvC7LVnLicbX60SK4qIISkSxtHY8VTmLWKX7eKgHRJ57YVdOSKWtftAEQ6T3B PfjjFQuy+Jb/vVghyp9mdGLgD/fNpp853/KEnumt/Q0YQK+rmLohu3rMm1XwyVkl+x8F McpWYGUOLnlTHfI5s+eq8TngnEizwZNdreTAPMEXwPIOeWiEOLN7zcADvrlPi3cvSZFv oze86U5DJBd4vA3JN7MyGL+AwajiD4dxcy7zuZ1O/ZtRy9vJcl3EJeAEOyg0lHD+KkXE FgdueJVTxI54/y4UpbJjgTWmXxZ3GxXh3qUImiKtb+0PNGY6pyy0mt+6i5XOt3N5kV9o LKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CWglIyY6tTo7+SPHNPbxO1qNMWdEWXUzvmYsH15hOcI=; b=6z8fZtK5Dd9NUDLxoNljgPIUBbXC5i1x6vK8LLkZpGIBNDkhQLM/89zRfxZHONbuRq yMkndaeSx4osercg2SOOkr12A9ypaGT3adiPRYOvjK702O+WkDSRJhFIi+TorHxlbcRQ 3DWft76sfTL5AncI9dzur3SDVPJ9PD+QuUEG/dt3qapyveVqbfEBGXDeHlURHeo4AJmY MU5O1Yr3OtLZCRGy9CjhLPOIM3WDlYn8XFWCI+efBwvFJXs2anWSm0WtrlWn6PimEeUy zvFFuBGSitRK819YQSxhriKKVZp8uqFG/p0u1lgYEiMr3VyFYXA6D7deoTKoQYXjL1oW eJoA== X-Gm-Message-State: AJIora/I0wEKoThuSCx+vC379aLkt1p61bKssEmOa4YkTI7kWVeOC2cs Gzt27ReXIf41eAcAk5QNHJfo2b3WgALo/k72vzTP0g== X-Google-Smtp-Source: AGRyM1v0aMm/95W87awxhzI/63iq187JSIb6494lCa0XUuSVhiZiv5OAf4nA6rnb4wE44dJZ2cTrGr8xCsMBu888kMk= X-Received: by 2002:a1f:5a0f:0:b0:36c:ef6:cad2 with SMTP id o15-20020a1f5a0f000000b0036c0ef6cad2mr6496434vkb.1.1655894172106; Wed, 22 Jun 2022 03:36:12 -0700 (PDT) MIME-Version: 1.0 References: <0e3c9ab420d8610937845af7a35bacc1672f8a84.1654855051.git.research_trasio@irq.a4lg.com> In-Reply-To: <0e3c9ab420d8610937845af7a35bacc1672f8a84.1654855051.git.research_trasio@irq.a4lg.com> From: Nelson Chu Date: Wed, 22 Jun 2022 18:36:01 +0800 Message-ID: Subject: Re: [PATCH 2/2] RISC-V: Fix inconsistent error message (range) To: Tsukasa OI Cc: Tristan Gingold , Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 10:36:14 -0000 LGTM, so committed Thanks Nelson On Fri, Jun 10, 2022 at 6:00 PM Tsukasa OI wrote: > > This commit fixes inconsistent error message format involving compressed > funct fields. In specific, funct6 had an error message with range > 0..2^ ("0..64") unlike other funct fields with 0..2^-1 > (e.g. funct4 with "0..15"). > > gas/ChangeLog: > > * config/tc-riscv.c (riscv_ip): Fix inconsistent error message. > --- > gas/config/tc-riscv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c > index 1b730b4be36..a10ae8e237b 100644 > --- a/gas/config/tc-riscv.c > +++ b/gas/config/tc-riscv.c > @@ -2582,7 +2582,7 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expressionS *imm_expr, > || imm_expr->X_add_number >= 64) > { > as_bad (_("bad value for compressed funct6 " > - "field, value must be 0...64")); > + "field, value must be 0...63")); > break; > } > INSERT_OPERAND (CFUNCT6, *ip, imm_expr->X_add_number); > -- > 2.34.1 >