From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id 39A8B3857820 for ; Fri, 22 Apr 2022 02:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39A8B3857820 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ua1-x930.google.com with SMTP id o10so2496792uar.0 for ; Thu, 21 Apr 2022 19:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z/oS9sfcaPmDs8jPRmGt7Jv4uY4PRFzU+ZoanzDu1qA=; b=R6lkjWRPULzB6H38JCvtpq/RFkQZ+Ixj+8Rj25e7nNC4ED4BDE16fazNmzzDE7e+hc d5meOGAYG8f8G1Tawtt4/Y0Ax3PSxMG83fMid9PIvTuN5F2mFzbuNz4dNDIdL/AOCNp1 E0VcAShmsuPFu+uFyBdQmEwsHwmq93dpCbjFoNwXDMcgB/zl1y6u17JE2TIfti2qws6S w1W/l5JqlbxCLqm02Wu4iyQArCU5d24n+raSXLeLNpL0ZJBOygMrkVta1l9J4xBSGPf4 Td39X3DN5Dwk4TUdBZGomLBSR/FmyYTyYj5vEGFW3zL2YUixRv34AGbDqoL5dKr8J33W xUlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z/oS9sfcaPmDs8jPRmGt7Jv4uY4PRFzU+ZoanzDu1qA=; b=3L4caZfOitfCXT6voMMEG6P98DA7BnQ8JvVZVOz2R0rJQbYQ5ZwB20ece/1Nt0pRIF PyAeF0kJErGb5DjpoS0I5mKqgs6PeToQ4v6sZ6sn51E8E4xvGXMzaPn5T5fr1hPvQVla s+ibDe9dLadXDNmd5va2sW8qOMUNHPSwCMBT3HDSqern5p0aoP0+uAtEjHyJyxI9H+Gy Eyf5FHDtXts3/eLiBAoqQeLd7wVk61xW4w9n8oUE2PbpScfuDxU/CE7KQWny7HfaROEg 3OkhJQWj8b0XKkjyjlHLFk+JmSsOTqsAqZe8v+fzaaidunF5HfjInHNBgls/bGDECnrw iv5g== X-Gm-Message-State: AOAM533CbfImephHSYrReD43gCwcWyKFoa8L4lKwJQF17RcueoCUhFVS 4iRklGGm30BkGtaKhm+n+tPA3ngzF57q3OGkYFq/pw== X-Google-Smtp-Source: ABdhPJzgndlAWNF5c909rz5jed+XcHDSzAJ2q8o9UP5fllOl9xwLueI4sA1d9Ri+GSgEQFaKYMX7RWB0BORCvafR3ZY= X-Received: by 2002:ab0:638f:0:b0:351:e6e0:7a27 with SMTP id y15-20020ab0638f000000b00351e6e07a27mr862799uao.58.1650592921596; Thu, 21 Apr 2022 19:02:01 -0700 (PDT) MIME-Version: 1.0 References: <20220421223127.2083617-1-cmuellner@gcc.gnu.org> In-Reply-To: <20220421223127.2083617-1-cmuellner@gcc.gnu.org> From: Nelson Chu Date: Fri, 22 Apr 2022 10:01:52 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add missing DECLARE_INSNs for Zicbo{m,p,z} To: Christoph Muellner Cc: Binutils , Kito Cheng , Jim Wilson , Philipp Tomsich , Palmer Dabbelt , Tsukasa OI , Christoph Muellner Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 02:02:05 -0000 LGTM, committed. Thanks. Nelson On Fri, Apr 22, 2022 at 6:31 AM Christoph Muellner wrote: > > The recently added support for the Zicbo{m,p,z} extensions did not > include DECLARE_INSN() declarations for the instructions. > These declarations are needed by GDB's instruction detection code. > This patch adds them. > > Signed-off-by: Christoph Muellner > --- > include/opcode/riscv-opc.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/opcode/riscv-opc.h b/include/opcode/riscv-opc.h > index 3eea33a5dae..15e405bc14e 100644 > --- a/include/opcode/riscv-opc.h > +++ b/include/opcode/riscv-opc.h > @@ -2720,6 +2720,15 @@ DECLARE_INSN(hsv_b, MATCH_HSV_B, MASK_HSV_B) > DECLARE_INSN(hsv_h, MATCH_HSV_H, MASK_HSV_H) > DECLARE_INSN(hsv_w, MATCH_HSV_W, MASK_HSV_W) > DECLARE_INSN(hsv_d, MATCH_HSV_D, MASK_HSV_D) > +/* Zicbop instructions. */ > +DECLARE_INSN(prefetch_r, MATCH_PREFETCH_R, MASK_PREFETCH_R); > +DECLARE_INSN(prefetch_w, MATCH_PREFETCH_W, MASK_PREFETCH_W); > +DECLARE_INSN(prefetch_i, MATCH_PREFETCH_I, MASK_PREFETCH_I); > +/* Zicbom/Zicboz instructions. */ > +DECLARE_INSN(cbo_clean, MATCH_CBO_CLEAN, MASK_CBO_CLEAN); > +DECLARE_INSN(cbo_flush, MATCH_CBO_FLUSH, MASK_CBO_FLUSH); > +DECLARE_INSN(cbo_inval, MATCH_CBO_INVAL, MASK_CBO_INVAL); > +DECLARE_INSN(cbo_zero, MATCH_CBO_ZERO, MASK_CBO_ZERO); > #endif /* DECLARE_INSN */ > #ifdef DECLARE_CSR > /* Unprivileged Counter/Timers CSRs. */ > -- > 2.35.1 >