From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 28F103858430 for ; Tue, 16 Nov 2021 04:07:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28F103858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-io1-xd2e.google.com with SMTP id k21so24295570ioh.4 for ; Mon, 15 Nov 2021 20:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WOANx6e41n9z7uRsbxp5d6IgylP7ORZvQSSlPiWPW9c=; b=L1JL3WvgylYmhHkdNQWMlhJdfbRdaUou5jdNWj349pjxBzV+7lPC3KXnj/NU78VyvP QHhlehqwCPtaliJUx3f0StIJwu7EbeQDFLjeRnDDb2V5qOvS2JMpJx/yOHo8SwaWgZtX P2x1bW9wIMQsM9BmPKuds5NcuPTo3uryhVAIMrBbVELauFQhZdG6HSb5zuNZdclHzyxz 0COU9S9XjKVXEAbbPd5m/CgA8ohfoZ6XVL60U9i0enxUqgev3q0pxrhGEWLqJ6G0V94k UYfUu15tRUySBkTF0Flor7fSMIZwkZAeVL4ns9zjm4ReQHEbhQmCHppsQMlK3wxTH26u t37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WOANx6e41n9z7uRsbxp5d6IgylP7ORZvQSSlPiWPW9c=; b=Zgh6qSaMAhR6nNL099clvLKGD7pIJL1pdObTzy4gwsX6Iqg23fbyTBgn/IPLZhsDQk rwhUmxDi642YihCyG6q2o3EWanxbAhKzn7ZDHVsPVbV40AKMd2sP5myDDa5g+nW5gNmu S7mKhcQbxkh9vY0ddxI3h07L1zYYzojt4K7J84/MuqkY43m4TLW8U7DZVH7pX0Tx4hJa /eCmwdg9KkqAhV225Mnqj8HFUBGDKLBt73IeyncrXJXh0nq9PWLtMx8jYTkXjJO7bKeS gdXxbXFcWG9FzOYZXn4DVDzf8wXcTlPcY1NhoW2s/Up+GGc/22H942df/h7laKCxe6xw rynA== X-Gm-Message-State: AOAM533SryuVzTDtdRXPIuf/b6EVD6vfTZoxWkmSJwXYg/VhYnTf4ceN yWZ5tTmaa82sdNOJOZ2oE0Sl+4O62bjFdqyS2YTHkw== X-Google-Smtp-Source: ABdhPJymsFLG8qLARgHca5/h2EDg6AZNkiTAamMJdlK9gkVaFHy/86qH76bWmhKPI98dR1frkXuApJ3Bef1nlTtRhqc= X-Received: by 2002:a05:6602:2d53:: with SMTP id d19mr2854329iow.77.1637035667511; Mon, 15 Nov 2021 20:07:47 -0800 (PST) MIME-Version: 1.0 References: <20211115030343.276103-1-jiawei@iscas.ac.cn> In-Reply-To: <20211115030343.276103-1-jiawei@iscas.ac.cn> From: Nelson Chu Date: Tue, 16 Nov 2021 12:07:36 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] RISC-V: Support Scalar Cryptography extension To: jiawei Cc: Binutils , Kito Cheng , Jim Wilson , Philipp Tomsich , mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, Palmer Dabbelt , Andrew Waterman , =?UTF-8?B?V2VpIFd1ICjlkLTkvJ8p?= , siyu@isrc.iscas.ac.cn, Andreas Schwab , Jan Beulich Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 04:07:50 -0000 Hi Guys, I have added the missing ChangeLogs in the commit comment, and fixed some minor indent. These k extension patches look good to me, so committed. Thanks Nelson On Mon, Nov 15, 2021 at 11:04 AM jiawei wrote: > > This patch is support Scalar Cryptography extension(k-ext v1.0.0-rc6) as > binutils part, you can find gcc patches part in https://github.com/WuSiYu= /riscv-gcc/tree/trunk-crypto-rebase by siyu@isrc.iscas.ac.cn. > > The first patch fix the order check with 'z' begin sub-extension, it set = 'zb' before 'zk' as a right case. Some instruction in 'zbkb' and 'zbkc' is = both used by Bitmanip and Scalar Cryptography extension, we just redefine t= he class with them. > > Here is the github repo link contain this patch: https://github.com/pz911= 5/riscv-binutils-gdb/commits/k-ext-rebase, the old version of this work is = form https://github.com/riscv-collab/riscv-binutils-gdb/pull/254, Thanks fo= r Nelson Chu and Jim Wilson's review and help. > > Version logs: > > v2: Add missing arch "k" in riscv_supported_std_ext[] to make the order c= heck right with "zk" behind "zb" as Neslon Chu's comment. > > v3: Remove the trailing spaces as Andreas Schwab's comment. Add commit fo= r each patch and add split testcases into sub-extension tests as Christoph = Muellner's comment. > > v4: Change letter order in riscv_supported_std_ext[], Move INSN_CLASS_* i= nto follow patch, Fix SHFL/UNSHFL Mask error, Fix typo error, Add CSR_CLASS= ZKR for ES_CSR as Neslon Chu's comment. > > jiawei (3): > RISC-V: Minimal support of scalar crypto extension > RISC-V: Scalar crypto instructions and operand set > RISC-V: Scalar crypto instruction and Entropy Source CSR testcases > > bfd/elfxx-riscv.c | 53 ++++++++++++ > gas/config/tc-riscv.c | 29 +++++++ > gas/testsuite/gas/riscv/k-ext-64.d | 47 ++++++++++ > gas/testsuite/gas/riscv/k-ext-64.s | 38 ++++++++ > gas/testsuite/gas/riscv/k-ext.d | 44 ++++++++++ > gas/testsuite/gas/riscv/k-ext.s | 35 ++++++++ > .../gas/riscv/priv-reg-fail-version-1p10.d | 2 +- > .../gas/riscv/priv-reg-fail-version-1p11.d | 2 +- > .../gas/riscv/priv-reg-fail-version-1p9p1.d | 2 +- > .../gas/riscv/priv-reg-version-1p10.d | 1 + > .../gas/riscv/priv-reg-version-1p11.d | 1 + > .../gas/riscv/priv-reg-version-1p9p1.d | 1 + > gas/testsuite/gas/riscv/priv-reg.s | 3 + > gas/testsuite/gas/riscv/zbkb-32.d | 22 +++++ > gas/testsuite/gas/riscv/zbkb-32.s | 13 +++ > gas/testsuite/gas/riscv/zbkb-64.d | 24 ++++++ > gas/testsuite/gas/riscv/zbkb-64.s | 15 ++++ > gas/testsuite/gas/riscv/zbkc-32.d | 12 +++ > gas/testsuite/gas/riscv/zbkc-64.d | 12 +++ > gas/testsuite/gas/riscv/zbkc.s | 3 + > gas/testsuite/gas/riscv/zbkx-32.d | 12 +++ > gas/testsuite/gas/riscv/zbkx-64.d | 12 +++ > gas/testsuite/gas/riscv/zbkx.s | 3 + > gas/testsuite/gas/riscv/zknd-32.d | 12 +++ > gas/testsuite/gas/riscv/zknd-32.s | 3 + > gas/testsuite/gas/riscv/zknd-64.d | 15 ++++ > gas/testsuite/gas/riscv/zknd-64.s | 6 ++ > gas/testsuite/gas/riscv/zkne-32.d | 12 +++ > gas/testsuite/gas/riscv/zkne-32.s | 3 + > gas/testsuite/gas/riscv/zkne-64.d | 14 +++ > gas/testsuite/gas/riscv/zkne-64.s | 5 ++ > gas/testsuite/gas/riscv/zknh-32.d | 20 +++++ > gas/testsuite/gas/riscv/zknh-32.s | 11 +++ > gas/testsuite/gas/riscv/zknh-64.d | 18 ++++ > gas/testsuite/gas/riscv/zknh-64.s | 9 ++ > gas/testsuite/gas/riscv/zksed-32.d | 12 +++ > gas/testsuite/gas/riscv/zksed-64.d | 12 +++ > gas/testsuite/gas/riscv/zksed.s | 3 + > gas/testsuite/gas/riscv/zksh-32.d | 12 +++ > gas/testsuite/gas/riscv/zksh-64.d | 12 +++ > gas/testsuite/gas/riscv/zksh.s | 3 + > include/opcode/riscv-opc.h | 75 ++++++++++++++++ > include/opcode/riscv.h | 18 ++++ > opcodes/riscv-dis.c | 8 ++ > opcodes/riscv-opc.c | 86 +++++++++++++++---- > 45 files changed, 735 insertions(+), 20 deletions(-) > create mode 100644 gas/testsuite/gas/riscv/k-ext-64.d > create mode 100644 gas/testsuite/gas/riscv/k-ext-64.s > create mode 100644 gas/testsuite/gas/riscv/k-ext.d > create mode 100644 gas/testsuite/gas/riscv/k-ext.s > create mode 100644 gas/testsuite/gas/riscv/zbkb-32.d > create mode 100644 gas/testsuite/gas/riscv/zbkb-32.s > create mode 100644 gas/testsuite/gas/riscv/zbkb-64.d > create mode 100644 gas/testsuite/gas/riscv/zbkb-64.s > create mode 100644 gas/testsuite/gas/riscv/zbkc-32.d > create mode 100644 gas/testsuite/gas/riscv/zbkc-64.d > create mode 100644 gas/testsuite/gas/riscv/zbkc.s > create mode 100644 gas/testsuite/gas/riscv/zbkx-32.d > create mode 100644 gas/testsuite/gas/riscv/zbkx-64.d > create mode 100644 gas/testsuite/gas/riscv/zbkx.s > create mode 100644 gas/testsuite/gas/riscv/zknd-32.d > create mode 100644 gas/testsuite/gas/riscv/zknd-32.s > create mode 100644 gas/testsuite/gas/riscv/zknd-64.d > create mode 100644 gas/testsuite/gas/riscv/zknd-64.s > create mode 100644 gas/testsuite/gas/riscv/zkne-32.d > create mode 100644 gas/testsuite/gas/riscv/zkne-32.s > create mode 100644 gas/testsuite/gas/riscv/zkne-64.d > create mode 100644 gas/testsuite/gas/riscv/zkne-64.s > create mode 100644 gas/testsuite/gas/riscv/zknh-32.d > create mode 100644 gas/testsuite/gas/riscv/zknh-32.s > create mode 100644 gas/testsuite/gas/riscv/zknh-64.d > create mode 100644 gas/testsuite/gas/riscv/zknh-64.s > create mode 100644 gas/testsuite/gas/riscv/zksed-32.d > create mode 100644 gas/testsuite/gas/riscv/zksed-64.d > create mode 100644 gas/testsuite/gas/riscv/zksed.s > create mode 100644 gas/testsuite/gas/riscv/zksh-32.d > create mode 100644 gas/testsuite/gas/riscv/zksh-64.d > create mode 100644 gas/testsuite/gas/riscv/zksh.s > > -- > 2.25.1 >