From: Nelson Chu <nelson.chu@sifive.com>
To: Jim Wilson <jimw@sifive.com>, Nick Clifton <nickc@redhat.com>
Cc: Binutils <binutils@sourceware.org>, Alan Modra <amodra@gmail.com>,
Kito Cheng <kito.cheng@sifive.com>
Subject: Re: [PATCH] RISC-V: Add bfd/cpu-riscv.h to support all spec versions controling.
Date: Thu, 18 Feb 2021 15:43:14 +0800 [thread overview]
Message-ID: <CAJYME4Gc4c1TP5TP0Sgwy6pDJAWLVPT5uWKpouR_j0ToHyySpQ@mail.gmail.com> (raw)
In-Reply-To: <CAFyWVab_Y2G14LHVPVY4m-dZ22RZch67P0qaaTMtnunH6YcjfQ@mail.gmail.com>
Hi Nick and Jim,
Thanks for the reviews and approvals! I have commited the v2 patch,
and also fixed some conflicts and typos.
On Thu, Feb 18, 2021 at 6:50 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Tue, Feb 16, 2021 at 6:05 PM Nelson Chu <nelson.chu@sifive.com> wrote:
>>
>> > diff --git a/bfd/doc/Makefile.in b/bfd/doc/Makefile.in
>> > index 1902697..129cadc 100644
>> > --- a/bfd/doc/Makefile.in
>> > +++ b/bfd/doc/Makefile.in
>> > @@ -377,6 +377,7 @@ pdfdir = @pdfdir@
>> > prefix = @prefix@
>> > program_transform_name = @program_transform_name@
>> > psdir = @psdir@
>> > +runstatedir = @runstatedir@
>> > sbindir = @sbindir@
>> > sharedstatedir = @sharedstatedir@
>> > srcdir = @srcdir@
>>
> FYI This runstatedir stuff is a feature not in the last FSF autoconf release from 2012, but present in some linux distros. To avoid this problem, you shouldn't use /usr/bin/autoconf or automake. Rather, you should build them directly from FSF autoconf/automake sources, using the same version that is mentioned in the comments at the top of the generated files, and then use your own programs when regenerating toolchain files. If you did that, then you wouldn't have a change for this file. The same change would also be missing from other Makefile.in files. But this is a minor issue, and will likely be fixed next time someone regenerates the files.
>
> The autoconf-2.69 we use was released in 2012. There are now autoconf 2.70 (Dec 2020) and 2.71 (Jan 2021) releases. If we upgraded to a newer autoconf release that would fix this problem. Though of course it might cause other problems. A lot of stuff could have changed in the last 9 years.
That's weird, even if I have switched to the approved versions of auto
tools (autoconf 2.69 and automake 1.15.1), I still get the
"runstatedir" in my Makefile.in. I guess that is because I used to
regenerate the files by running autoconf and automake separately.
Kito suggests that using the "export PATH" to set the auto tools, and
then run autoreconf should be better. After that, I can regenerate
the expected files without the "runstatedir".
Thanks for all
Nelson
prev parent reply other threads:[~2021-02-18 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 4:46 Nelson Chu
2021-02-17 2:05 ` Nelson Chu
2021-02-17 10:56 ` Nick Clifton
2021-02-17 22:49 ` Jim Wilson
2021-02-18 7:43 ` Nelson Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJYME4Gc4c1TP5TP0Sgwy6pDJAWLVPT5uWKpouR_j0ToHyySpQ@mail.gmail.com \
--to=nelson.chu@sifive.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jimw@sifive.com \
--cc=kito.cheng@sifive.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).