From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id E97FF385800A for ; Thu, 18 Feb 2021 07:43:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E97FF385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nelson.chu@sifive.com Received: by mail-io1-xd29.google.com with SMTP id q7so1105077iob.0 for ; Wed, 17 Feb 2021 23:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=auqza8WCmi9046IE57Pm6dm0bXgFeu/D9k7a5Ge1mv4=; b=ZetWHnyOfnddVllql29PiCUKk3n9CIDgOrHWDuovG2DZTjCrdBmYR+SVzYgVfB3csv XuNTjDw2C5FFJSGheYjjyve8GmGrl4uIgirYvFxIBQU4xyjuV/SjCM8GETEw3AayHH8w Kqsh11tFv6cmcndBNT6nvetWD6WWXN0JWtS8qW7t9tHIBdgO18f3tsRj20ZcSvTFx6xh Y/NM54jKInJcAUNSHGNV+IKizck8zv2w1CHZRCEbHWADi9x1x/ubX2c8bXwDWP6817Xz UMQnSlZMqJJ1R9GqPNDjnlODWXf9t31r7GfAii4nXF8HezG4aTCV1WDdfULY+M403ySg mB/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=auqza8WCmi9046IE57Pm6dm0bXgFeu/D9k7a5Ge1mv4=; b=iR4HNCvtUzsNrAfW60dumjwnhxdYhx0MLE3Iyn6IyxtcdhwMmi9/BWjRtwIMZzWIa2 tYCteQuzO/HxYf31NTJ95yZzU0asWYr5tQuDcSocsEPG4oJ5Tn2SpwFrZlUK/a6l2+/f 9fIuBgfRhABteI6P+EFHayWhC2nPHxJJZkev5++eNAEJC25IZ8taYFKC4yeU1onBktTa K2DNwd4XucVwus3LJfqQBUAzx5uN3ZforBs6GJ1TcPqP24XPnq/ah6rGfTalxquPO9ic bolZfvQNtAQ6I3WUxcR4Ubc6wNKRoXabrQXAIVdSzOSFpcb5w3Gg35XpKtmDrk/t+AcI coaw== X-Gm-Message-State: AOAM532wYwqw6BD2CNfM1+4ztyaXB9oPNaMABUPmY9/vObrtcpuLzTDa orULt6b0x3BN1yC82bt4xN+bhNagjkR/1L1jFsDviQ== X-Google-Smtp-Source: ABdhPJya7XCoTyGBe8zxQ6Qqj2llT/epePcKd94OrNgSLQXXv8Z8FtELY54KXnL8FpxMWL9ld5nqt3A0TO3FB/q/IuI= X-Received: by 2002:a05:6602:2bd6:: with SMTP id s22mr2641778iov.39.1613634205473; Wed, 17 Feb 2021 23:43:25 -0800 (PST) MIME-Version: 1.0 References: <1611809168-2570-1-git-send-email-nelson.chu@sifive.com> In-Reply-To: From: Nelson Chu Date: Thu, 18 Feb 2021 15:43:14 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add bfd/cpu-riscv.h to support all spec versions controling. To: Jim Wilson , Nick Clifton Cc: Binutils , Alan Modra , Kito Cheng Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 07:43:28 -0000 Hi Nick and Jim, Thanks for the reviews and approvals! I have commited the v2 patch, and also fixed some conflicts and typos. On Thu, Feb 18, 2021 at 6:50 AM Jim Wilson wrote: > > On Tue, Feb 16, 2021 at 6:05 PM Nelson Chu wrote: >> >> > diff --git a/bfd/doc/Makefile.in b/bfd/doc/Makefile.in >> > index 1902697..129cadc 100644 >> > --- a/bfd/doc/Makefile.in >> > +++ b/bfd/doc/Makefile.in >> > @@ -377,6 +377,7 @@ pdfdir =3D @pdfdir@ >> > prefix =3D @prefix@ >> > program_transform_name =3D @program_transform_name@ >> > psdir =3D @psdir@ >> > +runstatedir =3D @runstatedir@ >> > sbindir =3D @sbindir@ >> > sharedstatedir =3D @sharedstatedir@ >> > srcdir =3D @srcdir@ >> > FYI This runstatedir stuff is a feature not in the last FSF autoconf rel= ease from 2012, but present in some linux distros. To avoid this problem, = you shouldn't use /usr/bin/autoconf or automake. Rather, you should build = them directly from FSF autoconf/automake sources, using the same version th= at is mentioned in the comments at the top of the generated files, and then= use your own programs when regenerating toolchain files. If you did that,= then you wouldn't have a change for this file. The same change would also= be missing from other Makefile.in files. But this is a minor issue, and w= ill likely be fixed next time someone regenerates the files. > > The autoconf-2.69 we use was released in 2012. There are now autoconf 2.= 70 (Dec 2020) and 2.71 (Jan 2021) releases. If we upgraded to a newer auto= conf release that would fix this problem. Though of course it might cause = other problems. A lot of stuff could have changed in the last 9 years. That's weird, even if I have switched to the approved versions of auto tools (autoconf 2.69 and automake 1.15.1), I still get the "runstatedir" in my Makefile.in. I guess that is because I used to regenerate the files by running autoconf and automake separately. Kito suggests that using the "export PATH" to set the auto tools, and then run autoreconf should be better. After that, I can regenerate the expected files without the "runstatedir". Thanks for all Nelson