From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id 8C0403858D28 for ; Fri, 17 Dec 2021 15:23:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C0403858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ua1-x930.google.com with SMTP id y23so4966469uay.7 for ; Fri, 17 Dec 2021 07:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NjppT4xdDPGZYuIZfBERUnKpsn+px8gjeabggnwJm8c=; b=S4IHdqBeoeYRaKu46dYYVdJKaxI4xOnx8iAyAN/s4hCVMKSqmlo6bVBfY4D/CI6IVG jtsNzHPwldgzjVCE0C6Rd23Ju/WJSEDH62FT3AJFnsFuP4XVMIihjorphGFCdmETLr5w gNlcdr3MR7X6v+bBbNZlmqdjZ3bc1H6jO0DAbNyENmhDdrHbaJRqpyVXp98JWuxnrrsB bjzGwwefhwH6pNe36PHYuwAtT8FfD4rrOkqv5jW5SJiAkVmBtPISc7NwTVb/7z+FXXDw YvD/E9WkIyXt5gargYCEB9uNMhYgAuKEMDT0UIVqM7Sxy8Bw6z7jnArydboPdotBqVYG vLiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NjppT4xdDPGZYuIZfBERUnKpsn+px8gjeabggnwJm8c=; b=g8x3+Qh/39g4J1Qru8crNN1HvlSM6++3pnmGuf60ayAXNNmw0zXHzvS98iUCl2KNzr RvxXe7udzcpH0w2boX+skLVvfa70MD2uTAb4s+If7mr3sB6oUGr+DKedOatcKbhziSoD cm05SvY2x/ozOKHsMOdMTconnTBmLn7NCBjdsmkKiJPBSYohCfYf31ybkqRYAMKugtu3 LZcCtAENDR5EOUtlbAknOUQ3W4o5ydsOa8ewWfM2g1yswatfXo9f9+rRhQip92mOcFxw weYBTume7N2+hBkFQ18B4gDGtC8SwzHAyGtVm4d1ETyCvxUdUFHNGxLc5V4SXxqHIvO6 5JEQ== X-Gm-Message-State: AOAM532PXES035x/0WGK9No48iBubmYUZWod26unW7cDGOaiQnmO+yVT hv39yOXjdjWEOWindW76aDjkq+ZvmZ9814vADxTIFskLBTQ= X-Google-Smtp-Source: ABdhPJwZzO/YCaR1nosRro01HVmhbaHhfkujGIsOnYKiQKUR0jE7L66NENx8UUqCetKYBLySRO/ai9ekj+JekV8Mxsk= X-Received: by 2002:a05:6102:3f50:: with SMTP id l16mr1314755vsv.85.1639754597082; Fri, 17 Dec 2021 07:23:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Nelson Chu Date: Fri, 17 Dec 2021 23:23:06 +0800 Message-ID: Subject: Re: [PATCH 0/5] RISC-V: Add Ratified Cache Management Operation ISA Extensions To: Tsukasa OI Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 15:23:19 -0000 Hi Tsukasa, Thanks for implementing these extensions, LGTM. But I notice that your copyright assignment is only for GNU WGET, and it seems it doesn't cover the changes of binutils. It would be great if you could check this for us, thanks. Nelson On Thu, Dec 16, 2021 at 7:10 PM Tsukasa OI via Binutils wrote: > > This patchset adds support for three recently ratified RISC-V extensions: > > - Zicbom (Cache-Block Management Instructions) > - Zicbop (Cache-Block Prefetch hint instructions) > - Zicboz (Cache-Block Zero Instructions) > > `prefetch.[irw]' hint instructions in Zicbop extension require new operand > type which is pseudo S-type immediate with low 5-bits set to zero > (32-byte aligned). So, Zicbop changes are separate from Zicbom/Zicboz: > > Patch 1: Zicbom/z/p (common) > Patch 2/3: Zicbom/z (regular CBO instructions) > Patch 4/5: Zicbop (prefetch hint instructions) > > cf. > > > > > Tsukasa OI (5): > RISC-V: Add mininal support for Zicbo[mpz] > RISC-V: Cache management instructions > RISC-V: Cache management instruction testcases > RISC-V: Prefetch hint instructions and operand set > RISC-V: Prefetch hint instruction testcases > > bfd/elfxx-riscv.c | 9 +++++++++ > gas/config/tc-riscv.c | 17 +++++++++++++++++ > gas/testsuite/gas/riscv/zicbom.d | 15 +++++++++++++++ > gas/testsuite/gas/riscv/zicbom.s | 7 +++++++ > gas/testsuite/gas/riscv/zicbop-fail.d | 3 +++ > gas/testsuite/gas/riscv/zicbop-fail.l | 4 ++++ > gas/testsuite/gas/riscv/zicbop-fail.s | 4 ++++ > gas/testsuite/gas/riscv/zicbop.d | 12 ++++++++++++ > gas/testsuite/gas/riscv/zicbop.s | 4 ++++ > gas/testsuite/gas/riscv/zicboz.d | 11 +++++++++++ > gas/testsuite/gas/riscv/zicboz.s | 3 +++ > include/opcode/riscv-opc.h | 14 ++++++++++++++ > include/opcode/riscv.h | 3 +++ > opcodes/riscv-dis.c | 4 ++++ > opcodes/riscv-opc.c | 9 +++++++++ > 15 files changed, 119 insertions(+) > create mode 100644 gas/testsuite/gas/riscv/zicbom.d > create mode 100644 gas/testsuite/gas/riscv/zicbom.s > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.d > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.l > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.s > create mode 100644 gas/testsuite/gas/riscv/zicbop.d > create mode 100644 gas/testsuite/gas/riscv/zicbop.s > create mode 100644 gas/testsuite/gas/riscv/zicboz.d > create mode 100644 gas/testsuite/gas/riscv/zicboz.s > > > base-commit: 23ff54c27d535727c1c467abdd4bed8fbd46d4a6 > -- > 2.32.0 >