public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nelson Chu <nelson.chu@sifive.com>
To: Jim Wilson <jimw@sifive.com>
Cc: Binutils <binutils@sourceware.org>,
	Kito Cheng <kito.cheng@sifive.com>,
	 Andrew Waterman <andrew@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] RISC-V: Add sext.[bh] and zext.[bhw] pseudo instructions.
Date: Thu, 10 Dec 2020 11:12:26 +0800	[thread overview]
Message-ID: <CAJYME4Hx4=7Z1JqYve5XCR=qpijCB=WMijQ6Bk2RL1fF3e8jkg@mail.gmail.com> (raw)
In-Reply-To: <CAFyWVaYVvddgkMe-WT3FoYOoMRSBwu-z6OAmsRQWTdTbPXgDgg@mail.gmail.com>

On Thu, Dec 10, 2020 at 7:24 AM Jim Wilson <jimw@sifive.com> wrote:
> I don't think that the -Mno-aliases testcases are very useful.  Doesn't help test the macro instruction assembly support.  And there is no disassembly support for macro instructions, so there doesn't seem to be much point to it.  They might be useful with B extension support though, since in that case they are all aliases not macros, and testing disassembly of aliases with and without -Mno-aliases is useful.  Anyways, there is no harm to it, and if you want to add them that is fine.

Thanks, I remove the aliases testcases until we have supported the b
extensions.  Add the aliases testcases for b should be enough in this
case.

Fixed and committed.

Thanks
Nelson

      reply	other threads:[~2020-12-10  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09  7:22 Nelson Chu
2020-12-09 23:24 ` Jim Wilson
2020-12-10  3:12   ` Nelson Chu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJYME4Hx4=7Z1JqYve5XCR=qpijCB=WMijQ6Bk2RL1fF3e8jkg@mail.gmail.com' \
    --to=nelson.chu@sifive.com \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=jimw@sifive.com \
    --cc=kito.cheng@sifive.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).