From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55473 invoked by alias); 20 Sep 2017 22:30:34 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 55313 invoked by uid 89); 20 Sep 2017 22:30:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1474, H*Ad:D*cisco.com X-HELO: mail-yw0-f194.google.com Received: from mail-yw0-f194.google.com (HELO mail-yw0-f194.google.com) (209.85.161.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 22:30:18 +0000 Received: by mail-yw0-f194.google.com with SMTP id r85so2026411ywg.3 for ; Wed, 20 Sep 2017 15:30:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1lGJmiklZuL+Ro0S4Gq+wj/iKd6uszk2pmw6SDySGC8=; b=hRbe1ARFhhCKpZTM+Ac9HZ/ZP1ye0bAA/eDuBvcL9hSaigxe5Bu/Yp1xHIIXMtE5Ru U2dXcgfomyY1SiAeQjPkD1IV6Fr1T3ljK8fvVmNe88drlmXXWgIEcihAUGHd6eWvGo2D Lv1hI21IY4AZIJaPhzIu+rYX71dbWiTul3W02oARt1s/CymPhdnDX30iah4z+1jgRvdI 0iigZKe0VaSI3Am4UQ4MMuIpAIIC365z1b2nLDu6UuKOuciv86k648ZreuDVT0uJKXX9 OfKYmL/6i7yQg+MMww6Q+N4yFH4H95re44LrMD5cjzxyPUlNIDuq4dKwdw070eHVjrFj fofg== X-Gm-Message-State: AHPjjUir/Q3ilb7wnAITlxZvTXZRv/URn3sGyJOIodnYEkBhTnsiQECs 7Q0PpJiSfAih2zSaFTSz8xWn134pZphMQDNdsfA= X-Google-Smtp-Source: AOwi7QC1ETelHKN02bf9zVcLOxGs1J34PL+zdHWMAVdp9bB/rSrhtxQ37v5A7MFhKYE8PKQjgqmn+TskrG3Bh1MGeTY= X-Received: by 10.37.44.71 with SMTP id s68mr168767ybs.121.1505946611029; Wed, 20 Sep 2017 15:30:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.192.1 with HTTP; Wed, 20 Sep 2017 15:30:10 -0700 (PDT) In-Reply-To: References: From: Cary Coutant Date: Wed, 20 Sep 2017 22:30:00 -0000 Message-ID: Subject: Re: [Patch][Gold] BE8 for ARM To: Umesh Kalappa Cc: "Bharathi Seshadri (bseshadr)" , "Richard Earnshaw (lists)" , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00203.txt.bz2 >> Arm/thumb stubs support was missed in the be8 mode with the previous >> patch, hence adding the same with the unit cases. >> >> No Regress on gold test-suites. + if (enable_be8) + elfcpp::Swap<16, false>::writeval(pov, insns[i].data() & 0xffff); + else + elfcpp::Swap<16, big_endian>::writeval(pov, insns[i].data() & 0xffff); These lines are not indented correctly. + if (enable_be8) + elfcpp::Swap<16, false>::writeval( + pov,this->thumb16_special(i)); + else + elfcpp::Swap<16, big_endian>::writeval( + pov,this->thumb16_special(i)); Same here. + if (enable_be8) { + elfcpp::Swap<16, false>::writeval(pov, hi); + elfcpp::Swap<16, false>::writeval(pov + 2, lo); + } + else { + elfcpp::Swap<16, big_endian>::writeval(pov, hi); + elfcpp::Swap<16, big_endian>::writeval(pov + 2, lo); + } } break; case Insn_template::ARM_TYPE: + if (enable_be8) + elfcpp::Swap<32, false>::writeval(pov, insns[i].data()); + else + elfcpp::Swap<32, big_endian>::writeval(pov, insns[i].data()); + break; And here. I think this comment from Stub::do_fixed_endian_write() can be removed: // FIXME: We do not handle BE8 encoding yet. diff --git a/gold/testsuite/arm_farcall_arm_arm_be8.sh b/gold/testsuite/arm_farcall_arm_arm_be8.sh new file mode 100644 index 0000000..e21a16d --- /dev/null +++ b/gold/testsuite/arm_farcall_arm_arm_be8.sh The new shell script files should be executable. Please make sure they're marked that way in your git repo. -cary