From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id D6AB93857C44 for ; Thu, 10 Nov 2022 21:46:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6AB93857C44 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x435.google.com with SMTP id y203so3221271pfb.4 for ; Thu, 10 Nov 2022 13:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4WcKPN9aw+xz3uml+I9xO3kz7npknIVMI4N+ZmyIW4E=; b=KdlCd0iQKV4o2bdzm3fbRXAzwmDLKTV4y5Cn2qfdrxkG6sUReqAuO98IxWsbwczUfS 3dU+hWLFPca92fE7AVoccMoUfLK6dhUovfHsrT0DLKO692FOF63YmQ/mHs7btmHcClOK Oy+7sJ57fzT6Qu7Zek7uDB3FJi5yRbuJAqfqe8Z/W0Jk82EI1qIS3NfGK+EPziOKhVBq Sw0YuSjVkcWhTH+i0RBnKQAZOuip6dGuIwGpyCM97i5kSzQEufpU5y5F0X0Z8kNMeltc tlxJdXoHs0YP8nlczf7/3YIIcZoYzBuEzOfAn5wswowZmDpj0s9pwLGHZ4qwnDaOZ+qE EGSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4WcKPN9aw+xz3uml+I9xO3kz7npknIVMI4N+ZmyIW4E=; b=gsOADizYJ06rdsUBZP0MnlYZaBlle+TBeEVlY3pLcU0pT2alzNiZ8rWuaRnlhYISpy 2hfkt0jVfyXjt3bEatjNDZwCuctsfF9AHz7PTpUllV8aQYUb5ciHh1ssiTD+YzWjVI53 U002yUKXDR3sAdRMLfh3faCzANoTzQXh3kkvjCxOD/KkjPlDa8yR0V0ntFXh/XgC7Vf2 hM/xmWY6mcyY9hOfM96DTuLYLpVvzB8cpLjhkAVO2byqWQVlRWowk7h2exbA98/PsMuN PR94DnsdIw49Uo/gWpDwc2bTXEAkZsb+VRUYU3yJ00GOJzOSXOkx6tf9/9ioisB8T0Xi NdCA== X-Gm-Message-State: ACrzQf3rg4mnknDDP6he6Ht4Iydhc50ntOm0pXV1cKrChSJl5LaFJKCc v6KsXb3d2QGYdL4yjAagRjQjXpotyH8QmxmJt+w= X-Google-Smtp-Source: AMsMyM4UhQfGwp692R7lBD7oFwcTWPcpiQ4CvKGDqUDJBx2HVoiQoWj7bQfkE+J/UJaW5gxBSMfy0GWXanV3JUyZCnI= X-Received: by 2002:a63:d448:0:b0:458:607f:a814 with SMTP id i8-20020a63d448000000b00458607fa814mr3350658pgj.62.1668116785558; Thu, 10 Nov 2022 13:46:25 -0800 (PST) MIME-Version: 1.0 References: <20221001023846.590825-1-maskray@google.com> In-Reply-To: <20221001023846.590825-1-maskray@google.com> From: Cary Coutant Date: Thu, 10 Nov 2022 13:46:14 -0800 Message-ID: Subject: Re: [PATCH] gold: add --compress-debug-sections=zstd [PR 29641] To: Fangrui Song Cc: Alan Modra , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > gold/testsuite/Makefile.am | 5 ++++ @@ -3120,6 +3120,15 @@ gdb_index_test_2_gabi: gdb_index_test_cdebug_gabi.o gcctestdir/ld $(CXXLINK) -Wl,--gdb-index $< gdb_index_test_2_gabi.stdout: gdb_index_test_2_gabi $(TEST_READELF) --debug-dump=gdb_index $< > $@ +check_SCRIPTS += gdb_index_test_2_zstd.sh +check_DATA += gdb_index_test_2_zstd.stdout +MOSTLYCLEANFILES += gdb_index_test_2_zstd.stdout gdb_index_test_2_zstd +gdb_index_test_cdebug_zstd.o: gdb_index_test.cc + $(CXXCOMPILE) -O0 -g -Wa,--compress-debug-sections=zstd -c -o $@ $< +gdb_index_test_2_zstd: gdb_index_test_cdebug_zstd.o gcctestdir/ld + $(CXXLINK) -Wl,--gdb-index $< +gdb_index_test_2_zstd.stdout: gdb_index_test_2_zstd + $(TEST_READELF) --debug-dump=gdb_index $< > $@ These new tests should be conditioned by HAVE_ZSTD, shouldn't they? Otherwise, looks good to me. -cary