From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 0ED3F385828E for ; Thu, 10 Nov 2022 21:47:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0ED3F385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x532.google.com with SMTP id 78so2808866pgb.13 for ; Thu, 10 Nov 2022 13:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+oXBdg6x2exGJ5fYjvwaRnEeAUfsPfXM4mX9pFkA5kE=; b=ZHO0hCgXSSzV6ge6CJb5j2ebETyhBfIA9CKgOGAGzhq0aWcyoSA6bkIDGxN1Zwav0L R1hXgpzYg8wN/SYVSfZbCXcqzhF+EA7yS2rtPxQSn/4pFoMbCgFFv+XvbduQ2e2Z0N1b TVtA3IY7QphFAkmWw/l9kQc0GwIR8593F9249bE1FC42/RS6dEcqEsHRQoGLgMLBrSfP yMABHPkfkL+NbilUIBs/D1BFyLNOUFSGFHQcyCyBbvrqXpyzo80+074rlsjZO2ZqSFsR uYo+Xq4o50gIkYLAK40E+VAoKo38LZ5CfgeX/a8soeVxM+VVa6gZghhjxZRqFPUxlFY0 0rXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+oXBdg6x2exGJ5fYjvwaRnEeAUfsPfXM4mX9pFkA5kE=; b=tEx/3AC+o+PxE/4Hp71/fovvLcXRPoRWP9GtdvvQBMYK1LspQbHIY2NemzLN9qS3nN 05wwX3P2+Md9EEe8sePgR3Jz1kPET7x8/Srbf6sVPyJC2JHPN8k5hA+eGHNS2jZSn3sY SWbwBBxVOVzvWMJmG77WHR8bNwATZDT+z3bsFTy5wgU4VhQusrQ57CnTbjeHwf4SJ/14 8Wf9j0q7GGio8rcSSpb+o3hNRxn7QbHMhpFeRdhisfqByPMK7C4GYbaJaR0GxJmEaBzQ 1D6/6+7MM9nxWBKi42haFilCCys78gB3f7ikcZK3dbqRIpYn0umJUxJ1K3uo7EDiB9C2 s7NQ== X-Gm-Message-State: ACrzQf02sd1GmayDsFtaX5A4eV+7X+iu2Vpd3s+jZ/CKpkpK1KdeU7oZ F7Yc/GvJ889nVBk8E61MHMHCC/eevIKvexwaIl0= X-Google-Smtp-Source: AMsMyM7jivkmS3ykRCRvTJK2/HQY6DT5Lzm9+LPGgim1a9AEO2j2bmMZux3aIQjMLto6mcuiOvUS92WSp2JOfen6+Hc= X-Received: by 2002:a63:1e59:0:b0:46f:cbcb:761a with SMTP id p25-20020a631e59000000b0046fcbcb761amr3412700pgm.82.1668116836893; Thu, 10 Nov 2022 13:47:16 -0800 (PST) MIME-Version: 1.0 References: <20221001023846.590825-1-maskray@google.com> In-Reply-To: From: Cary Coutant Date: Thu, 10 Nov 2022 13:47:05 -0800 Message-ID: Subject: Re: [PATCH] gold: add --compress-debug-sections=zstd [PR 29641] To: Fangrui Song Cc: Alan Modra , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > > gold/testsuite/Makefile.am | 5 ++++ > > @@ -3120,6 +3120,15 @@ gdb_index_test_2_gabi: > gdb_index_test_cdebug_gabi.o gcctestdir/ld > $(CXXLINK) -Wl,--gdb-index $< > gdb_index_test_2_gabi.stdout: gdb_index_test_2_gabi > $(TEST_READELF) --debug-dump=gdb_index $< > $@ > +check_SCRIPTS += gdb_index_test_2_zstd.sh > +check_DATA += gdb_index_test_2_zstd.stdout > +MOSTLYCLEANFILES += gdb_index_test_2_zstd.stdout gdb_index_test_2_zstd > +gdb_index_test_cdebug_zstd.o: gdb_index_test.cc > + $(CXXCOMPILE) -O0 -g -Wa,--compress-debug-sections=zstd -c -o $@ $< > +gdb_index_test_2_zstd: gdb_index_test_cdebug_zstd.o gcctestdir/ld > + $(CXXLINK) -Wl,--gdb-index $< > +gdb_index_test_2_zstd.stdout: gdb_index_test_2_zstd > + $(TEST_READELF) --debug-dump=gdb_index $< > $@ > > These new tests should be conditioned by HAVE_ZSTD, shouldn't they? > > Otherwise, looks good to me. Oops, this reply is for the other thread. Sorry! -cary