From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id EEF02385829C for ; Fri, 5 Aug 2022 00:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEF02385829C Received: by mail-pj1-x1032.google.com with SMTP id h21-20020a17090aa89500b001f31a61b91dso6815225pjq.4 for ; Thu, 04 Aug 2022 17:41:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=trqq18FkFqxCJe8rVf1YZEmz5ulXIaTos4ClsDydsKA=; b=tUKhGK0un6xm+q7BfRJhMUX1POHMYi1QN7aehInQ96SWHU2z+JWYIzyGcp7RMFvxEI MFz3AyQjf09YU5T68ZGGaPVv5A2FHMEIjcDj9iG5/QDja4ZsIrT6Wbsw1F7MiZ417DKj CGP793JPjB5yYPGvIH5yPmTr/ek54UxhpCuJFgMZLouhmX6yN6BTYS1Rsah4AJ7e4/nN xSCcPqjjkDYIqVgBw7NX7jjfL7pPzal3GGTNnreVOycrpWLrv0XeiPCKlWB3SAY+ZDR7 dMoJWOvsDybkEIvxYDmEXWMxIVfasQo6OQPaU4hzW9kuR1KtQ+JorrJg4gBe2OTUqUjc n/HA== X-Gm-Message-State: ACgBeo0Kr2SJHxh711IClPKL/l6A7v4y7D5jB4faBjqU+esz432m7ixz Ojo2Z2Vz/Y/emKFIMFZ4uRZ1dgRnfVeLqSidEqI= X-Google-Smtp-Source: AA6agR5atevf28bNrFPCM0vz/n2V0s1pJFdRlTijeyd+xZ3fZnT+8J0rvN+F/G6ghfA8q52UNsQh+pE9N8SbORn+EbI= X-Received: by 2002:a17:90b:1894:b0:1f5:1041:a4ed with SMTP id mn20-20020a17090b189400b001f51041a4edmr4816436pjb.125.1659660090810; Thu, 04 Aug 2022 17:41:30 -0700 (PDT) MIME-Version: 1.0 References: <20220726192216.1751042-1-luca.boccassi@gmail.com> <20220729222956.79836-1-luca.boccassi@gmail.com> In-Reply-To: <20220729222956.79836-1-luca.boccassi@gmail.com> From: Cary Coutant Date: Thu, 4 Aug 2022 17:41:19 -0700 Message-ID: Subject: Re: [PATCH v2] gold: add --package-metadata To: luca.boccassi@gmail.com Cc: Binutils , Nick Clifton , Alan Modra Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 00:41:36 -0000 > v2: apply fixes from review > > elfcpp/elfcpp.h | 4 ++- > gold/Makefile.am | 8 ++--- > gold/configure.ac | 26 ++++++++++++++ > gold/layout.cc | 50 ++++++++++++++++++++++++++ > gold/layout.h | 6 ++++ > gold/options.h | 4 +++ > gold/testsuite/Makefile.am | 15 +++++--- > gold/testsuite/package_metadata_main.c | 5 +++ Committed. Thanks! elfcpp/ * elfcpp.h: Add FDO_PACKAGING_METADATA note type. gold/ * Makefile.am: Add jansson flags and libraries. * configure.ac: Check for jansson library. * layout.cc (Layout::create_notes): Call create_package_metadata(). (Layout::create_package_metadata): New function. * layout.h (Layout::create_package_metadata): New function. (Layout::package_metadata_note_): New data member. * options.h (class General_options): Add --package-metadata option. * testsuite/Makefile.am (object_unittest): Add jansson libraries. (binary_unittest): Likewise. (leb128_unittest): Likewise. (overflow_unittest): Likewise. (package_metadata_test): New test. * testsuite/package_metadata_main.c: New test source. -cary