* [PATCH][gold] Mips: Remove gold_unreachable from get_reference_flags
@ 2017-02-07 19:00 Vladimir Radosavljevic
2017-02-15 8:58 ` Cary Coutant
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Radosavljevic @ 2017-02-07 19:00 UTC (permalink / raw)
To: binutils; +Cc: ccoutant, Petar Jovanovic
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
gold_unreachable in Scan::get_reference_flags prevents gold to produce error if
relocation is not supported.
Regards,
Vladimir
ChangeLog -
* mips.cc (Target_mips::Scan::get_reference_flags): Remove
gold_unreachable from default case.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: remove_unreachable.patch --]
[-- Type: text/x-patch; name="remove_unreachable.patch", Size: 377 bytes --]
diff --git a/gold/mips.cc b/gold/mips.cc
index 56af570..349174f 100644
--- a/gold/mips.cc
+++ b/gold/mips.cc
@@ -12261,7 +12261,6 @@ Target_mips<size, big_endian>::Scan::get_reference_flags(
case elfcpp::R_MIPS_COPY:
case elfcpp::R_MIPS_JUMP_SLOT:
default:
- gold_unreachable();
// Not expected. We will give an error later.
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][gold] Mips: Remove gold_unreachable from get_reference_flags
2017-02-07 19:00 [PATCH][gold] Mips: Remove gold_unreachable from get_reference_flags Vladimir Radosavljevic
@ 2017-02-15 8:58 ` Cary Coutant
0 siblings, 0 replies; 2+ messages in thread
From: Cary Coutant @ 2017-02-15 8:58 UTC (permalink / raw)
To: Vladimir Radosavljevic; +Cc: binutils, Petar Jovanovic
> gold_unreachable in Scan::get_reference_flags prevents gold to produce error if
> relocation is not supported.
>
> * mips.cc (Target_mips::Scan::get_reference_flags): Remove
> gold_unreachable from default case.
Committed on your behalf.
Thanks!
-cary
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-15 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-07 19:00 [PATCH][gold] Mips: Remove gold_unreachable from get_reference_flags Vladimir Radosavljevic
2017-02-15 8:58 ` Cary Coutant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).