From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6414 invoked by alias); 20 Oct 2017 04:00:32 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 6271 invoked by uid 89); 20 Oct 2017 04:00:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-yw0-f177.google.com Received: from mail-yw0-f177.google.com (HELO mail-yw0-f177.google.com) (209.85.161.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Oct 2017 04:00:18 +0000 Received: by mail-yw0-f177.google.com with SMTP id t71so5371989ywc.3 for ; Thu, 19 Oct 2017 21:00:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h7u4nUPXEB8dCSqyolsG6bsLPG7a7sL3c01dGfjHOek=; b=VozOJr6IWrb1qeBRTH6r14dkQY+wHVrqGfNi6qBs8cUkzjdMlNH8Z4aMvnKLJCEUCQ klbFJ4MFGmqPYi8K8VTFfpJHwym4u6PzWrh/NzktQnj+02s9VsLGnHfc79b/3dyFhbQa Hn8/Lsj3HI6GRCXncqdozIj2ChjSk5DDW5nWDQodso03ECjhiIG/LSRG7k+5PjRccRHW +yhdijhXzHY/9hWkZMNBazgxaHG7il/TahxeW5b9cYPXl1Idt6c0G4wWgYa2uY898SBC UxPEWK0X+27Hu4DbttF4BWzhmeQpvx1BoKNZaN8FfT7lTFKqloQezX0hl3OwYJUcUG+A j8tA== X-Gm-Message-State: AMCzsaXGfol6ttuNzDslwG4J0tLtJ6zCW+NJ83k2pXbeokMbXP4OfYVT CX78uQN27j/Wxuie8vb2/HBgIeghsSQVzKxIa/8= X-Google-Smtp-Source: ABhQp+R5Cyjb9E+WPayg5EpYjkhEGgSLN5tilwtTpIdHbClllu3D9ZMismliSeDOFQjEfPWd+ZDI7tLCiG9Uy62ZhT0= X-Received: by 10.129.172.75 with SMTP id z11mr2379208ywj.155.1508472006281; Thu, 19 Oct 2017 21:00:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.174.28 with HTTP; Thu, 19 Oct 2017 21:00:05 -0700 (PDT) In-Reply-To: References: From: Cary Coutant Date: Fri, 20 Oct 2017 04:00:00 -0000 Message-ID: Subject: Re: [Patch][Gold] BE8 for ARM To: Umesh Kalappa Cc: "Bharathi Seshadri (bseshadr)" , "Richard Earnshaw (lists)" , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00316.txt.bz2 + unsigned int enable_be8 = parameters->options().be8(); Should be const bool. case Insn_template::THUMB16_TYPE: - elfcpp::Swap<16, big_endian>::writeval(pov, insns[i].data() & 0xffff); + if (enable_be8) elfcpp::Swap<16, false>::writeval(pov, insns[i].data() & 0xffff); + else + elfcpp::Swap<16, big_endian>::writeval(pov, insns[i].data() & 0xffff); break; + if (enable_be8) + elfcpp::Swap<16, false>::writeval( + pov,this->thumb16_special(i)); + else + elfcpp::Swap<16, big_endian>::writeval( + pov,this->thumb16_special(i)); + if (enable_be8) + { + elfcpp::Swap<16, false>::writeval(pov, hi); + elfcpp::Swap<16, false>::writeval(pov + 2, lo); + } + else + { + elfcpp::Swap<16, big_endian>::writeval(pov, hi); + elfcpp::Swap<16, big_endian>::writeval(pov + 2, lo); + } + if (enable_be8) + elfcpp::Swap<32, false>::writeval(pov, insns[i].data()); + else + elfcpp::Swap<32, big_endian>::writeval(pov, insns[i].data()); + break; These are still not indented correctly. Check the tab stop settings in your editor -- it looks like you may have your editor set to tabs every 4 columns. - for (unsigned int i = 1; i < shnum; ++i) + for (static unsigned int i = 1; i < shnum; ++i) What are you trying to do here? I'm pretty sure you don't mean to use a static here. I've fixed these and applied the patch for you. Thanks! -cary