From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93856 invoked by alias); 11 Jun 2015 20:25:37 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 89405 invoked by uid 89); 11 Jun 2015 20:25:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f194.google.com Received: from mail-yk0-f194.google.com (HELO mail-yk0-f194.google.com) (209.85.160.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Jun 2015 20:25:32 +0000 Received: by ykq19 with SMTP id 19so574910ykq.2 for ; Thu, 11 Jun 2015 13:25:30 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.13.193.198 with SMTP id c189mr14158018ywd.122.1434054330207; Thu, 11 Jun 2015 13:25:30 -0700 (PDT) Received: by 10.129.119.9 with HTTP; Thu, 11 Jun 2015 13:25:30 -0700 (PDT) In-Reply-To: References: Date: Thu, 11 Jun 2015 20:25:00 -0000 Message-ID: Subject: Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences) From: Cary Coutant To: Han Shen Cc: binutils , Luis Lozano , Bhaskar Content-Type: multipart/mixed; boundary=001a114e837af0f072051843ca70 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00123.txt.bz2 --001a114e837af0f072051843ca70 Content-Type: text/plain; charset=UTF-8 Content-length: 451 With your last patch, gold won't build at -O0, because the declarations of "static const int STUB_ADDR_ALIGN" need to be made outside the class body. I've committed the attached patch to move these initializations out of the class body. -cary 2015-06-11 Cary Coutant gold/ * aarch64.cc (Erratum_stub::STUB_ADDR_ALIGN): Move initialization outside class body. (Reloc_stub::STUB_ADDR_ALIGN): Likewise. --001a114e837af0f072051843ca70 Content-Type: application/octet-stream; name="stub-align.patch" Content-Disposition: attachment; filename="stub-align.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iasmx4cx0 Content-length: 2501 Rml4IGdvbGQgYnVpbGQgZXJyb3IgYXQgLU8wLgoKSW4gYWFyY2g2NC5jYywg RXJyYXR1bV9zdHViOjpTVFVCX0FERFJfQUxJR04gYW5kIFJlbG9jX3N0dWI6 OlNUVUJfQUREUl9BTElHTgphcmUgZGVjbGFyZWQgYXMgc3RhdGljIGNvbnN0 IGludCwgYW5kIGluaXRpYWxpemVkIGluIHRoZSBjbGFzcyBib2R5LiBUaGVz ZQp2YWx1ZXMgYXJlIHJlZmVyZW5jZWQgZnJvbSBvdXRzaWRlIHRoZSBjbGFz cyBib2R5LCBhbmQgd2l0aCBubyBvcHRpbWl6YXRpb24sCnRoZSByZWZlcmVu Y2VzIGdvIHVucmVzb2x2ZWQuCgoyMDE1LTA2LTExICBDYXJ5IENvdXRhbnQg IDxjY291dGFudEBnbWFpbC5jb20+Cgpnb2xkLwoJKiBhYXJjaDY0LmNjIChF cnJhdHVtX3N0dWI6OlNUVUJfQUREUl9BTElHTik6IE1vdmUgaW5pdGlhbGl6 YXRpb24KCW91dHNpZGUgY2xhc3MgYm9keS4KCShSZWxvY19zdHViOjpTVFVC X0FERFJfQUxJR04pOiBMaWtld2lzZS4KCgpkaWZmIC0tZ2l0IGEvZ29sZC9h YXJjaDY0LmNjIGIvZ29sZC9hYXJjaDY0LmNjCmluZGV4IDEzMGZjYzIuLjhk ZmQ5MzMgMTAwNjQ0Ci0tLSBhL2dvbGQvYWFyY2g2NC5jYworKysgYi9nb2xk L2FhcmNoNjQuY2MKQEAgLTg0MCw3ICs4NDAsNyBAQCBwdWJsaWM6CiAgIHR5 cGVkZWYgdHlwZW5hbWUgZWxmY3BwOjpFbGZfdHlwZXM8c2l6ZT46OkVsZl9B ZGRyIEFBcmNoNjRfYWRkcmVzczsKICAgdHlwZWRlZiB0eXBlbmFtZSBBQXJj aDY0X2luc25fdXRpbGl0aWVzPGJpZ19lbmRpYW4+OjpJbnNudHlwZSBJbnNu dHlwZTsKIAotICBzdGF0aWMgY29uc3QgaW50IFNUVUJfQUREUl9BTElHTiA9 IDQ7CisgIHN0YXRpYyBjb25zdCBpbnQgU1RVQl9BRERSX0FMSUdOOwogCiAg IHN0YXRpYyBjb25zdCBJbnNudHlwZSBpbnZhbGlkX2luc24gPSBzdGF0aWNf Y2FzdDxJbnNudHlwZT4oLTEpOwogCkBAIC05MzAsNiArOTMwLDggQEAgcHJp dmF0ZToKICAgQUFyY2g2NF9hZGRyZXNzIGVycmF0dW1fYWRkcmVzc187CiB9 OyAgLy8gRW5kIG9mICJFcnJhdHVtX3N0dWIiLgogCit0ZW1wbGF0ZTxpbnQg c2l6ZSwgYm9vbCBiaWdfZW5kaWFuPgorY29uc3QgaW50IEVycmF0dW1fc3R1 YjxzaXplLCBiaWdfZW5kaWFuPjo6U1RVQl9BRERSX0FMSUdOID0gNDsKIAog Ly8gQ29tcGFyYXRvciB1c2VkIGluIHNldCBkZWZpbml0aW9uLgogdGVtcGxh dGU8aW50IHNpemUsIGJvb2wgYmlnX2VuZGlhbj4KQEAgLTk4MCw3ICs5ODIs NyBAQCBjbGFzcyBSZWxvY19zdHViIDogcHVibGljIFN0dWJfYmFzZTxzaXpl LCBiaWdfZW5kaWFuPgogICBzdGF0aWMgY29uc3QgaW50IE1JTl9BRFJQX0lN TSA9IC0oMSA8PCAyMCk7CiAKICAgc3RhdGljIGNvbnN0IGludCBCWVRFU19Q RVJfSU5TTiA9IDQ7Ci0gIHN0YXRpYyBjb25zdCBpbnQgU1RVQl9BRERSX0FM SUdOID0gNDsKKyAgc3RhdGljIGNvbnN0IGludCBTVFVCX0FERFJfQUxJR047 CiAKICAgLy8gRGV0ZXJtaW5lIHdoZXRoZXIgdGhlIG9mZnNldCBmaXRzIGlu IHRoZSBqdW1wL2JyYW5jaCBpbnN0cnVjdGlvbi4KICAgc3RhdGljIGJvb2wK QEAgLTExMjYsNiArMTEyOCw4IEBAIGNsYXNzIFJlbG9jX3N0dWIgOiBwdWJs aWMgU3R1Yl9iYXNlPHNpemUsIGJpZ19lbmRpYW4+CiAgIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBpbnQgaW52YWxpZF9pbmRleCA9IHN0YXRpY19jYXN0PHVu c2lnbmVkIGludD4oLTEpOwogfTsgIC8vIEVuZCBvZiBSZWxvY19zdHViCiAK K3RlbXBsYXRlPGludCBzaXplLCBib29sIGJpZ19lbmRpYW4+Citjb25zdCBp bnQgUmVsb2Nfc3R1YjxzaXplLCBiaWdfZW5kaWFuPjo6U1RVQl9BRERSX0FM SUdOID0gNDsKIAogLy8gV3JpdGUgZGF0YSB0byBvdXRwdXQgZmlsZS4KIAo= --001a114e837af0f072051843ca70--