* [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables
@ 2017-04-28 16:13 James Clarke
2017-05-12 22:01 ` Cary Coutant
0 siblings, 1 reply; 4+ messages in thread
From: James Clarke @ 2017-04-28 16:13 UTC (permalink / raw)
To: binutils
Cc: James Clarke, John Paul Adrian Glaubitz, Cary Coutant, Jose E. Marchesi
gold/
PR gold/21444
* gold.cc (Target_sparc::Relocate::relocate_tls): Local
variables are final for position-independent executables. This
has to be consistent with Target_sparc::Scan::local otherwise
they will disagree as to whether local-exec is used.
---
gold/sparc.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gold/sparc.cc b/gold/sparc.cc
index a9cb93adda..54c7c33498 100644
--- a/gold/sparc.cc
+++ b/gold/sparc.cc
@@ -3730,7 +3730,7 @@ Target_sparc<size, big_endian>::Relocate::relocate_tls(
const bool is_final =
(gsym == NULL
- ? !parameters->options().output_is_position_independent()
+ ? !parameters->options().shared()
: gsym->final_value_is_known());
const tls::Tls_optimization optimized_type
= optimize_tls_reloc(is_final, r_type);
--
2.12.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables
2017-04-28 16:13 [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables James Clarke
@ 2017-05-12 22:01 ` Cary Coutant
2017-05-12 22:55 ` James Clarke
0 siblings, 1 reply; 4+ messages in thread
From: Cary Coutant @ 2017-05-12 22:01 UTC (permalink / raw)
To: James Clarke; +Cc: Binutils, John Paul Adrian Glaubitz, Jose E. Marchesi
On Fri, Apr 28, 2017 at 9:12 AM, James Clarke <jrtc27@jrtc27.com> wrote:
> gold/
> PR gold/21444
> * gold.cc (Target_sparc::Relocate::relocate_tls): Local
> variables are final for position-independent executables. This
> has to be consistent with Target_sparc::Scan::local otherwise
> they will disagree as to whether local-exec is used.
This is OK. Thanks!
-cary
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables
2017-05-12 22:01 ` Cary Coutant
@ 2017-05-12 22:55 ` James Clarke
2017-05-13 15:02 ` Cary Coutant
0 siblings, 1 reply; 4+ messages in thread
From: James Clarke @ 2017-05-12 22:55 UTC (permalink / raw)
To: Binutils; +Cc: Cary Coutant, John Paul Adrian Glaubitz, Jose E. Marchesi
On 12 May 2017, at 23:01, Cary Coutant <ccoutant@gmail.com> wrote:
> On Fri, Apr 28, 2017 at 9:12 AM, James Clarke <jrtc27@jrtc27.com> wrote:
>> gold/
>> PR gold/21444
>> * gold.cc (Target_sparc::Relocate::relocate_tls): Local
>> variables are final for position-independent executables. This
>> has to be consistent with Target_sparc::Scan::local otherwise
>> they will disagree as to whether local-exec is used.
>
> This is OK. Thanks!
Could someone please commit this on my behalf?
Thanks,
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables
2017-05-12 22:55 ` James Clarke
@ 2017-05-13 15:02 ` Cary Coutant
0 siblings, 0 replies; 4+ messages in thread
From: Cary Coutant @ 2017-05-13 15:02 UTC (permalink / raw)
To: James Clarke; +Cc: Binutils, John Paul Adrian Glaubitz, Jose E. Marchesi
>>> gold/
>>> PR gold/21444
>>> * gold.cc (Target_sparc::Relocate::relocate_tls): Local
>>> variables are final for position-independent executables. This
>>> has to be consistent with Target_sparc::Scan::local otherwise
>>> they will disagree as to whether local-exec is used.
>>
>> This is OK. Thanks!
>
> Could someone please commit this on my behalf?
Done. Thanks again for the fix!
-cary
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-13 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 16:13 [PATCH] gold: Fix assertion failure relaxing TLS for position-independent executables James Clarke
2017-05-12 22:01 ` Cary Coutant
2017-05-12 22:55 ` James Clarke
2017-05-13 15:02 ` Cary Coutant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).