From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 679BA38582A3 for ; Fri, 5 Aug 2022 20:28:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 679BA38582A3 Received: by mail-pf1-x429.google.com with SMTP id f30so2794463pfq.4 for ; Fri, 05 Aug 2022 13:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L0RcBnKAw1qS0D/mKMd28plVZMyHGpxZr8jfkp+d+3c=; b=LaA4vrPS3N8MZl1dAwHoYHqBk2BRYmj9rYuSaLuV9F/lWpHVuNKfKK12tDVEfYarpp z20YsTyeUCDfwFnK2cTs1DG1OOVfK2zfvqkL68HYZKkQJcljfdTxSBhLJc/JQYrYvEV2 mmb66p9N5qdVWuO97t9o+Mco6CMVu9DUFVxVfcX30t1H88uNBUptjciU3kITqyi6jiLO 9BtnyDCwA0cv5BoVJ4EbhjoDQK2EayYGjtVy6MuJ+SUc93PmOG0MNEIHHqrIGl6Rnsci +4DNxVMh04Nf0ixO6kUerWJ1pV6r/EagYqGve64Ko3Uhn9MJ14nx6K9VGBf3colu++8C PMRA== X-Gm-Message-State: ACgBeo3QWF/pu0LNDbdRCt9w6UBlnkphA+hDNs8jFSz4D31TzBGooRyV PVjc8/g78EiWo33wfy+oZ09Vny5fcOIsaEFYSVFegMkI X-Google-Smtp-Source: AA6agR4wnPLnfhDw81xm0VlfG1gGGrzxaeHlNPm64DZyhm1ioFZ/2RNUumlbGQwyeW1ao/cp1oF1W0Af/XRKrRksBG8= X-Received: by 2002:a63:1a49:0:b0:41b:c0b2:c94d with SMTP id a9-20020a631a49000000b0041bc0b2c94dmr6904497pgm.524.1659731290330; Fri, 05 Aug 2022 13:28:10 -0700 (PDT) MIME-Version: 1.0 References: <88262e9dfc11097d08b552171f1af2e8e026f554.1659683506.git.research_trasio@irq.a4lg.com> In-Reply-To: <88262e9dfc11097d08b552171f1af2e8e026f554.1659683506.git.research_trasio@irq.a4lg.com> From: Cary Coutant Date: Fri, 5 Aug 2022 13:27:58 -0700 Message-ID: Subject: Re: [PATCH] gas: Fix a testcase broken by new ZSTD support To: Tsukasa OI Cc: Jan Beulich , Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 20:28:13 -0000 > The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF > compression type for ZSTD.") added the new ELF compression type but it > accidentally broke a GAS testcase. Since 2 is now a valid compression type > ELFCOMPRESS_ZSTD, the ".word 2" line in section10.s which expects an > **unknown** compression type needs to be changed to another unknown value. Mea culpa! For such a trivial change, it didn't occur to me that it might have a downstream effect, and I ran only the binutils tests. Sorry, I should've run them all. -cary