From: Cary Coutant <ccoutant@gmail.com>
To: Fangrui Song <maskray@google.com>
Cc: Alan Modra <amodra@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] gold: add --compress-debug-sections=zstd [PR 29641]
Date: Thu, 10 Nov 2022 14:00:20 -0800 [thread overview]
Message-ID: <CAJimCsGoHdLzoAYjO+ymYdsPJEK+KLJFuvT6ECF2ZQiTmJP1-A@mail.gmail.com> (raw)
In-Reply-To: <20221001023846.590825-1-maskray@google.com>
> gold/NEWS | 2 ++
> gold/compressed_output.cc | 59 +++++++++++++++++++++++++++++---------
> gold/options.cc | 9 ++++++
> gold/options.h | 4 +--
> gold/testsuite/Makefile.am | 5 ++++
> gold/testsuite/Makefile.in | 27 +++++++++++++++++
> 6 files changed, 90 insertions(+), 16 deletions(-)
@@ -317,7 +348,7 @@ Output_compressed_section::set_final_data_size()
gold_assert(this->data_ == NULL);
this->set_data_size(uncompressed_size);
}
-}
+ }
The indentation here was correct before.
+check_PROGRAMS += flagstest_compress_debug_sections_zstd
+flagstest_compress_debug_sections_zstd: flagstest_debug.o gcctestdir/ld
+ $(CXXLINK) -o $@ $< -Wl,--compress-debug-sections=zstd
+ test -s $@
+
Please condition this new test on HAVE_ZSTD.
Thanks!
-cary
next prev parent reply other threads:[~2022-11-10 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 2:38 Fangrui Song
2022-10-11 3:21 ` ping " Fangrui Song
2022-10-21 5:46 ` PING^2 " Fangrui Song
2022-11-10 21:46 ` Cary Coutant
2022-11-10 21:47 ` Cary Coutant
2022-11-10 22:00 ` Cary Coutant [this message]
2022-11-11 7:40 ` Alan Modra
2022-11-11 8:00 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJimCsGoHdLzoAYjO+ymYdsPJEK+KLJFuvT6ECF2ZQiTmJP1-A@mail.gmail.com \
--to=ccoutant@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).