From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 7C7BF3858D39 for ; Thu, 10 Nov 2022 22:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C7BF3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x433.google.com with SMTP id v28so3214930pfi.12 for ; Thu, 10 Nov 2022 14:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gxP8aXS8WuCuIHUZAtkxs140gV5BnhzM6uLmGhpYyD4=; b=DjyK94c+2DsqLQEkqkXGJ7kZUf6uUMe3AoQLHZj0prFD3R29Evsi4yy0Awx7ZLbWmq O8fpxxHJyxD/bzdP8tkyuEjJUt8Dm7i1VLbdurpUb4an0tL9JdrwvUfB1bpQE8oK4UDU yrw3uG1qRFR2eXhB9a+vFZ5+O6nKJmXZp/aQJrHU5kIiEdwNmw6qvUBlvAmw2zNV/vzT OYhkgJqaTkiBThz0owOQKeQoeNfMBSvLGttcXcvFRYvFTSWLvYvmwsSvphAtVtPvr4Nx ROFJLv5MjtAtjAANrF4fuZAbpOgbhdCuLsIUyuY0a+mtpVOz4dsbtRyIEVqP4B7ZEMU2 fZwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gxP8aXS8WuCuIHUZAtkxs140gV5BnhzM6uLmGhpYyD4=; b=cpSE40NH+pRc2LhTcx37j5rhA2Gr5Qxs/SLWkU+vpGgqQv/sli7fKByNUFdzH//JZG X8auqAnbx2C3Laxx+1OYYTjbdJqpzVr4hrCoGUnMxHcR6TZmh32FkVV+fv6fxyCZEudk NC+fI0ZbUDXgHav5S+UzoCDeJ15axU7XnaVT8tEw3bJx0YNDFkMuH0n7RKCF5wwzCue9 MRV0ukt2ikb1kncWtzZRtHnqUUkc5qLNSaCzdCagYbjND8mvOqJeRVFQaByQPkAzz4jg SP6WUIP+6DMWD85YiI2Uz5x7IZxeiMF5Ds399YM4G4uVio6RVgazZLCnj94QcBwUNSn9 OwJA== X-Gm-Message-State: ACrzQf1JM3Cz8/pGycSZSP9corrI7xKnF+q4kDQNwlckSqYAUWqj+tco zZnKzBi0Gh8tvqSXzvcWeCubRokziw6WadEdM1A= X-Google-Smtp-Source: AMsMyM57ClSvusGjIiZTWFxFb8GfvVRxYpkhxTHY6G4fGAdDFSZ6DzJc3TDALoFfZ1t4k/gSJcrR2sLFWJtSllwTLOQ= X-Received: by 2002:a63:1e59:0:b0:46f:cbcb:761a with SMTP id p25-20020a631e59000000b0046fcbcb761amr3451309pgm.82.1668117631412; Thu, 10 Nov 2022 14:00:31 -0800 (PST) MIME-Version: 1.0 References: <20221001023846.590825-1-maskray@google.com> In-Reply-To: <20221001023846.590825-1-maskray@google.com> From: Cary Coutant Date: Thu, 10 Nov 2022 14:00:20 -0800 Message-ID: Subject: Re: [PATCH] gold: add --compress-debug-sections=zstd [PR 29641] To: Fangrui Song Cc: Alan Modra , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > gold/NEWS | 2 ++ > gold/compressed_output.cc | 59 +++++++++++++++++++++++++++++--------- > gold/options.cc | 9 ++++++ > gold/options.h | 4 +-- > gold/testsuite/Makefile.am | 5 ++++ > gold/testsuite/Makefile.in | 27 +++++++++++++++++ > 6 files changed, 90 insertions(+), 16 deletions(-) @@ -317,7 +348,7 @@ Output_compressed_section::set_final_data_size() gold_assert(this->data_ == NULL); this->set_data_size(uncompressed_size); } -} + } The indentation here was correct before. +check_PROGRAMS += flagstest_compress_debug_sections_zstd +flagstest_compress_debug_sections_zstd: flagstest_debug.o gcctestdir/ld + $(CXXLINK) -o $@ $< -Wl,--compress-debug-sections=zstd + test -s $@ + Please condition this new test on HAVE_ZSTD. Thanks! -cary