From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id D4F123858D38 for ; Thu, 10 Nov 2022 21:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4F123858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x436.google.com with SMTP id y13so3210754pfp.7 for ; Thu, 10 Nov 2022 13:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jFJrHDLZEGqYB1RY9xvhXtHG8vVWg2CQPLVtegrcwUc=; b=AfEiFRQguzpc7rciCMY1WTMNYtqPuyb/H5CzLDAPJunVrpaqBRqfgg/ETlooCbqvKI mSQeU94ZEIQa6BcRSaa+ct/ws2vM5auCgPWB1X3hUmprheivTVw0DO4lNGgNhAYu0CbJ iB7OYxwMGv3KUMVlTMaG/63leGMHSuhKp0aTiJdHIEH4zHCtiWUuPqUpl4Zu+ueYtrJr kqJGFKpsqqdjyr6yRiEYEYNBb03WSnNANO/NDpCpfQ9ZXk2Ks/+MPikaIMOJCgXnWVZ9 bf3rgSUM6FeaiaFP9FTJU3RDIQItoGzuWYSsuWNO5FVEvdORhUffWcFW5g/OV2BgcvKE kfaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jFJrHDLZEGqYB1RY9xvhXtHG8vVWg2CQPLVtegrcwUc=; b=PByNErVn1PNms3xbAoZJlaOlpFWnvyD4ijkuSsKwv4Zi0aRPTJmk25UliZ3uffCNi7 4yTT5NEZ5DlvCeRsH2feyuCdlQbhfB74Ci23uummMJkGJd9YfZIQsDDtXZXGMV6tOVn/ ms3KXWNvIZP9GFrsQbLR0g4mKkRKQYgazkS6hhTNznrgAH2ARJAiEflYk3xGuNgSt75U AAOYWfC03IXscHBr4kZZ12p9QCYOik+SZVXp557gN6e5ODVJ8G5dDZMuB2cmLKipnybC HyWHWuwYDneCFvLVccuNUh3rLPmbKh0Vh5cl5VhIXVOpsV2kw68a54fouTh/s3E2+d1p OVPA== X-Gm-Message-State: ACrzQf0FhUvCcwjYvskUbV7BhZ+5nJtPKiQuvTpbME67FLOidawQxSk/ b3fRSERXxv8mCfroqIsuWkY5ODs3hLcfa8ELCIU= X-Google-Smtp-Source: AMsMyM7EJxEt7Sw3AmyF9tK0kfemVgxioIRE49KTyq0QDH/pPWC6rKZBxCoXZ/A+mEfJ3RGg2IcyMwhlFeEt73Kd/Is= X-Received: by 2002:a63:5a44:0:b0:458:6031:ba1 with SMTP id k4-20020a635a44000000b0045860310ba1mr3427696pgm.524.1668116925752; Thu, 10 Nov 2022 13:48:45 -0800 (PST) MIME-Version: 1.0 References: <20221001014451.532772-1-maskray@google.com> In-Reply-To: <20221001014451.532772-1-maskray@google.com> From: Cary Coutant Date: Thu, 10 Nov 2022 13:48:34 -0800 Message-ID: Subject: Re: [PATCH] gold, dwp: support zstd compressed input debug sections [PR 29641] To: Fangrui Song Cc: Alan Modra , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > elfcpp/elfcpp.h | 1 + > gold/Makefile.am | 10 +- > gold/Makefile.in | 16 +- > gold/aclocal.m4 | 1 + > gold/compressed_output.cc | 44 ++-- > gold/config.in | 3 + > gold/configure | 258 +++++++++++++++++++++++- > gold/configure.ac | 3 +- > gold/testsuite/Makefile.am | 17 +- > gold/testsuite/Makefile.in | 32 ++- > gold/testsuite/gdb_index_test_2_zstd.sh | 24 +++ > 11 files changed, 361 insertions(+), 48 deletions(-) > create mode 100755 gold/testsuite/gdb_index_test_2_zstd.sh In testsuite/Makefile.am: @@ -3120,6 +3120,15 @@ gdb_index_test_2_gabi: gdb_index_test_cdebug_gabi.o gcctestdir/ld $(CXXLINK) -Wl,--gdb-index $< gdb_index_test_2_gabi.stdout: gdb_index_test_2_gabi $(TEST_READELF) --debug-dump=gdb_index $< > $@ +check_SCRIPTS += gdb_index_test_2_zstd.sh +check_DATA += gdb_index_test_2_zstd.stdout +MOSTLYCLEANFILES += gdb_index_test_2_zstd.stdout gdb_index_test_2_zstd +gdb_index_test_cdebug_zstd.o: gdb_index_test.cc + $(CXXCOMPILE) -O0 -g -Wa,--compress-debug-sections=zstd -c -o $@ $< +gdb_index_test_2_zstd: gdb_index_test_cdebug_zstd.o gcctestdir/ld + $(CXXLINK) -Wl,--gdb-index $< +gdb_index_test_2_zstd.stdout: gdb_index_test_2_zstd + $(TEST_READELF) --debug-dump=gdb_index $< > $@ These new tests should be conditioned on HAVE_ZSTD, right? Otherwise, looks good to me. Thanks! -cary