From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24219 invoked by alias); 24 Aug 2012 06:04:24 -0000 Received: (qmail 24206 invoked by uid 22791); 24 Aug 2012 06:04:22 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 06:04:10 +0000 Received: by pbbro12 with SMTP id ro12so2883656pbb.0 for ; Thu, 23 Aug 2012 23:04:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=wZ9lka5MGRGitt7aufx83Dw1JJOd2VznGOsrKyp4Yyo=; b=SK7RqdlggHvmk8j2N757i8GPIZb0Kivvbm5YTKAUgp/RryE7Bz1lPniBJLS4T1JOvf l0Pyqx/sIZIh/0OzR+A4Ka3Wb88EjnssU6GPFLHRNS8Osa8Ve7GDTbmWHJ2dC3OJU8qn 3Doif8is2NqxjTkleWGh4BFLbdFaXBzLWMnWBFDlKZnnpZXcS9Kl4wAhuYpojbgy136F gx4hjT+in8ACJU+5iW6y5trfHkYnAxJ4cp+E2zTDyp9DDqUk2MUUfnrzg+K1wkItyhG5 AbIVqodeDsnfT5HlUTN4cPzTHhoWrZJwoEAGtlioF4hTGOLOufy9ack5sBtYZTcDYtdP s/KA== Received: by 10.66.88.40 with SMTP id bd8mr8409319pab.36.1345788249524; Thu, 23 Aug 2012 23:04:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.88.40 with SMTP id bd8mr8409295pab.36.1345788249322; Thu, 23 Aug 2012 23:04:09 -0700 (PDT) Received: by 10.68.241.169 with HTTP; Thu, 23 Aug 2012 23:04:09 -0700 (PDT) In-Reply-To: References: Date: Fri, 24 Aug 2012 17:41:00 -0000 Message-ID: Subject: Re: [patch] Gold linker patch to provide plugin support for mapping some text sections to an unique ELF segment. From: Ian Lance Taylor To: Sriraman Tallam Cc: Cary Coutant , binutils Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQlWNrpXcUbuBghfL64Xx+QmOE0/vxgBxZ6AVACMAyPnvNrsfBYt3KePhVsVKg/2Ny1qdUBqxuxAr6TkaOhio6U30QoFvQikukZ09v7N40fLxeh/uvYyu06dVSY7DuAQe0x1hwxaMkHP+bNkRdvT5sl4aHIvWNCqLclRHLL0xMO/IcLSfpTfOP4uyWfzfPMTvjK9Ejad X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00442.txt.bz2 On Wed, Aug 22, 2012 at 8:12 PM, Sriraman Tallam wrote: > Hi Ian, > > I have made all the changes and attached the patch. > + flags = this->get_output_section_flags (flags); No space before parenthesis. > + // Identifier for the Segment. ELF Segments dont have names. > + const char* name; > + // Additional Segment flags. s/Segment/segment/ three times. > + void > + set_segment_alignment(uint64_t align) > + { this->segment_alignment_ = align; } > + > + Only one blank line here. > +/* The linker's interface for specifying that a specific set of sections > + must be mapped to a unique segment. ELF segments do not have names > + and the NAME is used as an identifier only. As I understand it, this comment isn't precisely accurate. It's true that ELF segments don't have names, but NAME is used as the name of the newly created output section that is then placed in the unique PT_LOAD segment. Please fix accordingly. This patch is OK with those changes. Thanks. Ian