From: Ian Lance Taylor <iant@google.com>
To: binutils@sourceware.org
Subject: Re: [GOLD] tidy powerpc Glink_sym_ent
Date: Mon, 13 Aug 2012 16:11:00 -0000 [thread overview]
Message-ID: <CAKOQZ8zsmPcQZsUfF9GYXnovAR2jcBg=yWvm5XJh9iG2a2_HSg@mail.gmail.com> (raw)
In-Reply-To: <20120813141126.GB3947@bubble.grove.modra.org>
On Mon, Aug 13, 2012 at 7:11 AM, Alan Modra <amodra@gmail.com> wrote:
>
> * powerpc.cc (Powerpc_relobj::set_got2_shndx): Delete.
> (Powerpc_relobj::do_find_special_sections): Don't use set_got2_shndx.
> (Output_data_glink::add_entry,find_entry): Remove shndx param.
> (class Glink_sym_ent): Rename from struct Glink_sym_ent. Remove
> all references to shndx_. Handle special case for R_PPC_PLTREL24
> here.
> (class Glink_sym_ent_hash): Rename from struct Glink_sym_ent_hash.
> (Output_data_glink::do_write): Retrieve got2_shdnx from object.
> (Target_powerpc::make_plt_entry): Don't special case R_PPC_PLTREL24
> here.
> (Target_powerpc::Scan::global): Nor on make_plt_entry call.
> (Target_powerpc::Relocate::relocate): Nor on glink->find_entry call.
This is OK.
Thanks.
In general, please feel free to commit changes to gold/powerpc.cc
without prior review. I would prefer to review patches to the other
files in gold, though. Of course I'm happy to look at any patch to
powerpc.cc if you aren't sure about it.
Ian
prev parent reply other threads:[~2012-08-13 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 14:24 Alan Modra
2012-08-13 16:11 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8zsmPcQZsUfF9GYXnovAR2jcBg=yWvm5XJh9iG2a2_HSg@mail.gmail.com' \
--to=iant@google.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).