From: YunQiang Su <wzssyqa@gmail.com>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: macro@orcam.me.uk, binutils@sourceware.org
Subject: Re: [PATCH] MIPS: Fix binutils-all tests for r6 default triples
Date: Mon, 28 Aug 2023 11:54:50 +0800 [thread overview]
Message-ID: <CAKcpw6U2fR8vTSsP=f86sWJ-EesQ8wLcKZ_MXwoGiOV7bed2FA@mail.gmail.com> (raw)
In-Reply-To: <20230817035805.551641-1-yunqiang.su@cipunited.com>
YunQiang Su <yunqiang.su@cipunited.com> 于2023年8月17日周四 11:58写道：
>
> MIPS16 is not supported for MIPSr6 as ISA documents; microMIPS
> on MIPSr6 is not supported by binutils yet, and in fact we have
> no plan to support it.
>
> So let's add `-32 -mips1` as options to mips16-extend-noinsn.d and
> mixed-mips16-micromips.d.
@Maciej W. Rozycki Can you have a glance of this +2-2 patch?
It is quite simple.
> ---
> binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d | 1 +
> binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d b/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
> index 41bb49e6ac7..74f537c3213 100644
> --- a/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
> +++ b/binutils/testsuite/binutils-all/mips/mips16-extend-noinsn.d
> @@ -1,4 +1,5 @@
> #PROG: objcopy
> +#as: -32 -mips1
> #objdump: -d --prefix-addresses --show-raw-insn
> #name: MIPS16 unsupported EXTEND and undefined opcode disassembly
>
> diff --git a/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d b/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
> index 4a53dfb8578..d3dc14e97f8 100644
> --- a/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
> +++ b/binutils/testsuite/binutils-all/mips/mixed-mips16-micromips.d
> @@ -1,4 +1,5 @@
> #PROG: objcopy
> +#as: -32 -mips1
> #objdump: -drt
> #name: Mixed MIPS16 and microMIPS disassembly
>
> --
> 2.30.2
>
--
YunQiang Su
prev parent reply other threads:[~2023-08-28 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 3:58 YunQiang Su
2023-08-28 3:54 ` YunQiang Su [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKcpw6U2fR8vTSsP=f86sWJ-EesQ8wLcKZ_MXwoGiOV7bed2FA@mail.gmail.com' \
--to=wzssyqa@gmail.com \
--cc=binutils@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).