From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by sourceware.org (Postfix) with ESMTPS id 9791B3858D28 for ; Wed, 21 Feb 2024 08:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9791B3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9791B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708505323; cv=none; b=s8ySU3WjiY8wEURcHqdoVYuWB9yEyiF3tOGzEOYRS1vSn6pmERrA81ljiRnNBa/PX0x0YwdQUzw+uNaO1gKZJU7r9jbI1gTc133EF4yUPqVTzqMK35xkguaAA0T89FlJ5UuUq/kFcVgaVgjc3kT/NEwEH/M/XuBlUvpukaoo2Bg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708505323; c=relaxed/simple; bh=rY+FmYGXojqkPeqMdMZ7J2N33slks0k3CtjgG1c+EVo=; h=MIME-Version:From:Date:Message-ID:Subject:To; b=PLZ/TKMO14zGV0plWuDCtuMzPPPFumzewx1xE9geAmSm9FOyQkOvrHr7G1PH5/RU28HHgk1CdgXv3imXi+4t9jBugm/iILZc6LnHohOdpbBYYisGPceqER2RBqWI/iZ9l1kDM3KDGpwdV6bDF7vwmeAaWLYicAcV5KWazj7FYPE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3c15dd2a1fdso2045751b6e.2 for ; Wed, 21 Feb 2024 00:48:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708505320; x=1709110120; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HfC4BEQTvXYMT9fS5CCPUp67KBlqeNpmspZ5BNgaFc4=; b=Gn+DXR7GOAKonG2MrwX1SvvmoGKtJfmF4AsDQzVKZgccHD0NbK2Tun2jgmKCqngsp1 ZBAjEtHN3RF8LqyqhNvkvjLBJGjYFK6LOQRASXQbLep2kLLYTNt1PTd8mWDBWFVlr0DT sTx7fD+2HdRFvdCLIoleUX0D3nqPCGiLLA5iLBTDwcJjKH6YP/eacXNCmZfRH0Wiq7ZO Y/NUjJJqb70XhAVTPPjbyXV2rtI+NCPPPhofS+r+ydeXwnVuKlu1O1jj1ZO35H4usj9b zWqiTTju3CIact9O7x1EdX4P7NUhyrbbtGARTSBar3ucuyA3lRiLY55QXXmmNIKhuvyq W72Q== X-Gm-Message-State: AOJu0YxfXHj1twKxa6quSpXbHDwynsn/mYsSn9Y/0dGsTnC72RLJHLOe 04jIF1KrZbWrpm/eW+ncrB7LJ3EYL1fGAARsiRMs5unWiTOnkm5gwvWINaEah8g= X-Google-Smtp-Source: AGHT+IFl/jUY/OeQNx6WF0MnwbUblPpzQeLlzTEgPu2ZDRi8bVRV6eno0WNeVI/Eb7RZHQaMjRgSiw== X-Received: by 2002:a05:6808:7c7:b0:3c0:9d6:c4e8 with SMTP id f7-20020a05680807c700b003c009d6c4e8mr15632994oij.19.1708505320451; Wed, 21 Feb 2024 00:48:40 -0800 (PST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com. [209.85.215.172]) by smtp.gmail.com with ESMTPSA id q13-20020a056a00088d00b006e05c801748sm8231226pfj.199.2024.02.21.00.48.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 00:48:40 -0800 (PST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5e42b4bbfa4so891653a12.1 for ; Wed, 21 Feb 2024 00:48:40 -0800 (PST) X-Received: by 2002:a05:6a20:4891:b0:19e:cba0:2bd5 with SMTP id fo17-20020a056a20489100b0019ecba02bd5mr15903606pzb.27.1708505319980; Wed, 21 Feb 2024 00:48:39 -0800 (PST) MIME-Version: 1.0 References: <20240207173102.2989195-1-syq@gcc.gnu.org> In-Reply-To: <20240207173102.2989195-1-syq@gcc.gnu.org> From: YunQiang Su Date: Wed, 21 Feb 2024 16:48:28 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5] MIPS: Reject branch absolute relocs for PIC for linking To: nickc@redhat.com Cc: binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: YunQiang Su =E4=BA=8E2024=E5=B9=B42=E6=9C=888=E6=97=A5=E5= =91=A8=E5=9B=9B 01:31=E5=86=99=E9=81=93=EF=BC=9A > > The asm code like: > b (8) > will emit absolute relocs like: > R_MIPS_PC16 *ABS* > > If they are included into PIC shared objects or PIE executables, > the branch target will be like 0x12340000, which will make the > programs crash. @Maciej ping. > --- > bfd/elfxx-mips.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c > index 69dd71419ff..9542250dec4 100644 > --- a/bfd/elfxx-mips.c > +++ b/bfd/elfxx-mips.c > @@ -9258,6 +9258,15 @@ _bfd_mips_elf_check_relocs (bfd *abfd, struct bfd_= link_info *info, > (h) ? h->root.root.string : "a local symbol"); > break; > default: > + if (branch_reloc_p (r_type) && r_symndx =3D=3D STN_UNDEF) > + { > + howto =3D MIPS_ELF_RTYPE_TO_HOWTO (abfd, r_type, NEWABI= _P (abfd)); > + info->callbacks->einfo > + /* xgettext:c-format */ > + (_("%X%H: relocation %s against `*ABS*' cannot be use= d" > + " when making a PIC/PIE object\n"), > + abfd, sec, rel->r_offset, howto->name); > + } > break; > } > } > -- > 2.39.2 >