From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id C33D23858D28 for ; Mon, 19 Jun 2023 07:12:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C33D23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1b543f7e53aso17152435ad.1 for ; Mon, 19 Jun 2023 00:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687158747; x=1689750747; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=91KeOUV/MXNU/U0Flv6VOJsFXV4PHhF2BR/O+G9Eqnk=; b=nZBbyCafluBzDbtCYxx11irKEFMYaqnomlDr4MVHNQn9B64PwvBV4Pyh7lcYb8Xq80 IL1Rbu2vfYmVOxNpe02idk+aNENOuiDpuHjh+obpEjYVQ7AhdvtlWCpqXtqx2x65QCqp uHmbpKaxbA/FrShfd8/yYDNewzka8/NcHPku7i8qMrVZPYA7T2Pq84vmWJKmPoj7or+F R/gnb2RwFjho4hb+p3ut8LTw8I/UO3yW0Nq/qpsnrPasqClAacKqtvpO/38fE0Vfpgda U8RGLQTmDCnERbk/irV4NnRd0DxwqhkcSD99sfS4t76Ei6CqxK6hQh8URcJUj7TkwD2A RQJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687158747; x=1689750747; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=91KeOUV/MXNU/U0Flv6VOJsFXV4PHhF2BR/O+G9Eqnk=; b=ACTmiJV6kLrst97rSlp3gyYymAKnXyQnCXsz5cSWSsqpqpYudS191NzBXneW8C2CZM bSu+n1qpUkNKUZ0PipDEa4hJjk3jHfTB5e8YMgwMvefd0YfLHYEkgsvdXDQAXx5vLwDE UCSqw6omDvtnlHdn97iy/cwrY3XTkNlVnlrCMKbytSJaw+63m2P96PG4kdVOzSeeCo9+ sERN4SmmMoRzh5icWuWNcVIKShYpHK/A0G4/tzg8m0P9pU5VNYfNn7I8LxUUWImm4gzA dF5F2v7JDXlEILzSPWcf1gnmnBD3fhyJR7p2uAiVvWaYW9vCw855zseRBAijXXs9SwEe RJTw== X-Gm-Message-State: AC+VfDzC7Y/3Hvzosc+uC+p2qyVHmSSObbwWdPLEMRdaatLICRIyGMmU 5T5TIVLpUKC8blIzIi5OGgg7XSWywGll2/5ShCQ= X-Google-Smtp-Source: ACHHUZ6PajR3c0xa6thgGshCG1CC8a18fCSfXcc/tjjemdgzI31AyC2JyuxbbjmnTNlbhoKTHEn+a4ZBgBkeVOSdnwE= X-Received: by 2002:a17:902:d4ce:b0:1a9:b0a3:f03a with SMTP id o14-20020a170902d4ce00b001a9b0a3f03amr11708239plg.9.1687158746610; Mon, 19 Jun 2023 00:12:26 -0700 (PDT) MIME-Version: 1.0 References: <87zg51m295.fsf@redhat.com> In-Reply-To: From: YunQiang Su Date: Mon, 19 Jun 2023 15:12:15 +0800 Message-ID: Subject: Re: New failures for the mips64el-openbsd target To: "Maciej W. Rozycki" Cc: Nick Clifton , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B46=E6=9C=8816=E6= =97=A5=E5=91=A8=E4=BA=94 21:33=E5=86=99=E9=81=93=EF=BC=9A > > On Fri, 16 Jun 2023, YunQiang Su wrote: > > > > It may well be that one of the YunQiang Su's patches I have reverted > > > brough these back; a regression from his earlier commit(s) anyway. > > > > > > > I run a test with the below commit, because the next commit of it is > > my first commit to binutils. > > > > commit 2e6be59c8de57c32260771ac5307968d18793a0a (HEAD -> xxxxx) > > Author: Nick Clifton > > Date: Thu Jul 25 13:05:27 2019 +0100 > > > > Stop an illegal memory access by readelf when parsing a corrupt > > MIPS binary file. > > > > PR 24837 > > * readelf.c (process_mips_specific): Check for buffer overf= low > > before reading reginfo information. > > > > The test fails do exist with this commit. > > > > So I think that it is a long time problem, and in fact my recent > > commits resolve them. > > Good. Please post fixes then to regressions introduced with any changes > of yours starting from commit 32f1c80375eb ("MIPS: support mips*64 as CPU > and gnuabi64 as ABI") as a separate change (or multiple changes) from any > fixes to pre-existing problems. The more self-contained a change is the > more straightforward to review it is. > I don't think that 2 changes introduced any "regressions". Yes, with these 2 changes, if binutils is configured with - -target=3Dmips64-linux-gnuabi64 or -target=3Dmipsisa64r6-linux-gnu will have some failures. But they are not "regressions", the real problem is that the previous code is wrong at all. Yes, I will fix these failures, that the patches do: [PATCH v4 3/7] MIPS: Fix r6 testsuites [PATCH v4 4/7] MIPS: Fix -gnuabi64 testsuite > It's OK to fix regressions one by one with separate patches, or to only > have an identical change bulk-applied across multiple files in a single > patch. > > Overall changes that live in downstream repositories often have a long > history behind them, which is not necessarily relevant at the upstream > submission time. Consequently they may have to be merged, split, and/or > have bits and pieces moved between changes to make them consistent from > the upstream code's point of view. I've been through it myself across > many projects and I am sure I'm no exception here. > > So please try and avoid submitting unrelated changes bundled together in > a single patch, and of course regression-test each individual change in a > patch set as they are incrementally applied. > > Also please try and separate changes to the MIPS subset of the testsuite= s > from ones to their generic part, as those usually need to be reviewed by = a > general maintainer (unless say you're just about to remove a MIPS XFAIL), > and also need to be verified across non-MIPS targets. > > > > I haven't run any verification on the reverts as I don't think there= is > > > any excuse for violating our policies and committing patches with no = prior > > > approval and/or with objections raised. I think let's wait and see h= ow > > > YunQiang handles it, and if it turns out to be a failure, then I'll h= andle > > > it one way or another (maybe his earlier commits need to be reverted = too). > > > > > > > I will resend my patchset, of course with more code style checks. > > I look forward to that, thank you. > > Maciej --=20 YunQiang Su