From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 32041385B532 for ; Tue, 2 Apr 2024 11:46:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32041385B532 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32041385B532 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712058422; cv=none; b=WxKAGlNf0s4Fow4SC2nz5R3E8PaY7YBF5J75nTss3IdKD7pdiFvY6ax+swNCEEYIgDhBz4lZqasi+KskOwrWRKyMnPJ+SroKPBcEYqNKJ5ntKlKVcT8CN0cpJ2wXqbg4XkHhFGebWvDF85Kv605FE/LpY80AWOlFANTfoW6bs/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712058422; c=relaxed/simple; bh=Onar2rC18hy6NJ0J7DkdiOiFSlzBqifs949HoZg0Dz4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=iJ/GX3au5kR5HCW/2j9ulkRiIMeVquhIhLDIMqBSFHBCrPWdlrazbH8H9pvjXp7P/burp4O4zpg3RXY+O71zpMoUXOrLxCtDy6aqK3g1f8oAjvJL5BazDVLm6pYrlAiwfL5nBpa2BYT+t5YhITLexF293zJFBsy/OdInjnIXLPs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1df01161b39so43427545ad.3 for ; Tue, 02 Apr 2024 04:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712058416; x=1712663216; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9VftUTnK13MbnX5d1zI9bBtwR2xDwtkrX0+7X/UjGXQ=; b=aklcm6srpXPSqwPKz9456EKGK88YZdLwvv5n9uJSljfcUkSRzP2uAFRuWhgCqvEI/Y XB3o3EuA3lzOoLEZgd3tPmiZD1YQWYydJlVbEZNxPOtcxGzsGUaUik15PsP2fsITlr7x wZiPA4YwIj3cnMbKc3LjTI4MBPj+5kOKCID3c/i8JWSw/P1BmgE3KQBNc/oBvLrN9qcK 46XGSUCDPjZVzCgKoPE9Qr74bWvpYd9ZpCHYcGQGeCu4PaHEfwP21CtRV6GX8mDf7itF ZZcV1OSJth8XNH4betWe6JZFcEt+OiXZO5nZtFW/wmSKEI2xdkmPlKBFxMzC8G2wq5PE VOWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712058416; x=1712663216; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9VftUTnK13MbnX5d1zI9bBtwR2xDwtkrX0+7X/UjGXQ=; b=wnwJxk3cD0zk+HNNQhl6XvrWxYc/XmFCrjATLY4DWMXCLClJxMxLZo/OhzVN6IQIEc Y6Hd5Z6ZeesrtOoHCIFS2c3BHA/fJSe0SVZgsaOklBi8wV+8z90AI36tncoW9zm75sEQ 4TA6Ga2d3qUNjg9Z/8vfLbLQi6QfAuP0peEMhzOiQ8poWSJhKTwijpxOd79fYoqLIa/b RBLSnUAqPD6ly3WKDFotSQjHlO0IzO6cHBqTitoPtBqDASpWEJ01fgGsiTLKnBR27SwU s1XGvXOnYkOteR4Db8zdep1ACxiSJYMyeY6EOxY1L9AffhfNmFHHlfTmGyZCcQFbFoyc GBBA== X-Gm-Message-State: AOJu0YxfMlR1XmgEk89/ztl4zOOclJuAs/EBLxQ0GquQsIXHYkQU6WsE kgQ9zwMnW1wfzO1YsAM0R1FmRNO+2aoaCvOvrUfFa9wJaDWhv45ufKOHzebBRYgaV0paYm+mMdP 2VE00H17qHDo+F5GY02/FQGz8b/qUDNuDyTApG/9h X-Google-Smtp-Source: AGHT+IF/KvoW9eBRYGsIgU9z2LIztiOcjJPc9NCXZro3nrLnfaBSmhfCU4imbyNFX0DAJRI67e3+lGxEmlRmPPx/h4c= X-Received: by 2002:a17:902:e5c8:b0:1e0:d631:5563 with SMTP id u8-20020a170902e5c800b001e0d6315563mr16127773plf.66.1712058416178; Tue, 02 Apr 2024 04:46:56 -0700 (PDT) MIME-Version: 1.0 References: <20230622232510.49099-1-david@davidgf.es> <20230622232510.49099-2-david@davidgf.es> In-Reply-To: <20230622232510.49099-2-david@davidgf.es> From: YunQiang Su Date: Tue, 2 Apr 2024 19:46:44 +0800 Message-ID: Subject: Re: [PATCH 2/2] Adding missing MIPS Allegrex instruction To: david@davidgf.es Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: =E4=BA=8E2023=E5=B9=B46=E6=9C=8823=E6=97=A5=E5=91=A8=E4= =BA=94 07:26=E5=86=99=E9=81=93=EF=BC=9A > > From: David Guillen Fandos > > --- > opcodes/mips-opc.c | 2 +- > gas/testsuite/gas/mips/allegrex.s | 1 + > gas/testsuite/gas/mips/allegrex.d | 3 ++- > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/opcodes/mips-opc.c b/opcodes/mips-opc.c > index 39833cd45f..4e0c58d600 100644 > --- a/opcodes/mips-opc.c > +++ b/opcodes/mips-opc.c > @@ -1030,7 +1030,7 @@ const struct mips_opcode mips_builtin_opcodes[] =3D > {"daddu", "d,v,t", 0x0000002d, 0xfc0007ff, WR_1|RD_2= |RD_3, 0, I3, 0, 0 }, > {"daddu", "t,r,I", 0, (int) M_DADDU_I, INSN_MACR= O, 0, I3, 0, 0 }, > {"daddwc", "d,s,t", 0x70000038, 0xfc0007ff, WR_1|RD_2= |RD_3|WR_C0|RD_C0, 0, XLR, 0, 0 }, > -{"dbreak", "", 0x7000003f, 0xffffffff, 0, = 0, N5, 0, 0 }, > +{"dbreak", "", 0x7000003f, 0xffffffff, 0, = 0, N5|AL, 0, 0 }, This is the only instruction changed in this patch. I think that we may use a more detailed commit msg, such as: MIPS/Allegrex: Enable dbreak instruction Or something else. For the code, LGTM. > {"dclo", "d,s", 0x00000053, 0xfc1f07ff, WR_1|RD_2= , 0, I69, 0, 0 }, > {"dclo", "U,s", 0x70000025, 0xfc0007ff, WR_1|RD_2= , 0, I64|N55, 0, I69 }, > {"dclz", "d,s", 0x00000052, 0xfc1f07ff, WR_1|RD_2= , 0, I69, 0, 0 }, > diff --git a/gas/testsuite/gas/mips/allegrex.s b/gas/testsuite/gas/mips/a= llegrex.s > index c36745882d..df05f97ee4 100644 > --- a/gas/testsuite/gas/mips/allegrex.s > +++ b/gas/testsuite/gas/mips/allegrex.s > @@ -40,6 +40,7 @@ > mfdr $v0, $0 > mfdr $v0, $1 > mtdr $v1, $1 > + dbreak > dret > > # Force some (non-delay-slot) zero bytes, to make 'objdump' print ... > diff --git a/gas/testsuite/gas/mips/allegrex.d b/gas/testsuite/gas/mips/a= llegrex.d > index d0f79671de..b535c6dbdc 100644 > --- a/gas/testsuite/gas/mips/allegrex.d > +++ b/gas/testsuite/gas/mips/allegrex.d > @@ -46,5 +46,6 @@ Disassembly of section .text: > 0x00000094 7002003d mfdr \$2,\$0 > 0x00000098 7002083d mfdr \$2,\$1 > 0x0000009c 7083083d mtdr \$3,\$1 > -0x000000a0 7000003e dret > +0x000000a0 7000003f dbreak > +0x000000a4 7000003e dret > \.\.\. > -- > 2.40.1 > --=20 YunQiang Su