From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 55EEA385B537 for ; Tue, 3 Oct 2023 23:02:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55EEA385B537 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c5c91bec75so11520455ad.3 for ; Tue, 03 Oct 2023 16:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696374144; x=1696978944; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bXmCYcopp+OXBmHG4tBVsZiIt8Mc4/dEbvLaZDj8l7E=; b=Lg6D4pVcIMFYPj9K7a+Yl6x6SASDKzPtBZQcbIt3qHdrv5XPVriB4bqR+NYHT6a5H4 tUq6XS5fzAX3QSEncOEUKe4OV4cv9JWQYLZeK2fpoS7UocplykkKWM34DSrKkq9zPWKV RuCwpqD0eqIRHM5XqC5Rq6HYs+JkWZGXWQfSyqbXI0qUSqnAvbDoTugi7mkJN0Fkbi77 9KAxSHddfQmFjC9n5B5r30Ky+9JAxQ4IGjytdfXuzWyumOHcQSLQ1uzdB566UVmH4Lz7 pnEVMa5RMz9jNLF9RSLw9nPi4AoWH3Z2T4WyJcC3lgaleEcHTkhb6g46eMcVdzU3QHAx r/GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696374144; x=1696978944; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bXmCYcopp+OXBmHG4tBVsZiIt8Mc4/dEbvLaZDj8l7E=; b=gl+zYu2fEQDo7ysGqEkD9GWdG4MchmghL8k/W5COmkfUFhxrenxzjZMr7gE5JEJ/bc ScG/HteZE+L+xuiQmdyZ1HeLcdth0Jcftg6F8RBERmJjzsT4wLwqCuSNG2TZXG3+txUq vLmFi0FnjkRiH+WkUFh23tmhUCnHwfLcLD2y8Kg4Gm+m0LneZZRHJ1whYxazWGjwbm0c yFuZdQO2A/DQ1QW7fa498WcsW/RsrCisnnefzzCzMyc18ll9VC6BXECy2hNiaPYkNzNx qGrPMi2nOH0ORpmj24VuvjJEA7HbPPoNKu7C7Sgjov62VklosJaG3gKGsZPjtChjlCur 7Pvg== X-Gm-Message-State: AOJu0Yy7ZTB850uGA+itqZJ3x76A336SlZ7FKmfzgDHo3SSA+1c3gCVO uULZs6N1yXSryOzMeLLUEuh+ZuuiFi8c2P9PAysH+4tK X-Google-Smtp-Source: AGHT+IFS0IivR9dRbpCirQubYMfrL6QrOzcZPBrX08/2llnRf3l4tSKp1IIwuiJl/x4jRH5RhL3AWBuNy4T140ZdkGg= X-Received: by 2002:a17:903:22d0:b0:1c3:62c4:7f12 with SMTP id y16-20020a17090322d000b001c362c47f12mr1144627plg.5.1696374144262; Tue, 03 Oct 2023 16:02:24 -0700 (PDT) MIME-Version: 1.0 References: <20230817034046.438336-1-yunqiang.su@cipunited.com> In-Reply-To: From: YunQiang Su Date: Wed, 4 Oct 2023 07:02:13 +0800 Message-ID: Subject: Re: [PATCH] MIPS: fix readelf -S bintest test for N64 triples To: "Maciej W. Rozycki" Cc: YunQiang Su , binutils@sourceware.org, Nick Clifton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B410=E6=9C=883=E6= =97=A5=E5=91=A8=E4=BA=8C 19:57=E5=86=99=E9=81=93=EF=BC=9A > > On Thu, 17 Aug 2023, YunQiang Su wrote: > > > MIPS N64 has different section layout. Let's add a new file > > readelf.s-64-tmips. > > > > It can fix this test fail on mips64*-linux-gnuabi64 and mips64*-openbsd= . > > I actually had to chase readelf.exp and dive into it so as to find out > whether and why this approach is correct. This could have been mentioned > in the description. > > Also due to how the test is called it wasn't clear to me from the > description itself what test is actually affected. > > > diff --git a/binutils/testsuite/binutils-all/readelf.s-64-tmips b/binut= ils/testsuite/binutils-all/readelf.s-64-tmips > > new file mode 100644 > > index 00000000000..5c19027d0b7 > > --- /dev/null > > +++ b/binutils/testsuite/binutils-all/readelf.s-64-tmips > > @@ -0,0 +1,25 @@ > > +There are .* section headers, starting at offset .*: > > + > > +Section Headers: > > + +\[Nr\] Name +Type +Address +Offset > > + +Size +EntSize +Flags +Link +Info +Align > > + +\[ 0\] +NULL +0000000000000000 +00000000 > > + +0000000000000000 +0000000000000000 +0 +0 +0 > > + +\[ 1\] .text +PROGBITS +0000000000000000 +00000040 > > + +00000000000000.. +0000000000000000 +AX +0 +0 +.* > > + +\[ 2\] .rel.+text +REL. +0+ +0+.* > > + +000000000000001. +000000000000001. +I +. +1 +8 > > + +\[ 3\] .data +PROGBITS +0000000000000000 +000000(48|50) > > + +0000000000000010 +0000000000000000 +WA +0 +0 +.* > > + +\[ 4\] .bss +NOBITS +0000000000000000 +00000060 > > + +0000000000000000 +0000000000000000 +WA +0 +0 +.* > > +# .MIPS.options, .MIPS.abiflags, .pdr, .gnu.attributes here > > +#... > > + +\[ .\] .symtab +SYMTAB +0000000000000000 +0+.* > > + +0+.* +0000000000000018 +10 +10 +8 > > + +\[10\] .strtab +STRTAB +0000000000000000 +0+.* > > + +0+.* +0000000000000000 .* +0 +0 +1 > > + +\[11\] .shstrtab +STRTAB +0000000000000000 +[0-9a-f]+ > > + +00000000000000.. +0000000000000000 .* +0 +0 +.* > > +Key to Flags: > > +#... > > Since the scope for this dump is so narrow there is no need to > wildcard-match output produced. It can be an exact match for easier > detection of unwanted changes in output, just as the original readelf.s > dump used to be. > > Also #... at the end is unusual, #pass can be used to terminate matching > successfully right away rather than wading through the rest of output onl= y > to ignore it. > > I have committed the change with these updates made for you, posted > separately, thank you for your contribution. > Thank you so much. > Maciej --=20 YunQiang Su