From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by sourceware.org (Postfix) with ESMTPS id 98BF93858D37 for ; Wed, 21 Feb 2024 08:51:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98BF93858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 98BF93858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708505470; cv=none; b=vhxL6x+bI+7t2aUu+CqYaZsNRHCpee6Q3UWPEmFV0HuUQstyo9cyQE05703xACLbDG8YTIuPmN2dA80iE26YfdE5J/t9ytQiSPEvnbBBoR48VjYQBk18yggfFTZsJcN8ugQ/ppQR29+trUIMYznt/kHuss6CqCoy2/pPs4JpnTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708505470; c=relaxed/simple; bh=KrVGulWx6AhMHZgsK2C2rEhLDo0KGvRwKBtXiymRSmY=; h=MIME-Version:From:Date:Message-ID:Subject:To; b=ZUfGpOQMVtfTskTA/VPIx8xBrPBc+T6Cxcy+7OX+sxvgclfwKb+UwmfjHsHQmdVVZZ+VuHWKEw40XBzVxYvg3mBGLabYgO650KeMla90XxfbQC+LsPrTcmMXobhyZcH8sFVIchEHbQqu7sL1+9mFG/BXUB7ILM3rtwsPx0anclc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d746ce7d13so43791185ad.0 for ; Wed, 21 Feb 2024 00:51:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708505467; x=1709110267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i/8/O0ke/rEnGOauAhO75Xn44HrGYCy0fmu4FZj78Nc=; b=C9yGPExdmcPikDYyNdV+k7I7SBqJL5GbUtmUbbP52GjJMriVf6EqiQ6U3eEryBoo8Y yGx0IToqHkI06dL24KrJ2EZR9CM04IwVItMgKQacn3m3FF9I4kGPgIUzqF7ccHOxpE3r OUp3To9qRRZXtSh+MMOdkVwyGQq3+sJS601W5gkidynNZfAtfF64bRJ6vAu8b1RkGjYJ pZGunhaTO1B+ZJbLFEjDqRKVcRLS+yugKHu1a5MyoH3AXeBCBxRE7Y0NgENqqgbx9XBa nOexkkhqiMC1ffeKu4jOK7OrOscm4rv5rKZqYtbadAl8lIcKHDIJ3VzePPduoP4IDQXB EOKQ== X-Gm-Message-State: AOJu0YwwLe+NesRU+judlh/HfK+wj5OrHNkjPkdPlx7m+RXCkc3PGJ6C /M6C+iSFA+p4dQAHmGr8J73wA0nUn8XNyC7Q2KsjoUXXGVQVb7u15nUSzaTUlwo= X-Google-Smtp-Source: AGHT+IHgckF0dhR4AcZe8O6iGc7ZOmujaSvFvwgsl+hUvpRUfftynUrsgedvniJajPeM00+cLF2gcQ== X-Received: by 2002:a17:902:f68f:b0:1db:ca53:41d with SMTP id l15-20020a170902f68f00b001dbca53041dmr16082108plg.31.1708505467529; Wed, 21 Feb 2024 00:51:07 -0800 (PST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com. [209.85.210.171]) by smtp.gmail.com with ESMTPSA id v12-20020a170902d08c00b001d9588f0714sm7581960plv.177.2024.02.21.00.51.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 00:51:07 -0800 (PST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e43ee3f6fbso3390265b3a.3 for ; Wed, 21 Feb 2024 00:51:07 -0800 (PST) X-Received: by 2002:a05:6a20:2d2b:b0:19e:985c:c019 with SMTP id g43-20020a056a202d2b00b0019e985cc019mr25383525pzl.47.1708505467150; Wed, 21 Feb 2024 00:51:07 -0800 (PST) MIME-Version: 1.0 References: <20240205101427.2862503-1-syq@gcc.gnu.org> In-Reply-To: <20240205101427.2862503-1-syq@gcc.gnu.org> From: YunQiang Su Date: Wed, 21 Feb 2024 16:50:56 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] MIPS/Gas: Support .L/$ as the mark of local symbol To: nickc@redhat.com Cc: binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: YunQiang Su =E4=BA=8E2024=E5=B9=B42=E6=9C=885=E6=97=A5=E5= =91=A8=E4=B8=80 18:14=E5=86=99=E9=81=93=EF=BC=9A > > In as.texi, there are lines: > A local symbol is any symbol beginning with certain local > label prefixes. By default, the local label prefix is > @samp{.L} for ELF systems or @samp{L} for traditional a.out > systems, but each target may have its own set of local > label prefixes. > > Let's support it for MIPS: > 1) For OldABI, GCC uses "$" to mark local symbols, and > for NewABI, ".L" is used. So let's support both for > OldABI, and ".L" only for NewABI. > 2) Emit an fatal error, if a local symbol is used, while > not defined, just like LLVM does. @Maciej W. Rozycki ping. > --- > gas/config/tc-mips.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c > index 43c12de2c8a..a84b13e1815 100644 > --- a/gas/config/tc-mips.c > +++ b/gas/config/tc-mips.c > @@ -17725,6 +17725,16 @@ pic_need_relax (symbolS *sym) > if (symbol_section_p (sym)) > return true; > > + if (strstr (S_GET_NAME (sym), ".L") =3D=3D S_GET_NAME (sym) > + || ((mips_abi =3D=3D O64_ABI || mips_abi =3D=3D O32_ABI) > + && strstr (S_GET_NAME (sym), "$") =3D=3D S_GET_NAME (sym))) > + { > + if (!S_IS_DEFINED (sym)) > + as_fatal (_("undefined temporary symbol: %s"), > + S_GET_NAME (sym)); > + return true; > + } > + > symsec =3D S_GET_SEGMENT (sym); > > /* This must duplicate the test in adjust_reloc_syms. */ > -- > 2.39.2 >