From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by sourceware.org (Postfix) with ESMTPS id 761103858D20 for ; Wed, 31 May 2023 08:15:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 761103858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-39810ce3e13so3821706b6e.2 for ; Wed, 31 May 2023 01:15:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685520914; x=1688112914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ct4Htn7xwExb3BP1CiJ0DabD8aWAKnpk5QaYm7HzsLw=; b=PFe0Xtsf9wayul/wC8l2nYTyRKsnhSGp+HNRF8zdgTVp7/MaJ9KPNxrogWNH5O3wVk Di5IwySnAUbP9YJb/s2X38ABCIwB1rRTFG5QgsvEFp1XrUlHAmVg/L4Ym9KeS52ZoDBR BgQmK0ZmQS7rYIi+vd40LzqF2xYhq+MynZNe0wA8BUZZDeQF9zcgpyNCYDO5XUJajr1W Gnue86lMNV9I7W5v+TCUAKY8y5DQO5+1ktg/+5ERiQbkgUKPET/JE80r0liqrSHrVa6t MOcRDWZ1LR9cuXt9WJ9ZyY7pNXdj7khmtcE9NjntQMvIgjAB8yI61Vjlaeil7KBDrgAA cWTA== X-Gm-Message-State: AC+VfDzfnKgMuWmIsa3rTjSzF46F1ZnPnT6uSQ1zhHo6XMoS4AzJocpg IXgTjGLR506IR4Ke85WisT02a9nB21vUXYazogc= X-Google-Smtp-Source: ACHHUZ7Libh7kvk93TatiN+sf1osO287Oe2C3qbc//rZAjKdflD3qShtjmazU3JfQXVIX2b43AXIA+8HNGCMIOGjO+U= X-Received: by 2002:aca:705:0:b0:396:cd:829c with SMTP id 5-20020aca0705000000b0039600cd829cmr2929035oih.3.1685520913701; Wed, 31 May 2023 01:15:13 -0700 (PDT) MIME-Version: 1.0 References: <20230425065626.3587754-1-yunqiang.su@cipunited.com> In-Reply-To: From: YunQiang Su Date: Wed, 31 May 2023 16:15:01 +0800 Message-ID: Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32 To: "Maciej W. Rozycki" Cc: YunQiang Su , binutils@sourceware.org, xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: YunQiang Su =E4=BA=8E2023=E5=B9=B45=E6=9C=8816=E6=97=A5=E5= =91=A8=E4=BA=8C 14:32=E5=86=99=E9=81=93=EF=BC=9A > > Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B44=E6=9C=8825= =E6=97=A5=E5=91=A8=E4=BA=8C 18:03=E5=86=99=E9=81=93=EF=BC=9A > > > > On Tue, 25 Apr 2023, YunQiang Su wrote: > > > > > diff --git a/opcodes/micromips-opc.c b/opcodes/micromips-opc.c > > > index 94812a68c82..5a6460d9b8b 100644 > > > --- a/opcodes/micromips-opc.c > > > +++ b/opcodes/micromips-opc.c > > > @@ -148,6 +148,10 @@ decode_micromips_operand (const char *p) > > > case '~': SINT (12, 0); > > > case '@': SINT (10, 16); > > > case '^': HINT (5, 11); > > > + case '*': REG (2, 23, ACC); > > > + case '!': UINT (1, 10); > > > + case '$': UINT (1, 9); > > > + case '&': REG (2, 18, ACC); > > > > > > case '0': SINT (6, 16); > > > case '1': HINT (5, 16); > > > @@ -165,6 +169,7 @@ decode_micromips_operand (const char *p) > > > case 'G': REG (5, 16, COPRO); > > > case 'K': REG (5, 16, HW); > > > case 'H': UINT (3, 11); > > > + case 'O': UINT (3, 4); > > > case 'M': REG (3, 13, CCC); > > > case 'N': REG (3, 18, CCC); > > > case 'R': REG (5, 6, FP); > > > > When adding new operand formats you need to document them in > > include/opcode/mips.h. NB this is not a full review. > > > > Any update? If no objection, I will commit this patchset. > > > Maciej