public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: YunQiang Su <syq@gcc.gnu.org>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: Nick Clifton <nickc@redhat.com>,
	binutils@sourceware.org, macro@orcam.me.uk,  xry111@xry111.site
Subject: Re: [PATCH v6] MIPS: Reject branch absolute relocs for PIC for linking
Date: Thu, 22 Feb 2024 14:29:50 +0800	[thread overview]
Message-ID: <CAKcpw6W0S0JshQamEkx1pJuVzSwSZ9UMb1M3oNsiiHWcZVO77Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.BSF.2.20.16.2402212209112.6914@arjuna.pair.com>

> > +               howto = MIPS_ELF_RTYPE_TO_HOWTO (abfd, r_type, NEWABI_P (abfd));
> > +               info->callbacks->einfo
> > +                 /* xgettext:c-format */
> > +                 (_("%X%H: relocation %s against `*ABS*' cannot be used"
>
> There's no "*ABS*" in the source and IMHO that'd look confusing
> to innocent users.  How about "...against an absolute value"?
> Or "...against an absolute value or absolute symbol"?  Perhaps
> the latter is a bit too wordy, but also more complete.
>

Good idea. I think that we should use "...against an absolute value".
"absolute symbol"  is not included in this code, as it's r_symndx is
not STN_UNDEF.
An example is gas/testsuite/gas/mips/branch-absolute.s.

Thank you,

  reply	other threads:[~2024-02-22  6:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 14:52 YunQiang Su
2024-02-22  3:13 ` Hans-Peter Nilsson
2024-02-22  6:29   ` YunQiang Su [this message]
2024-02-22 13:13     ` Maciej W. Rozycki
2024-02-25 14:08       ` YunQiang Su
2024-03-01 17:23         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKcpw6W0S0JshQamEkx1pJuVzSwSZ9UMb1M3oNsiiHWcZVO77Q@mail.gmail.com \
    --to=syq@gcc.gnu.org \
    --cc=binutils@sourceware.org \
    --cc=hp@bitrange.com \
    --cc=macro@orcam.me.uk \
    --cc=nickc@redhat.com \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).