From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 985FB3858D38 for ; Thu, 17 Aug 2023 04:22:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 985FB3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1bdf4752c3cso21370155ad.2 for ; Wed, 16 Aug 2023 21:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692246156; x=1692850956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VqG0EoSFfnmGuFuSaHq+/59KTvMiR0SlUC+kbN2A+54=; b=k9pmt4LC8TBa1zCcPyZxNMDCKZav56hM18pA1Yvg0QCtsj3oPdA87+nIR14nTCzn29 DnpMdmhyvNhGf8CUrAYlV+jUBsRK7dMlD4OePF81XbFnD+RnJd9UWHAwJezE1SIHjTSp AVc775853KqGQjyjsLosmKsmkYk7qZV9QQBeeASkoReZ3W8qx9CAHka9O6k33exfV0bP TB1HxDL3eU9weT2Jdy4FP9DlMuQGvKiDaxrZz9B4UgW4hd8ITafdFo0RTRCcvV3U666A xLyg1RjBslP7vSgBOIcKfsOudRdsKHfxMg864LFvKu0KSuxmYjaleJaCLzbieu136fBY DY+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692246156; x=1692850956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqG0EoSFfnmGuFuSaHq+/59KTvMiR0SlUC+kbN2A+54=; b=d7fhFga2tWYgLQKwYbVWwEgt+hacqThLgWQKuz5LKeQrFuyzRXNVHpql3fcYJ3TPvE 8BQYOh5AqlESs3QAk/5036XEb+nIbwp5VI8AAbB3neGaosgLjkhSlVjmKQ7T3jBskqQ/ i8CQueM4EULBKwWxNknI/xxqBUekvJszBTr03Cz3K3rAdqTdo1T4YKW7mv5aaj58PLgb Smf8lSsCyHKvail+PIy1P0ziBchXtGmqkdkbZiz51Qu/iah03/5AUwhsGkwxsC7C+wGd bC1G+qDbWusNQVdCFSgud3BIKTjAmbECQPBtZ/nb6aL5WPM4Yvma0co1bDR7OIxEcUCa gBPQ== X-Gm-Message-State: AOJu0YzNgKCdGkA7afxh3ycW0j1PWzjoWiwDVM5jnmxzAJzqGlq4QcOh ZFqgGCGi7o24/GycXXGWqaPg4cGWRs3QUGTKzNK9bI9wIBtQgg== X-Google-Smtp-Source: AGHT+IFqvDndQ251ksP6Ry0U16VmTmx4VujfZ5PBYw1D2rtgwbZW3hfguviwOTgE5vmKNpBm4j3yrM7gQtUvXn2myPs= X-Received: by 2002:a17:902:b7c5:b0:1b2:1b22:196 with SMTP id v5-20020a170902b7c500b001b21b220196mr3425120plz.48.1692246155901; Wed, 16 Aug 2023 21:22:35 -0700 (PDT) MIME-Version: 1.0 References: <20230803203339.822435-1-vladimir.mezentsev@oracle.com> In-Reply-To: <20230803203339.822435-1-vladimir.mezentsev@oracle.com> From: YunQiang Su Date: Thu, 17 Aug 2023 12:22:24 +0800 Message-ID: Subject: Re: [PATCH] gprofng: 30700 tmpdir/gp-collect-app_F test fails To: vladimir.mezentsev@oracle.com Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Vladimir Mezentsev via Binutils =E4=BA=8E2023=E5= =B9=B48=E6=9C=884=E6=97=A5=E5=91=A8=E4=BA=94 04:34=E5=86=99=E9=81=93=EF=BC= =9A > > From: Vladimir Mezentsev > > gprofng/ChangeLog > 2023-08-03 Vladimir Mezentsev > > PR gprofng/30700 > * testsuite/gprofng.display/gp-collect-app_F.exp: Fix -name argum= ent > for sub-experiment filtering. With your patch, It seems that this test still fails. And in fact there are 3 failures for Gprofng on x86_64-linux ( I test it on Debian): testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/= display.exp completed in 7 seconds Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/g= p-archive.exp ... mkdir -p tmpdir/gp-archive % timeout 300 sh -c 'mkdir -p tmpdir/gp-archive' 2>&1 cd tmpdir/gp-archive && cat /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c | sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c && /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng collect app -p on -a off -O exp.er ./a.out % timeout 300 sh -c 'cd tmpdir/gp-archive && cat /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c | sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c && /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng collect app -p on -a off -O exp.er ./a.out' 2>&1 Experiment is not created in tmpdir/gp-archive FAIL: tmpdir/gp-archive testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/= gp-archive.exp completed in 0 seconds Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/g= p-collect-app_F.exp ... mkdir -p tmpdir/gp-collect-app_F % timeout 300 sh -c 'mkdir -p tmpdir/gp-collect-app_F' 2>&1 cd tmpdir/gp-collect-app_F && /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng collect app -p on -a off -F 'off' -O exp.er sh -c 'mkdir t && touch t/x; rm -rf t' % timeout 300 sh -c 'cd tmpdir/gp-collect-app_F && /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng collect app -p on -a off -F 'off' -O exp.er sh -c 'mkdir t && touch t/x; rm -rf t' ' 2>&1 Experiment is not created in tmpdir/gp-collect-app_F FAIL: tmpdir/gp-collect-app_F testcase /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/= gp-collect-app_F.exp completed in 0 seconds Running /home/syq/git-push/binutils-gdb/gprofng/testsuite/gprofng.display/s= etpath_map.exp ... mkdir -p tmpdir/setpath_map/src % timeout 300 sh -c 'mkdir -p tmpdir/setpath_map/src' 2>&1 cd tmpdir/setpath_map && cat /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c | sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c && /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng collect app -p on -a off -O exp.er ./a.out % timeout 300 sh -c 'cd tmpdir/setpath_map && cat /home/syq/git-push/binutils-gdb/gprofng/testsuite/lib/smalltest.c | sed '1 i /* CORRECTSOURCE */' > t.c && gcc -g t.c && /home/syq/git-push/binutils-gdb/x86_64-linux-gnu/gprofng/src/gprofng collect app -p on -a off -O exp.er ./a.out' 2>&1 Experiment is not created in tmpdir/setpath_map FAIL: tmpdir/setpath_map > --- > gprofng/testsuite/gprofng.display/gp-collect-app_F.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp b/gpr= ofng/testsuite/gprofng.display/gp-collect-app_F.exp > index f791b0f7a95..02bcc8e5b49 100644 > --- a/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp > +++ b/gprofng/testsuite/gprofng.display/gp-collect-app_F.exp > @@ -46,11 +46,11 @@ proc run_gp_collect_app { subExpCnt F_opt } { > return -code break > } > > - set output [run_native_host_cmd "find $tdir -name '*x1.er' | wc -l"] > + set output [run_native_host_cmd "find $tdir -name '*_x?.er' | wc -l"] > set subExp [lindex $output 1] > if { $subExp !=3D $subExpCnt } then { > set out [lindex $output 1] > - send_log "Test failed for -F $F_opt. subExp=3D$subExp. Shold be $sub= ExpCnt\n" > + send_log "Test failed for -F $F_opt. subExp=3D$subExp. Should be $su= bExpCnt\n" > fail $tdir > return -code break > } > -- > 2.31.1 > --=20 YunQiang Su