From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 592FD3857343 for ; Thu, 13 Jul 2023 05:40:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 592FD3857343 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-38c35975545so379084b6e.1 for ; Wed, 12 Jul 2023 22:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689226802; x=1691818802; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ij4zGK2uVT3Kw9+lGmPFLYkUTA8oOsQAovcl56VoGhg=; b=swHvXpFV7YZdtd6o7XIIRxXe4yZ4m7iC/KDRMwrJSb6HiCnKJMwIIkkzIZYQsWNYAF AR/DEJ5SZ4OZdzTb2dD7mh+hSahilVa9pB/WYrfvz55A4tiGWjcO+ChTBQgDAMFbk4Rt NFAfa8YLfU1Q+AN3c5hdg5J2hEnZRXA63yKGr5daW4OoAYAgXoSlGDi7IEHoWIY/NvTq hWPVstBXBoC1triWZfiVQT095qpmR3rd/7GdBWTEWvp2NcX8HWBp0YwO/iTWmNche6DO Rms3xKQ2VnUTgSlDJV/agxUMG8vwhZUVKzN36IB4IO/nNkabNkiJWDXb9S29V1CN7qQA 2slA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689226802; x=1691818802; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ij4zGK2uVT3Kw9+lGmPFLYkUTA8oOsQAovcl56VoGhg=; b=mAM+Xz0PmV752iho9ve7fuV3zBGAH4lIs6PHn07GPP9aQD8jztdyGutXe4gxuIiAoE v1OAah+objRGBHiF3aNPxJ12/e/Zo0S7M7q/ASPN/RJenab6/cUZRkMP9isuCs5ueT74 Fl72sN8fmrWd1LBlt92FdyBTrnukaAat2fFsZCU5I3tXg1Do8e8J59rd8ZQzz/ZV0BYL lTLAe6WD8n5hNQo0Ps6dIOShYqQnv8qkN7XjtVTKeCjIqiv1P67ulheRN9MMYgHKeKba bqSwPz6NmQSS701rz0QAbY1svr/c6o6CBj5kTXvs0OFUm/HGRs8seL8rhNqxs3mV7jjT UDPg== X-Gm-Message-State: ABy/qLagPSU6ec3GMx7N5Jbgztw5DTvJa+tkSrEAtq9XVzeByJy5kq7i dihBNbpscK8qkAtE2xI84vtXHLeHlLGjH/DirrqDjcvkPKY= X-Google-Smtp-Source: APBJJlFjj7eyP4cmUY4Vp6VLPqjFHeWqVAsLbQq4cD5W4me+5j5WUWpNXZ2edPBrvA9tNDeenIw69UePa8Et7iwXcUs= X-Received: by 2002:a05:6358:8826:b0:135:6a39:a955 with SMTP id hv38-20020a056358882600b001356a39a955mr949230rwb.6.1689226801912; Wed, 12 Jul 2023 22:40:01 -0700 (PDT) MIME-Version: 1.0 References: <20230703103647.3162351-1-yunqiang.su@cipunited.com> <20230703105034.3163572-1-yunqiang.su@cipunited.com> In-Reply-To: From: YunQiang Su Date: Thu, 13 Jul 2023 13:39:50 +0800 Message-ID: Subject: Re: [PATCH v2] MIPS: Don't move __gnu_lto_slim to .scommon To: YunQiang Su , Nick Clifton Cc: binutils@sourceware.org, macro@orcam.me.uk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: YunQiang Su =E4=BA=8E2023=E5=B9=B47=E6=9C=885=E6=97=A5= =E5=91=A8=E4=B8=89 09:42=E5=86=99=E9=81=93=EF=BC=9A > > YunQiang Su =E4=BA=8E2023=E5=B9=B47=E6=9C=883= =E6=97=A5=E5=91=A8=E4=B8=80 18:51=E5=86=99=E9=81=93=EF=BC=9A > > > > The LTO plugin doesn't expect __gnu_lto_slim is marked as > > COMMOM or moved .scommon section. > > > > @Maciej W. Rozycki This is a tiny patch, and I think that it should be > in 2.41 release. > Any idea? > ping > > Let's skip __gnu_lto_slim when detect symbols to be moved to > > .scommon. > > > > This patch can fix testcase: > > PR ld/15323 (3) > > PR ld/15323 (4) > > for MIPS. > > --- > > bfd/elfxx-mips.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c > > index 71f2dc9d779..63742de009c 100644 > > --- a/bfd/elfxx-mips.c > > +++ b/bfd/elfxx-mips.c > > @@ -7861,6 +7861,10 @@ _bfd_mips_elf_add_symbol_hook (bfd *abfd, struct= bfd_link_info *info, > > switch (sym->st_shndx) > > { > > case SHN_COMMON: > > + /* __gnu_lto_slim shouldn't mark as COMMON and move to .scommon: > > + lto plugin doesn't expect so. */ > > + if (strcmp (*namep, "__gnu_lto_slim") =3D=3D 0) > > + break; > > /* Common symbols less than the GP size are automatically > > treated as SHN_MIPS_SCOMMON symbols. */ > > if (sym->st_size > elf_gp_size (abfd) > > -- > > 2.30.2 > > > > > -- > YunQiang Su --=20 YunQiang Su