From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by sourceware.org (Postfix) with ESMTPS id 702683858C52 for ; Mon, 10 Apr 2023 06:37:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 702683858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2467761d1f4so176646a91.2 for ; Sun, 09 Apr 2023 23:37:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681108651; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0qktEsPOUVDaFLA7+QWWCWBzsjjcckBus2BnKsiyTXA=; b=S6ol2SbdwvOe7IBmdFzc5DrcTFqDU46+FyPj8XoLgP6/hb6sXdrYzYj8cEMAlCBUgC OoMXt31qFv+FjltFxx5fN1DzHWFEwqzvoyuovIggbIz4/ISxEL81Tbu2DD4iPkCneHwO U7wrsrfxw1xS4A0M9EvWXNXnim7SpcxUBwaRPWbcijgDiqEpsncy/cUPwGhyLs+5yEX2 EQ4wNg0ErGAv9XULCKackeIgUHNDPbSEh0ameDCYKGehrwmpGTv/YjyOh1IwM373+b5I F2uZGhfuZzmlVCxdnGHX7NvsEGpiKc2QAVEFwF9LbXl7eiHJeUbrQxqLsrTPr8tTkIHr x1LA== X-Gm-Message-State: AAQBX9fo4+uhXfu9k9glyQgxmp5Ds5ijh9ckBkTKXQUAnZ3IYZhx6S2t YoPB6U57dsU6spOwt46zqUod/ouB1+e8h8a/Q68= X-Google-Smtp-Source: AKy350YI70Ka2NMS65vnwSeQIC9PZUSYIrX7s3IpzIURPvk7TPNiouxtIYCgDMQuLysfyjYu9NfPyhh1GApHLCUQjgI= X-Received: by 2002:a05:6a00:179b:b0:638:d331:f85a with SMTP id s27-20020a056a00179b00b00638d331f85amr583702pfg.0.1681108651026; Sun, 09 Apr 2023 23:37:31 -0700 (PDT) MIME-Version: 1.0 References: <20230323105959.1449936-1-yunqiang.su@cipunited.com> In-Reply-To: <20230323105959.1449936-1-yunqiang.su@cipunited.com> From: YunQiang Su Date: Mon, 10 Apr 2023 14:37:19 +0800 Message-ID: Subject: Re: [PATCH] MIPS: fix loongson3 llsc workaround To: YunQiang Su Cc: binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com, amodra@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ping YunQiang Su =E4=BA=8E2023=E5=B9=B43=E6=9C=8823= =E6=97=A5=E5=91=A8=E5=9B=9B 19:00=E5=86=99=E9=81=93=EF=BC=9A > > -mfix-looongson3-llsc may add sync instructions not needed on some > asm code with lots of debug info. > > PR: 30153 > * gas/config/tc-mips.c(fix_loongson3_llsc): clear logistic. > --- > gas/config/tc-mips.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c > index e911aaa904a..8a970ceada2 100644 > --- a/gas/config/tc-mips.c > +++ b/gas/config/tc-mips.c > @@ -6942,10 +6942,6 @@ fix_loongson3_llsc (struct mips_cl_insn * ip) > unsigned long lookback =3D ARRAY_SIZE (history); > for (i =3D 0; i < lookback; i++) > { > - if (streq (history[i].insn_mo->name, "ll") > - || streq (history[i].insn_mo->name, "lld")) > - break; > - > if (streq (history[i].insn_mo->name, "sc") > || streq (history[i].insn_mo->name, "scd")) > { > @@ -6953,8 +6949,8 @@ fix_loongson3_llsc (struct mips_cl_insn * ip) > > for (j =3D i + 1; j < lookback; j++) > { > - if (streq (history[i].insn_mo->name, "ll") > - || streq (history[i].insn_mo->name, "lld")) > + if (streq (history[j].insn_mo->name, "ll") > + || streq (history[j].insn_mo->name, "lld")) > break; > > if (delayed_branch_p (&history[j])) > @@ -6993,7 +6989,7 @@ fix_loongson3_llsc (struct mips_cl_insn * ip) > for (j =3D i + 1; j < lookback; j++) > { > if (streq (history[j].insn_mo->name, "ll") > - || streq (history[i].insn_mo->name, "lld")) > + || streq (history[j].insn_mo->name, "lld")) > break; > } > > -- > 2.30.2 >