From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id EB22E3858C33 for ; Wed, 19 Jul 2023 17:26:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB22E3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1b8b2886364so43429685ad.0 for ; Wed, 19 Jul 2023 10:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689787588; x=1690392388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JNV6a5li6t7NcTaYxzYjshVMOx4SVIYPjaw/PHtvUuU=; b=RlIm5qRpspbCVDlSsVQiH5J6XZi8gWWVY6doWSzY7X/FHrlRyS4uigCoakxWfw1oJv iZw61963uc1MIbsvfF9LGOqD6w0l687LOIsN8fI1yIFc96mkf9oKgy64C1Bf4lwTAOfs /V7ZDYhDW73b4v2HuEU7bbxjVqt4KoypTPI76WNFkxvTxPpRBviwQhVtLmKJ8u7oMqMi By5M83oRDOeKthtlqDSoyEBVpKv80oJ4jwIBO0xs2LWRMwqxJC1PxneSnVziFEWU+COD IqAjkDKGiuj4XESPtAh++fH8mV6SECd4fNp2sm+ELCKzjq6SA+RJB8U0aWXQORaadAq0 xidQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689787588; x=1690392388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JNV6a5li6t7NcTaYxzYjshVMOx4SVIYPjaw/PHtvUuU=; b=W8mrpa6fAyjpUs22VrJqHaMnYjl/H+xLB4IoZfRf766svAeP7WWxWNEiNpRVGOs8xr loSRXqEXrLc04wopK/qRDtwG3yQfyy5XxOh44b1atyBgBUaqPLSWTgPe3FE0of9/vNyW 0f+ukYaFHau7sc/t1vQxs07MZ0aTVvOf66cMu01oe+XDubMa9zNO6qBEUY+DM3V3Hw+d 6vfaxV72BgQBV/90fCxHhwrbH+/Rht19wGlxKm1g4rlytGYibGFEGGUhAHDYvHf3elrO E6/cElcsC2wIycsWaE2theHwLoZucFCcVHcz3aD1Dz3X43yY7MvIXyEqjo/EvXtpaliF uFHw== X-Gm-Message-State: ABy/qLbUHz0lqmkxjEUHzZo8OtPdWdp2wljPvGtNoyaEwKwZdEJkzpPi 0kwOfQDuMMw3GthBx2gN7ucIwBl69HAImL3MclA8zv7iI+5U+mb2 X-Google-Smtp-Source: APBJJlHNNtivow0TdIqNCOt6lvQD0BwlGiJwOWZjwq/h5MwwnbSCfUyc9bEIzjcFKHgb5+wVust6Lvd/og4Q4XAVtrc= X-Received: by 2002:a17:903:124d:b0:1b8:9cf2:35b0 with SMTP id u13-20020a170903124d00b001b89cf235b0mr3460054plh.41.1689787588579; Wed, 19 Jul 2023 10:26:28 -0700 (PDT) MIME-Version: 1.0 References: <20230703103647.3162351-1-yunqiang.su@cipunited.com> <20230703105034.3163572-1-yunqiang.su@cipunited.com> In-Reply-To: From: YunQiang Su Date: Thu, 20 Jul 2023 01:26:19 +0800 Message-ID: Subject: Re: [PATCH v2] MIPS: Don't move __gnu_lto_slim to .scommon To: "Maciej W. Rozycki" Cc: YunQiang Su , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B47=E6=9C=8819=E6= =97=A5=E5=91=A8=E4=B8=89 22:55=E5=86=99=E9=81=93=EF=BC=9A > > On Wed, 5 Jul 2023, YunQiang Su wrote: > > > > The LTO plugin doesn't expect __gnu_lto_slim is marked as > > > COMMOM or moved .scommon section. > > > > > > > @Maciej W. Rozycki This is a tiny patch, and I think that it should be > > in 2.41 release. > > Any idea? > > What produces this symbol and why is it a common symbol in the first > place if it's not supposed to? > The symbol is produced by GCC LTO, and it has SHN_COMMON, while no SEC_IS_COMMON flag is set. When gcc -r -flto, this symbol is collected into .scommon and marked as SEC_IS_COMMON, which is rejected by linker. I have no idea why gcc lto uses SHN_COMMON, while it is used by other architectures. That's why I block `__gnu_lto_slim` out .scommon and SEC_IS_COMMON flag. See bfd/linker.c (_bfd_generic_link_add_one_symbol): else if (bfd_is_com_section (section)) { row =3D COMMON_ROW; if (!bfd_link_relocatable (info) && name !=3D NULL && name[0] =3D=3D '_' && name[1] =3D=3D '_' && strcmp (name + (name[2] =3D=3D '_'), "__gnu_lto_slim") =3D=3D = 0) _bfd_error_handler (_("%pB: plugin needed to handle lto object"), abfd); } > NB the mail server for your @gmail.com address rejects e-mail coming fro= m > my system. Please sort this out with your ISP. > > Maciej --=20 YunQiang Su