Re: [PATCH v4 5/7] MIPS: Fix some ld testcases with compiler

[YunQiang Su <wzssyqa@gmail.com>]

Alan Modra <amodra@gmail.com> 于2023年6月20日周二 08:00写道：
>
> On Mon, Jun 19, 2023 at 06:43:05PM +0800, YunQiang Su wrote:
> > Alan Modra via Binutils <binutils@sourceware.org> 于2023年6月19日周一 14:44写道：
> > >
> > > Hi YunQiang Su,
> > > I thought I'd take a detailed look at your patch modifying the generic
> > > ELF tests for mips, despite not really being familiar enough with mips
> > > to properly review mips changes.  Most of this review is not about
> > > details of the patch but rather questioning whether you have done the
> > > necessary analysis before xfailing tests.  It is reasonable to xfail a
> > > test if for some reason a problem cannot be fixed, or even if a
> > > problem is too difficult to be fixed.  On the other hand we don't want
> > > a clean testsuite result if there are problems that should be fixed.
> > >
> > > On Fri, Jun 16, 2023 at 02:34:10PM +0800, YunQiang Su wrote:
> > > > 1. config/default.exp:
> > > >       use -mabi=32 not for -gnuabi64;
> > > >       xfail_from_runlist: remove an element and mark it xfail.
> > >
> > > I dislike the use of xfail here.  xfail should only be used after
> > > running a test, to record an expected fail.  Don't use it when a test
> > > is not run.
> > >
> >
> > Maybe, kfail is better?
>
> Perhaps, but we don't use kfail in the binutils testsuite.
>
> > > > 2. ld-elf/indirect.exp: xfail
> > > >       indirect5a, indirect5b, indirect6a, indirect6b,
> > > >       indirect5c, indirect5d, indirect6c, indirect6d.
> > >
> > > Can you explain why is it correct to xfail these for mips?  The first
> > > four pass for me on mips-linux.  Is there a reason why the last four
> > > must make "bar" dynamic on mips?
> > >
> >
> > Do you have a cross compiler installed?
>
> Yes.  I wouldn't be reporting passes if I didn't.
>

Thank you.
How do you build your cross toolchain?
All of my cross toolchain make

> > 2. ld-elf/indirect.exp: xfail
> >       indirect5a, indirect5b, indirect6a, indirect6b,

> > 9. ld-plugin/plugin.exp: xfail
> >       plugin claimfile lost symbol,
> >       plugin claimfile replace symbol,
> >       plugin claimfile replace symbol,
> >       plugin claimfile lost symbol with source,
> >       plugin claimfile replace symbol with source,
> >       plugin claimfile resolve symbol with source,
> >       plugin 2 with source lib,
> >       load plugin 2 with source,
> >       plugin 3 with source lib,
> >       load plugin 3 with source.

fail on mipsel-linux-gnu and mips64el-linux-gnu.

> --
> Alan Modra
> Australia Development Lab, IBM



-- 
YunQiang Su