From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by sourceware.org (Postfix) with ESMTPS id 141123858D1E for ; Tue, 25 Apr 2023 10:20:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 141123858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1a52667955dso60236085ad.1 for ; Tue, 25 Apr 2023 03:20:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682418033; x=1685010033; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aRZ0QwUscZRSCUHq5MGuu5Nt6wEeThpC7HAYhWVhA2Y=; b=H6ZfFw/UOQFn8cnch0tHBQ9XmXc6dgslnK0Hoag547XGOa0jjVRt0DTO1qehvXpsZ6 /Nsga9QhNbD388v1Vn45kxfjmjes3cSW2CBjQw5kRzvEODnJbRtjkoNQShPnIrmyPLQ6 YYz/tfp15pkwjoQLFqqxRD9yzGt5+0ySLrRm6VxHPmQRptFFWzvJCk69UGKi9wzGNddM tqvgPdt/YypecGB3qxhT30POhZIozl1RpI3Bxnsg62f5xjveNmFVzsk9EAxLVj9FH6W6 lpLzVbnm8gNei1V5riXdehczgauH3iiE4oxMphs2HCFuUoWqeZ40LihqaBOW9eRUod26 q65Q== X-Gm-Message-State: AAQBX9e1xlvNdctrty06Aj/fZqoQFH1Sb6e44yVW8u4dl5I5PPeoj9zi Z/dV8cySPF01eYQaC7aWaVuoSsVwMVYcl8THhmdssBArs5e2PjCX X-Google-Smtp-Source: AKy350YNAJOG2pG3mqlNFZdnF+zSp0x7Ftiins+BJc5izaVv8z4Pk7x5hpC0akDxP2KqWki7v7wJGlRG6xetI7WYkKg= X-Received: by 2002:a17:902:dacc:b0:19e:ab29:1ec2 with SMTP id q12-20020a170902dacc00b0019eab291ec2mr23413475plx.65.1682418033045; Tue, 25 Apr 2023 03:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20230425065626.3587754-1-yunqiang.su@cipunited.com> In-Reply-To: From: YunQiang Su Date: Tue, 25 Apr 2023 18:20:21 +0800 Message-ID: Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32 To: "Maciej W. Rozycki" Cc: YunQiang Su , binutils@sourceware.org, xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B44=E6=9C=8825=E6= =97=A5=E5=91=A8=E4=BA=8C 18:03=E5=86=99=E9=81=93=EF=BC=9A > > On Tue, 25 Apr 2023, YunQiang Su wrote: > > > diff --git a/opcodes/micromips-opc.c b/opcodes/micromips-opc.c > > index 94812a68c82..5a6460d9b8b 100644 > > --- a/opcodes/micromips-opc.c > > +++ b/opcodes/micromips-opc.c > > @@ -148,6 +148,10 @@ decode_micromips_operand (const char *p) > > case '~': SINT (12, 0); > > case '@': SINT (10, 16); > > case '^': HINT (5, 11); > > + case '*': REG (2, 23, ACC); > > + case '!': UINT (1, 10); > > + case '$': UINT (1, 9); > > + case '&': REG (2, 18, ACC); > > > > case '0': SINT (6, 16); > > case '1': HINT (5, 16); > > @@ -165,6 +169,7 @@ decode_micromips_operand (const char *p) > > case 'G': REG (5, 16, COPRO); > > case 'K': REG (5, 16, HW); > > case 'H': UINT (3, 11); > > + case 'O': UINT (3, 4); > > case 'M': REG (3, 13, CCC); > > case 'N': REG (3, 18, CCC); > > case 'R': REG (5, 6, FP); > > When adding new operand formats you need to document them in > include/opcode/mips.h. NB this is not a full review. > Thank you. Are these lines OK for it? DSP ASE usage: "*" 2-bit unsigned immediate in rt section for MFTR "&" 2-bit unsigned immediate in rs section for MTTR "!" 1-bit 'u' value in MFTR/MTTR "$" 1-bit 'h' value in MFTR/MTTR "O" 3-bit 'sel' value in MFTR/MTTR I will add this comment in the next revision, with more fixes if any. > Maciej