From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 617623858D28 for ; Thu, 4 May 2023 01:55:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 617623858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-64115eef620so9131041b3a.1 for ; Wed, 03 May 2023 18:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683165346; x=1685757346; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/KdMqNhjS1H215uO6QHaN1ipRixqabWSBgt8X7un/f4=; b=AthA4j45HsLSJoYps0WxpypiQgXe/C5kTzJDMYY9322WEsCxdgzgpVWZyBLAp6Je+y vCE79CaX0/pu7CG45KiDSMCq0hnW/b0xnfWRTJtUWRdBoGw6ym7IqiSicRTs7Fl4GpLi iy0fk5PakQrAJSrACE/11ic7VYRXVYSzdhg+RUPckQgtgZe4TqR5MynZW1kPpGxxXRe6 AZVezef35w1yrbJ8D1TIuIOyead/efYRlsDPUfGxMPc/zPP1vX6IcTP0PdRcLgaXnAlN /2hBdH2LUD3gxCk31IgiZ+eHijO7wP72sndcUZAKS+RGc12+t8RYGFnAw1bhBGV6sC+J xzYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683165346; x=1685757346; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/KdMqNhjS1H215uO6QHaN1ipRixqabWSBgt8X7un/f4=; b=BlbAs0tlocywUxDz73uECq+mb5dXxzsWCrmHw6I9X37Mv3nh98D0B06i3wo8X1VXnx E+ux7+dZRyF9pbBH9TjKZS1SsyAVC7jR6t48lW+xXpvU3xS0rjWV+za2LWG+toaiBLm5 qdn7Hv6I55adHrf5EGoIm9gsEYus1kR28LSDeNlI4hFUu1qjyQy87M4IyUrSzJoEy3vq kGEeH+BgiUzeGmlHaoCeC3vuDTG4miwrdnZA+43x9it/F9fF1p+Ur3iaTX9NmhedWWmy O8lKPh00AHcu4+Txxdp8ZqGyGVw59QouVziJDXtWbyhuRA+BGep1cksiYWX9qQc/VCpG XD8Q== X-Gm-Message-State: AC+VfDwLjtWM+ZcSLNj/IGWp91voCKLzJd6bFzzKdJWz2NUjiIr4s44C TgDp6lijkOZdOCvtOclbgf0yLGIW2hPbqX7yIxE= X-Google-Smtp-Source: ACHHUZ7c2fh8iHA/vMYxcQjkdRZTzG9pKlv35sBmnXbvZ37+klXefhNa4KB3TMeIPt8ztewmcSMXMjXm4vcyLCoIDr4= X-Received: by 2002:a17:902:ecd0:b0:1a5:1842:f7da with SMTP id a16-20020a170902ecd000b001a51842f7damr2305558plh.6.1683165346258; Wed, 03 May 2023 18:55:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: YunQiang Su Date: Thu, 4 May 2023 09:55:34 +0800 Message-ID: Subject: Re: mips64-linux-gnuabi64 testsuite breakage To: "Maciej W. Rozycki" Cc: Alan Modra , binutils@sourceware.org, YunQiang Su , RichardSandifordrichard.sandiford@arm.com, Chenghua Xu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B45=E6=9C=883=E6= =97=A5=E5=91=A8=E4=B8=89 03:33=E5=86=99=E9=81=93=EF=BC=9A > > On Wed, 26 Apr 2023, YunQiang Su wrote: > > > > Since 32f1c80375e "MIPS: support mips*64 as CPU and gnuabi64 as ABI", > > > > I will fix the test suite. > > The reason is that: the previous test suite assumes the default ABI is > > n32 even the triple > > with -gnuabi64. > > I can see extra 3346 regressions across various MIPS targets compared to > a checkout from Jan. Including ones like (parts of log trimmed for > clarity): > > ../as-new --defsym count=3D960 /scratch/vol1/binutils/binutils-mips-test= /binutils-src/gas/testsuite/gas/mips/branch-swap-2.s > gas/testsuite/gas/mips/branch-swap-2.s:1: Fatal error: `micromips' cannot= be used with `mips32r6' > FAIL: MIPS branch swapping (960) > > for `mips-img-elf' which indicates that the default architecture has > changed for GAS for this target. I think this is due to your commit > 9171de358f23 ("MIPS: default output r6 obj if the triple is r6"), which > has this part among others: > > + # If Vendor is IMG, then MIPSr6 is used > + case ${target} in > + mips*64*-img-*) > + mips_cpu=3Dmips64r6 > + ;; > + mips*-img-*) > + mips_cpu=3Dmips32r6 > + ;; > + esac > > Not only this change is wrong (you can't just arbitrarily change a > configuration that has been in the wild for ~8.5 years as it'll break > things for people who rely on the established semantics), but it hasn't > been properly verified either, as a change is supposed not to cause > regressions in the testsuite. > > Please revert the part quoted and fix the regressions. Thank you. Reverted. And I am working on fix the tesutsuite for `-gnuabi64` and `mipsisaXXr6`. > > Maciej --=20 YunQiang Su