From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 1B0933858C53 for ; Tue, 9 May 2023 03:15:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B0933858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-64115e652eeso39411068b3a.0 for ; Mon, 08 May 2023 20:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683602140; x=1686194140; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+Bn+qgDu1zuo08ySpK2+bbrOxcEkbPAm+D0ksVDZM48=; b=MxIs6fyz9hAQ0DrUPlFnSIY4EtZhhHZGc1Fh90kHqXmHzAqtRh4TXuSVHbMcGQ9yDv j1/4fHJAbdXKtERnGh2teyf4FxAhZENVgiWWU0QQzjAkBeyOyEP6+6f7TbPRLlRYUzjA Re931TUi59FZ9ByMur6vGEBrF/j+VTEGAVt0gK8Pb4bgjM9A4Sgd4gEKXbxS8+L4WvE7 1+qGGZFx4SMMW4DwQKd3mAMe+NFeBWRLxZMVXpSksfdEEtglm+iyV3FWxJ8HMsCZjQ0v 2RbAbSnv4qRR0Myi+MVuZ4ExsPTsfePqu7DjbmkpkyrVLJj5bnC/cxSPxslX+/TW78da /CPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683602140; x=1686194140; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Bn+qgDu1zuo08ySpK2+bbrOxcEkbPAm+D0ksVDZM48=; b=AwEOdAnTPTBYQswVLYdWt/JB+3I6WgbqbFpASbHtEDJsh1WrHFkVR20oQXJ202Xn2q lItbyn4/mchpQh3mlhH9W2QMlEfp6U1apMa5qhpT8LYriL3sERpu08y+VVgcAXOx6fB9 uKGVkKx07+ljn9cEBBFiMpCF5XwVygefxYlDqFjDoshah65jynAGfJBw5pW5baBNwary qj5VRz+oEtgb1jtInIACpod8uhi2fK2Ig3h/hGghsyzMaIOzSl2l9/d3iRoShbmTbXk0 YMn8w70pGRmEPLKoerG7LB3oY4qSRY7aGdtffSTKzjHlqMSNpmXq1TBvSQimj46zUrXK SJrQ== X-Gm-Message-State: AC+VfDzAc4LL/znVMyVNBDb7An28DWUBJb9MlPLttBWa903COqOKtjR1 aVAZUnoRTzP/elQs02hzLvMYHqsvabMOL4oIvdc= X-Google-Smtp-Source: ACHHUZ5kRjP7FMkBXqNhsXGLpOwREkwJ38etZOdDvpiXye6SBw//5uFHJ8FOe5bad7tahNTYnXJPGogQWU/k8MMnp0Y= X-Received: by 2002:a17:902:f804:b0:1a6:d9a6:a9b4 with SMTP id ix4-20020a170902f80400b001a6d9a6a9b4mr13067300plb.3.1683602139723; Mon, 08 May 2023 20:15:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: YunQiang Su Date: Tue, 9 May 2023 11:15:28 +0800 Message-ID: Subject: Re: mips64-linux-gnuabi64 testsuite breakage To: "Maciej W. Rozycki" Cc: Alan Modra , binutils@sourceware.org, YunQiang Su , RichardSandifordrichard.sandiford@arm.com, Chenghua Xu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Maciej W. Rozycki =E4=BA=8E2023=E5=B9=B45=E6=9C=888=E6= =97=A5=E5=91=A8=E4=B8=80 01:46=E5=86=99=E9=81=93=EF=BC=9A > > On Thu, 4 May 2023, YunQiang Su wrote: > > > > + # If Vendor is IMG, then MIPSr6 is used > > > + case ${target} in > > > + mips*64*-img-*) > > > + mips_cpu=3Dmips64r6 > > > + ;; > > > + mips*-img-*) > > > + mips_cpu=3Dmips32r6 > > > + ;; > > > + esac > > > > > > Not only this change is wrong (you can't just arbitrarily change a > > > configuration that has been in the wild for ~8.5 years as it'll break > > > things for people who rely on the established semantics), but it hasn= 't > > > been properly verified either, as a change is supposed not to cause > > > regressions in the testsuite. > > > > > > Please revert the part quoted and fix the regressions. Thank you. > > > > Reverted. > > Thank you. > > FAOD if you think a triplet that implicitly defaults to R6 is useful, No, I don't think that it is useful at all. It is so uglyyyyyyy. In fact, we should use the correct cpu name in triple, just like mipsisa32r6 etc. > then feel free to submit a change for say `mips*-cipunited-*' to do so (o= r > maybe `mips*-cip-*' if you want to keep it short and the company policy > allows using such a short name), as this would be a configuration that ha= d > no previous mention/semantics in our tree and therefore I would have no > concerns about it. > No, I won't. I submit the patch about `img`, is due to that, this vendor va= lue did/does/being used. IMG/MIPS/Wave/MIPS does provide the toolchain with img as its vendor name, and the default arch is R6. https://codescape.mips.com/components/toolchain/2021.09-01/downloads.html > Overall I'd suggest the `--with-arch=3D' approach previously discussed a= nd > already implemented for MIPS targets in GCC and also some other targets i= n > binutils. It is more generic, although it may complicate testing, so it > may have to be deployed with care. > > > And I am working on fix the tesutsuite for `-gnuabi64` and `mipsisaXXr6= `. > > I look forward to your fixes. > > Maciej --=20 YunQiang Su