From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111452 invoked by alias); 12 Feb 2020 09:48:42 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 111235 invoked by uid 89); 12 Feb 2020 09:48:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.222.68, H*RU:209.85.222.68 X-HELO: mail-ua1-f68.google.com Received: from mail-ua1-f68.google.com (HELO mail-ua1-f68.google.com) (209.85.222.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 09:48:04 +0000 Received: by mail-ua1-f68.google.com with SMTP id w15so632623uap.0 for ; Wed, 12 Feb 2020 01:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dJa/edhg8ynCvPS80ORGKBeZKBV2HjdqN5eDjibgGbU=; b=YD+Y/x234UtF6OPrPAiRCZ3KHo2BV0Gd1ph3FiuyApK9rYfK1XCcfdV9+BuHOgWPaP ILi6Zze0Y0PoIIcpQrB0wov7vhwPySczwWOsglObTUziJ1fQTCX7soenL44num66poZb 9NATG+eG8XLPCZ1aPqauOveuEpjuZJ4bRxk64bpuCRk58J6ptQXSwWq6N/a8cKVHXh1d 1MVtCjXfx2438ihENulDVMQ1iNLxWbNklYLkiQbrZLJCPtnKrYw5MMFIKx/qOEAdIvjC i2ywlmTiLRLggqUXVhEU3vZ7v/neIfG71IJR/0G3aZEkwlAKAExgAlh/qIheRH6mQ8hQ Fahw== MIME-Version: 1.0 References: <158133346517.10770.13178331135147729297.scripted-patch-series@arm.com> <59ab928b-5311-e7c0-d9a1-16f76029b190@redhat.com> <44d89776-f198-654c-f9e3-bf422f0aa540@arm.com> In-Reply-To: <44d89776-f198-654c-f9e3-bf422f0aa540@arm.com> From: Christophe Lyon Date: Wed, 12 Feb 2020 09:48:00 -0000 Message-ID: Subject: Re: [Patch 0/2] [binutils][arm] Armv8-M Custom Datapath Extension. To: Matthew Malcomson Cc: binutils Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00206.txt.bz2 On Tue, 11 Feb 2020 at 11:51, Matthew Malcomson wrote: > > On 10/02/2020 21:50, Christophe Lyon wrote: > > On Mon, 10 Feb 2020 at 16:11, Nick Clifton wrote: > >> > >> Hi Matthew, > >> > >>> The patch is in two parts: > >>> Part 1 enables the scalar instructions, which are predicated on *eith= er* > >>> Armv8-m with the floating point extension *or* Armv8.1-m with the MVE > >>> extension. > >>> > >>> Part 2 enables the vector instructions which are dependent on Armv8.1= -m with > >>> MVE. > >>> > >>> Part 1 was worked on by both me and Stam Markianos-Wright. > >>> > >>> The patch series has been successfully regression tested on arm-none-= eabi and > >>> arm-wince-pe. > >>> > >>> Ok for master? > >> > >> Yes - please apply. > >> > > > > Hi, > > > > One of these two patches causes a build failure for gas. I'm seeing: > > ../../gas/config/tc-arm.c: In function =E2=80=98vcx_handle_register_arg= uments=E2=80=99: > > ../../gas/config/tc-arm.c:21985:3: error: =E2=80=98for=E2=80=99 loop in= itial > > declarations are only allowed in C99 mode > > for (unsigned i =3D 0; i < num_registers; i++) > > ^ > > ../../gas/config/tc-arm.c:21985:3: note: use option -std=3Dc99 or > > -std=3Dgnu99 to compile your code > > make[4]: *** [config/tc-arm.o] Error 1 > > > > Can you fix it? > > Thanks > > > > Christophe > > Wow! > I'm really sorry about that. > > I've committed the fix as obvious, but I'd like to double check what > went wrong here to ensure I avoid it in the future. > > My best guess for the problem is that I compile with gcc 5 which has a > default standard of gnu11, while you're testing with an earlier gcc > which has a default standard of gnu89. > > Does that fit? (i.e. are you using an older gcc?) > Yes, that CI loop is running under Ubuntu Trusty, which has gcc-4.8. I'm not sure what's the oldest GCC version supported by binutils though. Thanks Christophe > I will use `-std=3Dgnu89` from now on. > > Regards, and apologies again: > MM > > > > >> Cheers > >> Nick > >> > >> >