From: Paul Hua <paul.hua.gm@gmail.com>
To: Faraz Shahbazker <fshahbazker@wavecomp.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH 2/2] [MIPS] Add i6500 CPU and fix i6400 default ASEs
Date: Sat, 13 Apr 2019 02:06:00 -0000 [thread overview]
Message-ID: <CAKjxQHmC6L6H3NX2_pk6oEu_TcROsap0Y4aG1oc7mB5OoRbK-A@mail.gmail.com> (raw)
In-Reply-To: <30aea320-d05d-be7e-9824-713fa8e04d4e@wavecomp.com>
Hi:
Which commit is your patch based on?
I based on 35add35e85c21f02e3e5808273cb77b24069b0aa, output is :
$ patch -p1 < patch/11.patch
patching file gas/config/tc-mips.c
Hunk #5 succeeded at 4136 with fuzz 1.
Hunk #8 FAILED at 16564.
Hunk #9 FAILED at 16578.
2 out of 10 hunks FAILED -- saving rejects to file
gas/config/tc-mips.c.rej
patching file gas/testsuite/gas/mips/elf_mach_p6600.d
patching file gas/testsuite/gas/mips/mips.exp
$ cat gas/config/tc-mips.c.rej
--- gas/config/tc-mips.c
+++ gas/config/tc-mips.c
@@ -16564,6 +16569,7 @@ parse_code_option (char * name)
mips_opts.arch = p->cpu;
mips_opts.isa = p->isa;
isa_set = TRUE;
+ mips_opts.init_ase = p->ase;
}
}
else if (strncmp (name, "mips", 4) == 0)
@@ -16578,6 +16584,7 @@ parse_code_option (char * name)
mips_opts.arch = p->cpu;
mips_opts.isa = p->isa;
isa_set = TRUE;
+ mips_opts.init_ase = p->ase;
}
}
else
Can you try the same commit ?
ps: My configure option is : ../configure --prefix=/opt/binutils
--target=mips64el-linux-gnu, then make ; make check.
On Fri, Apr 12, 2019 at 10:09 AM Faraz Shahbazker
<fshahbazker@wavecomp.com> wrote:
>
> Hi Paul
>
> On 04/11/2019 06:14 PM, Paul Hua wrote:
> >>> FAIL: ELF i6500 markings
> >> Did you perhaps miss [PATCH 1/2] [MIPS] Apply ASE information for the selected processor?
> > I apply both patches, but refused, I changed by hand, maybe I miss
> > something, please let your patch base new repo and resend it.
>
> I rebased and regenerated both the patches but the output of
> format-patch was identical to what I had posted earlier, except for the
> time-stamp. I don't see the point in re-posting them unless we can
> figure out the problem.
>
> Could this be a charset/encoding issue? It seems
> us-ascii/quoted-printable is the closest thing to plain-text that my
> mail server allows me to transmit.
>
> Regards,
> Faraz
next prev parent reply other threads:[~2019-04-13 2:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 20:40 [PATCH 1/2] [MIPS] Apply ASE information for the selected processor Faraz Shahbazker
2019-04-09 20:40 ` [PATCH 2/2] [MIPS] Add i6500 CPU and fix i6400 default ASEs Faraz Shahbazker
2019-04-11 2:44 ` Paul Hua
2019-04-11 16:52 ` Faraz Shahbazker
2019-04-12 1:14 ` Paul Hua
2019-04-12 2:09 ` Faraz Shahbazker
2019-04-13 2:06 ` Paul Hua [this message]
2019-04-13 4:55 ` Faraz Shahbazker
2019-04-13 8:35 ` Paul Hua
2019-04-13 8:32 ` [PATCH 1/2] [MIPS] Apply ASE information for the selected processor Paul Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKjxQHmC6L6H3NX2_pk6oEu_TcROsap0Y4aG1oc7mB5OoRbK-A@mail.gmail.com \
--to=paul.hua.gm@gmail.com \
--cc=binutils@sourceware.org \
--cc=fshahbazker@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).