From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82727 invoked by alias); 13 Apr 2019 02:06:52 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 82710 invoked by uid 89); 13 Apr 2019 02:06:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=sk:mips64e, 16578 X-HELO: mail-it1-f193.google.com Received: from mail-it1-f193.google.com (HELO mail-it1-f193.google.com) (209.85.166.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Apr 2019 02:06:50 +0000 Received: by mail-it1-f193.google.com with SMTP id w15so18881856itc.0 for ; Fri, 12 Apr 2019 19:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z9UItgk9q/U2XGkzahcVYgQlCwYQSEDuty2OU/rh1f4=; b=XGxv+oxNQeHhhIlVbDBjFwvsgrDt2emIF3ROX8hMEf8YXAeM/Pe6Okb5JZ+c8sKIms 3oWg5kYfzYZeufsLvFgWN5Xlh+88rfvHVlPi95RiUtlXv84yuhP4ykzbkPNtTsAqSrM3 qrw0zWQzvTZxBKHzaHX2C/MVzNnqejllSf/jcrGYkWah6rUpmEnwl+GvsgEMNL0wPa+j 6qShd6JzPnkhupuPX1nh2UCdC6d6JUJPAlOh/fM+BsP7NDNPiw4kdV77CzFwysDxNnka Vv0LeRbiVpcdZys9dU5cTG0Gj6z5xU46pWdj5zknaPQN+fp1DCu7AH7CSNCnFdEH5zjo PWVw== MIME-Version: 1.0 References: <20190409204029.98001-1-fshahbazker@wavecomp.com> <20190409204029.98001-2-fshahbazker@wavecomp.com> <30aea320-d05d-be7e-9824-713fa8e04d4e@wavecomp.com> In-Reply-To: <30aea320-d05d-be7e-9824-713fa8e04d4e@wavecomp.com> From: Paul Hua Date: Sat, 13 Apr 2019 02:06:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] [MIPS] Add i6500 CPU and fix i6400 default ASEs To: Faraz Shahbazker Cc: "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-04/txt/msg00154.txt.bz2 Hi: Which commit is your patch based on? I based on 35add35e85c21f02e3e5808273cb77b24069b0aa, output is : $ patch -p1 < patch/11.patch patching file gas/config/tc-mips.c Hunk #5 succeeded at 4136 with fuzz 1. Hunk #8 FAILED at 16564. Hunk #9 FAILED at 16578. 2 out of 10 hunks FAILED -- saving rejects to file gas/config/tc-mips.c.rej patching file gas/testsuite/gas/mips/elf_mach_p6600.d patching file gas/testsuite/gas/mips/mips.exp $ cat gas/config/tc-mips.c.rej --- gas/config/tc-mips.c +++ gas/config/tc-mips.c @@ -16564,6 +16569,7 @@ parse_code_option (char * name) mips_opts.arch = p->cpu; mips_opts.isa = p->isa; isa_set = TRUE; + mips_opts.init_ase = p->ase; } } else if (strncmp (name, "mips", 4) == 0) @@ -16578,6 +16584,7 @@ parse_code_option (char * name) mips_opts.arch = p->cpu; mips_opts.isa = p->isa; isa_set = TRUE; + mips_opts.init_ase = p->ase; } } else Can you try the same commit ? ps: My configure option is : ../configure --prefix=/opt/binutils --target=mips64el-linux-gnu, then make ; make check. On Fri, Apr 12, 2019 at 10:09 AM Faraz Shahbazker wrote: > > Hi Paul > > On 04/11/2019 06:14 PM, Paul Hua wrote: > >>> FAIL: ELF i6500 markings > >> Did you perhaps miss [PATCH 1/2] [MIPS] Apply ASE information for the selected processor? > > I apply both patches, but refused, I changed by hand, maybe I miss > > something, please let your patch base new repo and resend it. > > I rebased and regenerated both the patches but the output of > format-patch was identical to what I had posted earlier, except for the > time-stamp. I don't see the point in re-posting them unless we can > figure out the problem. > > Could this be a charset/encoding issue? It seems > us-ascii/quoted-printable is the closest thing to plain-text that my > mail server allows me to transmit. > > Regards, > Faraz