From: Paul Hua <paul.hua.gm@gmail.com>
To: Faraz Shahbazker <fshahbazker@wavecomp.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH 1/2] [MIPS] Apply ASE information for the selected processor
Date: Sat, 13 Apr 2019 08:32:00 -0000 [thread overview]
Message-ID: <CAKjxQHmiPc9iA6H5ezRVu5tRDErMZZtE0d3oafCGzVN86m9MoA@mail.gmail.com> (raw)
In-Reply-To: <20190409204029.98001-1-fshahbazker@wavecomp.com>
Hi, Faraz,
Just small comments.
> /* Set up the current options. These may change throughout assembly. */
> mips_opts = file_mips_opts;
> @@ -15189,6 +15193,7 @@ mips_after_parse_args (void)
>
> file_mips_opts.arch = arch_info->cpu;
> file_mips_opts.isa = arch_info->isa;
> + file_mips_opts.init_ase = arch_info->ase;
>
> /* Set up initial mips_opts state. */
> mips_opts = file_mips_opts;
> @@ -16559,6 +16564,7 @@ parse_code_option (char * name)
> mips_opts.arch = p->cpu;
> mips_opts.isa = p->isa;
> isa_set = TRUE;
> + mips_opts.init_ase = p->ase;
> }
> }
Mentions this in changelog.
> else if (strncmp (name, "mips", 4) == 0)
> @@ -16573,6 +16579,7 @@ parse_code_option (char * name)
> mips_opts.arch = p->cpu;
> mips_opts.isa = p->isa;
> isa_set = TRUE;
> + mips_opts.init_ase = p->ase;
> }
> }
> else
same as above.
> @@ -16646,6 +16653,7 @@ s_mipsset (int x ATTRIBUTE_UNUSED)
> {
> mips_opts.isa = file_mips_opts.isa;
> mips_opts.arch = file_mips_opts.arch;
> + mips_opts.init_ase = file_mips_opts.init_ase;
> mips_opts.gp = file_mips_opts.gp;
> mips_opts.fp = file_mips_opts.fp;
> }
Same.
After added those in changelog, apply to reop.
prev parent reply other threads:[~2019-04-13 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 20:40 Faraz Shahbazker
2019-04-09 20:40 ` [PATCH 2/2] [MIPS] Add i6500 CPU and fix i6400 default ASEs Faraz Shahbazker
2019-04-11 2:44 ` Paul Hua
2019-04-11 16:52 ` Faraz Shahbazker
2019-04-12 1:14 ` Paul Hua
2019-04-12 2:09 ` Faraz Shahbazker
2019-04-13 2:06 ` Paul Hua
2019-04-13 4:55 ` Faraz Shahbazker
2019-04-13 8:35 ` Paul Hua
2019-04-13 8:32 ` Paul Hua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKjxQHmiPc9iA6H5ezRVu5tRDErMZZtE0d3oafCGzVN86m9MoA@mail.gmail.com \
--to=paul.hua.gm@gmail.com \
--cc=binutils@sourceware.org \
--cc=fshahbazker@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).