From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33213 invoked by alias); 31 Mar 2016 13:38:34 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 33199 invoked by uid 89); 31 Mar 2016 13:38:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=(unknown), Instructions X-HELO: mail-yw0-f194.google.com Received: from mail-yw0-f194.google.com (HELO mail-yw0-f194.google.com) (209.85.161.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 31 Mar 2016 13:38:21 +0000 Received: by mail-yw0-f194.google.com with SMTP id f6so11429107ywa.1 for ; Thu, 31 Mar 2016 06:38:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=1v55PGZNK8optNO3pZb53PytFyqOhJzaHxvLYIDAiPw=; b=V/xj1ivScE5xvV5aZzxpis6DQScew9q/sPL0HLjXztblLwApS1UNKHbJRrEGg54j6z CcPSg7OZSzswdnzVDxNYwbDAXzesOr0+IfvqmYVmpMGbcuL1lOeeM+0BXeN0/w843h7E Bl9TXHMneCixpnXSsLkTC8goZkzBHZIPZw0VlnywmdE07x8o8f7iDlNHqBZ/E3slA9Cz bdGtZ+jWPzUexEGbFrudGwIvfQNn9pZqXYRYAXohV4ff9SdMuplpxpIMbzUBeWCO3zxu tt1uxTbgXRnqGVIvMY0y/qZGcmYjzZvmal9KVVt2ZL+zVGaDXtm9uWcc/MqiBEPoA4vQ G46w== X-Gm-Message-State: AD7BkJJs3dgP5jc+AYVflV/HUH4KBIrS8tYIC98lwXf7CuyrX0KdFZ+9XBQIPCuQho/YmG2OS+29NPNqao2CTg== MIME-Version: 1.0 X-Received: by 10.37.96.197 with SMTP id u188mr7306226ybb.16.1459431499195; Thu, 31 Mar 2016 06:38:19 -0700 (PDT) Received: by 10.37.20.214 with HTTP; Thu, 31 Mar 2016 06:38:19 -0700 (PDT) In-Reply-To: <1459358269-10771-1-git-send-email-andrew.burgess@embecosm.com> References: <1459358269-10771-1-git-send-email-andrew.burgess@embecosm.com> Date: Thu, 31 Mar 2016 13:38:00 -0000 Message-ID: Subject: Re: [PUSHED/OBV] opcodes/arc: Comment and whitespace fixes in opcode table From: Claudiu Zissulescu To: Andrew Burgess Cc: Binutils Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00460.txt.bz2 Ok by me. //Claudiu On Wed, Mar 30, 2016 at 7:17 PM, Andrew Burgess wrote: > Add a new comment, and clean up some whitespace issues in the > instruction table. > > opcode/ChangeLog: > > * arc-nps400-tbl.h: Add a header comment, and fix some whitespace > issues. No functional changes. > --- > opcodes/ChangeLog | 5 +++++ > opcodes/arc-nps400-tbl.h | 14 ++++++++------ > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/opcodes/arc-nps400-tbl.h b/opcodes/arc-nps400-tbl.h > index 4b715f9..493c5b6 100644 > --- a/opcodes/arc-nps400-tbl.h > +++ b/opcodes/arc-nps400-tbl.h > @@ -1,11 +1,13 @@ > +/**** Bit Manipulation Instructions ****/ > + > /* movl<.cl> */ > -{ "movh", 0x48080000, 0xf81f0000, ARC_OPCODE_NPS400 , BITOP, NONE, { NPS_R_DST, NPS_R_SRC1, NPS_UIMM16 }, { 0 }}, > -{ "movh", 0x48180000, 0xf81f0000, ARC_OPCODE_NPS400 , BITOP, NONE, { NPS_R_DST, NPS_UIMM16 }, { C_NPS_CL }}, > +{ "movh", 0x48080000, 0xf81f0000, ARC_OPCODE_NPS400, BITOP, NONE, { NPS_R_DST, NPS_R_SRC1, NPS_UIMM16 }, { 0 }}, > +{ "movh", 0x48180000, 0xf81f0000, ARC_OPCODE_NPS400, BITOP, NONE, { NPS_R_DST, NPS_UIMM16 }, { C_NPS_CL }}, > > /* movl<.cl> */ > -{ "movl", 0x48090000, 0xf81f0000, ARC_OPCODE_NPS400 , BITOP, NONE, { NPS_R_DST, NPS_R_SRC1, NPS_UIMM16 }, { 0 }}, > -{ "movl", 0x48190000, 0xf81f0000, ARC_OPCODE_NPS400 , BITOP, NONE, { NPS_R_DST, NPS_UIMM16 }, { C_NPS_CL }}, > +{ "movl", 0x48090000, 0xf81f0000, ARC_OPCODE_NPS400, BITOP, NONE, { NPS_R_DST, NPS_R_SRC1, NPS_UIMM16 }, { 0 }}, > +{ "movl", 0x48190000, 0xf81f0000, ARC_OPCODE_NPS400, BITOP, NONE, { NPS_R_DST, NPS_UIMM16 }, { C_NPS_CL }}, > > /* movb<.f><.cl> */ > -{ "movb", 0x48010000, 0xf80f8000, ARC_OPCODE_NPS400 , BITOP, NONE, { NPS_R_DST_3B, NPS_R_SRC1_3B, NPS_R_SRC2_3B, NPS_BITOP_DST_POS, NPS_BITOP_SRC_POS, NPS_BITOP_SIZE }, { C_NPS_F }}, > -{ "movb", 0x48018000, 0xf80f8000, ARC_OPCODE_NPS400 , BITOP, NONE, { NPS_R_DST_3B, NPS_R_SRC2_3B, NPS_BITOP_DST_POS, NPS_BITOP_SRC_POS, NPS_BITOP_SIZE }, { C_NPS_F, C_NPS_CL }}, > +{ "movb", 0x48010000, 0xf80f8000, ARC_OPCODE_NPS400, BITOP, NONE, { NPS_R_DST_3B, NPS_R_SRC1_3B, NPS_R_SRC2_3B, NPS_BITOP_DST_POS, NPS_BITOP_SRC_POS, NPS_BITOP_SIZE }, { C_NPS_F }}, > +{ "movb", 0x48018000, 0xf80f8000, ARC_OPCODE_NPS400, BITOP, NONE, { NPS_R_DST_3B, NPS_R_SRC2_3B, NPS_BITOP_DST_POS, NPS_BITOP_SRC_POS, NPS_BITOP_SIZE }, { C_NPS_F, C_NPS_CL }}, > -- > 2.6.4 >