Re: [PATCH v1] Microblaze: Widen mask used in opcodes/microblaze-dis.c

Re: [PATCH v1] Microblaze: Widen mask used in opcodes/microblaze-dis.c

[Gopi Kumar Bulusu]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

> From: Michael Eager <eager@eagercon.com>
> To: binutils@sourceware.org
> Date: Sat, 4 Jan 2025 14:47:43 -0800
> Subject: Re: [PATCH v1] Microblaze: Widen mask used in
> opcodes/microblaze-dis.c
> On 12/31/24 9:26 PM, Gopi Kumar Bulusu wrote:
>


> Hi Gopi --
>
> Do you have write access to the Binutils repo?
>
> If you do, this patch is OK to check in.  Please add a comment
> in the git log.
>
> If you don't, I'll apply this when I have an opportunity.
>

Hello Mike,

I don't have write access.

Appreciate your help.

dhanyavadam
gopi

Re: [PATCH v1] Microblaze: Widen mask used in opcodes/microblaze-dis.c

[Michael Eager]

Gopi --

I'm out of the office until Jan 16.  I'll apply the patch when I return.

I presume that the incorrect address calcluation only happened on 64-bit 
hosts.

On 1/5/25 11:29 PM, Gopi Kumar Bulusu wrote:
> 
>     From: Michael Eager <eager@eagercon.com <mailto:eager@eagercon.com>>
>     To: binutils@sourceware.org <mailto:binutils@sourceware.org>
>     Date: Sat, 4 Jan 2025 14:47:43 -0800
>     Subject: Re: [PATCH v1] Microblaze: Widen mask used in opcodes/
>     microblaze-dis.c
>     On 12/31/24 9:26 PM, Gopi Kumar Bulusu wrote:
> 
>     Hi Gopi --
> 
>     Do you have write access to the Binutils repo?
> 
>     If you do, this patch is OK to check in.  Please add a comment
>     in the git log.
> 
>     If you don't, I'll apply this when I have an opportunity.
> 
> 
> Hello Mike,
> 
> I don't have write access.
> 
> Appreciate your help.
> dhanyavadam
> gopi
> 

-- 
Michael Eager

Re: [PATCH v1] Microblaze: Widen mask used in opcodes/microblaze-dis.c

[Gopi Kumar Bulusu]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

OK.

The incorrect address calculation happens on 64-bit hosts as 0xffff0000
remains a positive value.

I have not checked 32-bit hosts, but surely sign extension should work as
expected there.

gopi

On Mon, Jan 6, 2025 at 7:35 PM Michael Eager <eager@eagercon.com> wrote:

> Gopi --
>
> I'm out of the office until Jan 16.  I'll apply the patch when I return.
>
> I presume that the incorrect address calcluation only happened on 64-bit
> hosts.
>
> On 1/5/25 11:29 PM, Gopi Kumar Bulusu wrote:
> >
> >     From: Michael Eager <eager@eagercon.com <mailto:eager@eagercon.com>>
> >     To: binutils@sourceware.org <mailto:binutils@sourceware.org>
> >     Date: Sat, 4 Jan 2025 14:47:43 -0800
> >     Subject: Re: [PATCH v1] Microblaze: Widen mask used in opcodes/
> >     microblaze-dis.c
> >     On 12/31/24 9:26 PM, Gopi Kumar Bulusu wrote:
> >
> >     Hi Gopi --
> >
> >     Do you have write access to the Binutils repo?
> >
> >     If you do, this patch is OK to check in.  Please add a comment
> >     in the git log.
> >
> >     If you don't, I'll apply this when I have an opportunity.
> >
> >
> > Hello Mike,
> >
> > I don't have write access.
> >
> > Appreciate your help.
> > dhanyavadam
> > gopi
> >
>
> --
> Michael Eager
>
>

Re: [PATCH v1] [ping] Microblaze: Widen mask used in opcodes/microblaze-dis.c

[Gopi Kumar Bulusu]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Tue, Jan 7, 2025, 10:11 AM Gopi Kumar Bulusu <gopi@sankhya.com> wrote:

>
> OK.
>
> The incorrect address calculation happens on 64-bit hosts as 0xffff0000
> remains a positive value.
>
> I have not checked 32-bit hosts, but surely sign extension should work as
> expected there.
>
> gopi
>
> On Mon, Jan 6, 2025 at 7:35 PM Michael Eager <eager@eagercon.com> wrote:
>
>> Gopi --
>>
>> I'm out of the office until Jan 16.  I'll apply the patch when I return.
>>
>> I presume that the incorrect address calcluation only happened on 64-bit
>> hosts.
>>
>> On 1/5/25 11:29 PM, Gopi Kumar Bulusu wrote:
>> >
>> >     From: Michael Eager <eager@eagercon.com <mailto:eager@eagercon.com
>> >>
>> >     To: binutils@sourceware.org <mailto:binutils@sourceware.org>
>> >     Date: Sat, 4 Jan 2025 14:47:43 -0800
>> >     Subject: Re: [PATCH v1] Microblaze: Widen mask used in opcodes/
>> >     microblaze-dis.c
>> >     On 12/31/24 9:26 PM, Gopi Kumar Bulusu wrote:
>> >
>> >     Hi Gopi --
>> >
>> >     Do you have write access to the Binutils repo?
>> >
>> >     If you do, this patch is OK to check in.  Please add a comment
>> >     in the git log.
>> >
>> >     If you don't, I'll apply this when I have an opportunity.
>> >
>> >
>> > Hello Mike,
>> >
>> > I don't have write access.
>> >
>> > Appreciate your help.
>> > dhanyavadam
>> > gopi
>> >
>>
>> --
>> Michael Eager
>>
>>