* [PATCH] Update testsuite configurations for mips-mti-elf
@ 2013-11-11 12:09 Matthew Fortune
2013-11-26 8:54 ` Eric Christopher
2013-11-27 11:44 ` Richard Sandiford
0 siblings, 2 replies; 4+ messages in thread
From: Matthew Fortune @ 2013-11-11 12:09 UTC (permalink / raw)
To: binutils; +Cc: echristo
Update testsuite configurations to treat mips-mti-elf in the same way as
mips-sde-elf. The primary difference between these triplets is in the
default architecture, all other aspects are the same.
This change resolves some spurious test failures for mips16 and enables
previously omitted ld tests when using the mips-mti-elf triplet.
I do not have write access so will require someone to commit this for me
(or allow me to have commit access if that is possible).
binutils/testsuite/ChangeLog:
2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
* binutils-all/objcopy.exp: Consider mips-mti-elf the same as mips-sde-elf
* binutils-all/readelf.exp: Likewise
gas/testsuite/ChangeLog:
2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
* gas/mips/mips.exp: Consider mips-mti-elf the same as mips-sde-elf
ld/testsuite/ChangeLog:
2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
* ld-mips-elf/mips-elf.exp: Consider mips-mti-elf the same as mips-sde-elf
---
binutils/testsuite/binutils-all/objcopy.exp | 3 ++-
binutils/testsuite/binutils-all/readelf.exp | 1 +
gas/testsuite/gas/mips/mips.exp | 4 +++-
ld/testsuite/ld-mips-elf/mips-elf.exp | 6 ++++--
4 files changed, 10 insertions(+), 4 deletions(-)
From d789db742564fdd1a8430660fe5431a94dff8b62 Mon Sep 17 00:00:00 2001
From: mfortune <matthew.fortune@imgtec.com>
Date: Mon, 11 Nov 2013 11:45:39 +0000
Subject: [PATCH] Update testsuite configurations for mips-mti-elf
Update testsuite configurations to treat mips-mti-elf in the same way as
mips-sde-elf. The primary difference between these triplets is in the
default architecture, all other aspects are the same.
binutils/testsuite/ChangeLog:
2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
* binutils-all/objcopy.exp: Consider mips-mti-elf the same as mips-sde-elf
* binutils-all/objcopy.exp: Likewise
gas/testsuite/ChangeLog:
2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
* gas/mips/mips.exp: Consider mips-mti-elf the same as mips-sde-elf
ld/testsuite/ChangeLog:
2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
* ld-mips-elf/mips-elf.exp: Consider mips-mti-elf the same as mips-sde-elf
---
binutils/testsuite/binutils-all/objcopy.exp | 3 ++-
binutils/testsuite/binutils-all/readelf.exp | 1 +
gas/testsuite/gas/mips/mips.exp | 4 +++-
ld/testsuite/ld-mips-elf/mips-elf.exp | 6 ++++--
4 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index 4dfb73c..dca962d 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -988,7 +988,8 @@ if [is_elf_format] {
# targ_defvec=bfd_elf32_nbigmips_vec or
# targ_defvec=bfd_elf32_nlittlemips_vec in config.bfd. When syncing,
# don't forget that earlier case-matches trump later ones.
- if { ![istarget "mips*-sde-elf*"] && ![istarget "mips64*-*-openbsd*"] } {
+ if { ![istarget "mips*-sde-elf*"] && ![istarget "mips*-mti-elf*"]
+ && ![istarget "mips64*-*-openbsd*"] } {
setup_xfail "mips*-*-irix5*" "mips*-*-irix6*" "mips*-*-elf*" \
"mips*-*-rtems*" "mips*-*-windiss" "mips*-*-none" \
"mips*-*-openbsd*" "mips*-*-chorus*"
diff --git a/binutils/testsuite/binutils-all/readelf.exp b/binutils/testsuite/binutils-all/readelf.exp
index db56a86..9a3e6bd 100644
--- a/binutils/testsuite/binutils-all/readelf.exp
+++ b/binutils/testsuite/binutils-all/readelf.exp
@@ -102,6 +102,7 @@ proc readelf_test { options binary_file regexp_file xfails } {
if [istarget "mips*-*-*"] then {
if { [istarget "mips*-*-*linux*"]
|| [istarget "mips*-sde-elf*"]
+ || [istarget "mips*-mti-elf*"]
|| [istarget "mips*-*freebsd*"] } then {
set target_machine tmips
} else {
diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index d632c4f..f962135 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -466,10 +466,12 @@ if { [istarget mips*-*-vxworks*] } {
run_dump_test "vxworks1-xgot-el"
} elseif { [istarget mips*-*-*] } {
set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*]]
- set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]]
+ set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
+ || [istarget mips*-sde-elf*] || [istarget mips*-mti-elf*]]
if { [istarget "mips*-*-*linux*"]
|| [istarget "mips*-sde-elf*"]
+ || [istarget "mips*-mti-elf*"]
|| [istarget "mips*-*-*bsd*"] } then {
set tmips "t"
} else {
diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp b/ld/testsuite/ld-mips-elf/mips-elf.exp
index a66a289..a9d16ec 100644
--- a/ld/testsuite/ld-mips-elf/mips-elf.exp
+++ b/ld/testsuite/ld-mips-elf/mips-elf.exp
@@ -55,7 +55,8 @@ if {![istarget mips*-*-*] || ![is_elf_format]} {
set has_newabi [expr [istarget *-*-irix6*] \
|| [istarget mips*-*-linux*] \
- || [istarget mips*-sde-elf*]]
+ || [istarget mips*-sde-elf*] \
+ || [istarget mips*-mti-elf*]]
set linux_gnu [expr [istarget mips*-*-linux*]]
set embedded_elf [expr [istarget mips*-*-elf]]
@@ -78,7 +79,8 @@ if { [istarget *-*-irix6*] } {
set abi_asflags(o32) "-32 -EB"
set abi_ldflags(o32) -melf32btsmip_fbsd
}
-if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*] } {
+if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]
+ || [istarget mips*-mti-elf*] } {
set abi_ldflags(n32) -melf32btsmipn32
set abi_ldflags(n64) -melf64btsmip
} elseif { [istarget mips64*-*freebsd*] } {
--
1.7.1
diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index 4dfb73c..dca962d 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -988,7 +988,8 @@ if [is_elf_format] {
# targ_defvec=bfd_elf32_nbigmips_vec or
# targ_defvec=bfd_elf32_nlittlemips_vec in config.bfd. When syncing,
# don't forget that earlier case-matches trump later ones.
- if { ![istarget "mips*-sde-elf*"] && ![istarget "mips64*-*-openbsd*"] } {
+ if { ![istarget "mips*-sde-elf*"] && ![istarget "mips*-mti-elf*"]
+ && ![istarget "mips64*-*-openbsd*"] } {
setup_xfail "mips*-*-irix5*" "mips*-*-irix6*" "mips*-*-elf*" \
"mips*-*-rtems*" "mips*-*-windiss" "mips*-*-none" \
"mips*-*-openbsd*" "mips*-*-chorus*"
diff --git a/binutils/testsuite/binutils-all/readelf.exp b/binutils/testsuite/binutils-all/readelf.exp
index db56a86..9a3e6bd 100644
--- a/binutils/testsuite/binutils-all/readelf.exp
+++ b/binutils/testsuite/binutils-all/readelf.exp
@@ -102,6 +102,7 @@ proc readelf_test { options binary_file regexp_file xfails } {
if [istarget "mips*-*-*"] then {
if { [istarget "mips*-*-*linux*"]
|| [istarget "mips*-sde-elf*"]
+ || [istarget "mips*-mti-elf*"]
|| [istarget "mips*-*freebsd*"] } then {
set target_machine tmips
} else {
diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index d632c4f..f962135 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -466,10 +466,12 @@ if { [istarget mips*-*-vxworks*] } {
run_dump_test "vxworks1-xgot-el"
} elseif { [istarget mips*-*-*] } {
set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*]]
- set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]]
+ set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
+ || [istarget mips*-sde-elf*] || [istarget mips*-mti-elf*]]
if { [istarget "mips*-*-*linux*"]
|| [istarget "mips*-sde-elf*"]
+ || [istarget "mips*-mti-elf*"]
|| [istarget "mips*-*-*bsd*"] } then {
set tmips "t"
} else {
diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp b/ld/testsuite/ld-mips-elf/mips-elf.exp
index a66a289..a9d16ec 100644
--- a/ld/testsuite/ld-mips-elf/mips-elf.exp
+++ b/ld/testsuite/ld-mips-elf/mips-elf.exp
@@ -55,7 +55,8 @@ if {![istarget mips*-*-*] || ![is_elf_format]} {
set has_newabi [expr [istarget *-*-irix6*] \
|| [istarget mips*-*-linux*] \
- || [istarget mips*-sde-elf*]]
+ || [istarget mips*-sde-elf*] \
+ || [istarget mips*-mti-elf*]]
set linux_gnu [expr [istarget mips*-*-linux*]]
set embedded_elf [expr [istarget mips*-*-elf]]
@@ -78,7 +79,8 @@ if { [istarget *-*-irix6*] } {
set abi_asflags(o32) "-32 -EB"
set abi_ldflags(o32) -melf32btsmip_fbsd
}
-if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*] } {
+if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]
+ || [istarget mips*-mti-elf*] } {
set abi_ldflags(n32) -melf32btsmipn32
set abi_ldflags(n64) -melf64btsmip
} elseif { [istarget mips64*-*freebsd*] } {
--
1.7.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Update testsuite configurations for mips-mti-elf
2013-11-11 12:09 [PATCH] Update testsuite configurations for mips-mti-elf Matthew Fortune
@ 2013-11-26 8:54 ` Eric Christopher
2013-11-26 8:54 ` Matthew Fortune
2013-11-27 11:44 ` Richard Sandiford
1 sibling, 1 reply; 4+ messages in thread
From: Eric Christopher @ 2013-11-26 8:54 UTC (permalink / raw)
To: Matthew Fortune; +Cc: binutils
FWIW this seems like a totally mechanical change and is likely just
fine. I haven't had time to apply and test it myself.
-eric
On Mon, Nov 11, 2013 at 4:09 AM, Matthew Fortune
<Matthew.Fortune@imgtec.com> wrote:
> Update testsuite configurations to treat mips-mti-elf in the same way as
> mips-sde-elf. The primary difference between these triplets is in the
> default architecture, all other aspects are the same.
>
> This change resolves some spurious test failures for mips16 and enables
> previously omitted ld tests when using the mips-mti-elf triplet.
>
> I do not have write access so will require someone to commit this for me
> (or allow me to have commit access if that is possible).
>
> binutils/testsuite/ChangeLog:
>
> 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> * binutils-all/objcopy.exp: Consider mips-mti-elf the same as mips-sde-elf
> * binutils-all/readelf.exp: Likewise
>
> gas/testsuite/ChangeLog:
>
> 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> * gas/mips/mips.exp: Consider mips-mti-elf the same as mips-sde-elf
>
> ld/testsuite/ChangeLog:
>
> 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> * ld-mips-elf/mips-elf.exp: Consider mips-mti-elf the same as mips-sde-elf
> ---
> binutils/testsuite/binutils-all/objcopy.exp | 3 ++-
> binutils/testsuite/binutils-all/readelf.exp | 1 +
> gas/testsuite/gas/mips/mips.exp | 4 +++-
> ld/testsuite/ld-mips-elf/mips-elf.exp | 6 ++++--
> 4 files changed, 10 insertions(+), 4 deletions(-)
>
> From d789db742564fdd1a8430660fe5431a94dff8b62 Mon Sep 17 00:00:00 2001
> From: mfortune <matthew.fortune@imgtec.com>
> Date: Mon, 11 Nov 2013 11:45:39 +0000
> Subject: [PATCH] Update testsuite configurations for mips-mti-elf
>
> Update testsuite configurations to treat mips-mti-elf in the same way as
> mips-sde-elf. The primary difference between these triplets is in the
> default architecture, all other aspects are the same.
>
> binutils/testsuite/ChangeLog:
>
> 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> * binutils-all/objcopy.exp: Consider mips-mti-elf the same as mips-sde-elf
> * binutils-all/objcopy.exp: Likewise
>
> gas/testsuite/ChangeLog:
>
> 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> * gas/mips/mips.exp: Consider mips-mti-elf the same as mips-sde-elf
>
> ld/testsuite/ChangeLog:
>
> 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> * ld-mips-elf/mips-elf.exp: Consider mips-mti-elf the same as mips-sde-elf
> ---
> binutils/testsuite/binutils-all/objcopy.exp | 3 ++-
> binutils/testsuite/binutils-all/readelf.exp | 1 +
> gas/testsuite/gas/mips/mips.exp | 4 +++-
> ld/testsuite/ld-mips-elf/mips-elf.exp | 6 ++++--
> 4 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
> index 4dfb73c..dca962d 100644
> --- a/binutils/testsuite/binutils-all/objcopy.exp
> +++ b/binutils/testsuite/binutils-all/objcopy.exp
> @@ -988,7 +988,8 @@ if [is_elf_format] {
> # targ_defvec=bfd_elf32_nbigmips_vec or
> # targ_defvec=bfd_elf32_nlittlemips_vec in config.bfd. When syncing,
> # don't forget that earlier case-matches trump later ones.
> - if { ![istarget "mips*-sde-elf*"] && ![istarget "mips64*-*-openbsd*"] } {
> + if { ![istarget "mips*-sde-elf*"] && ![istarget "mips*-mti-elf*"]
> + && ![istarget "mips64*-*-openbsd*"] } {
> setup_xfail "mips*-*-irix5*" "mips*-*-irix6*" "mips*-*-elf*" \
> "mips*-*-rtems*" "mips*-*-windiss" "mips*-*-none" \
> "mips*-*-openbsd*" "mips*-*-chorus*"
> diff --git a/binutils/testsuite/binutils-all/readelf.exp b/binutils/testsuite/binutils-all/readelf.exp
> index db56a86..9a3e6bd 100644
> --- a/binutils/testsuite/binutils-all/readelf.exp
> +++ b/binutils/testsuite/binutils-all/readelf.exp
> @@ -102,6 +102,7 @@ proc readelf_test { options binary_file regexp_file xfails } {
> if [istarget "mips*-*-*"] then {
> if { [istarget "mips*-*-*linux*"]
> || [istarget "mips*-sde-elf*"]
> + || [istarget "mips*-mti-elf*"]
> || [istarget "mips*-*freebsd*"] } then {
> set target_machine tmips
> } else {
> diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
> index d632c4f..f962135 100644
> --- a/gas/testsuite/gas/mips/mips.exp
> +++ b/gas/testsuite/gas/mips/mips.exp
> @@ -466,10 +466,12 @@ if { [istarget mips*-*-vxworks*] } {
> run_dump_test "vxworks1-xgot-el"
> } elseif { [istarget mips*-*-*] } {
> set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*]]
> - set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]]
> + set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
> + || [istarget mips*-sde-elf*] || [istarget mips*-mti-elf*]]
>
> if { [istarget "mips*-*-*linux*"]
> || [istarget "mips*-sde-elf*"]
> + || [istarget "mips*-mti-elf*"]
> || [istarget "mips*-*-*bsd*"] } then {
> set tmips "t"
> } else {
> diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp b/ld/testsuite/ld-mips-elf/mips-elf.exp
> index a66a289..a9d16ec 100644
> --- a/ld/testsuite/ld-mips-elf/mips-elf.exp
> +++ b/ld/testsuite/ld-mips-elf/mips-elf.exp
> @@ -55,7 +55,8 @@ if {![istarget mips*-*-*] || ![is_elf_format]} {
>
> set has_newabi [expr [istarget *-*-irix6*] \
> || [istarget mips*-*-linux*] \
> - || [istarget mips*-sde-elf*]]
> + || [istarget mips*-sde-elf*] \
> + || [istarget mips*-mti-elf*]]
> set linux_gnu [expr [istarget mips*-*-linux*]]
> set embedded_elf [expr [istarget mips*-*-elf]]
>
> @@ -78,7 +79,8 @@ if { [istarget *-*-irix6*] } {
> set abi_asflags(o32) "-32 -EB"
> set abi_ldflags(o32) -melf32btsmip_fbsd
> }
> -if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*] } {
> +if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]
> + || [istarget mips*-mti-elf*] } {
> set abi_ldflags(n32) -melf32btsmipn32
> set abi_ldflags(n64) -melf64btsmip
> } elseif { [istarget mips64*-*freebsd*] } {
> --
> 1.7.1
>
> diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
> index 4dfb73c..dca962d 100644
> --- a/binutils/testsuite/binutils-all/objcopy.exp
> +++ b/binutils/testsuite/binutils-all/objcopy.exp
> @@ -988,7 +988,8 @@ if [is_elf_format] {
> # targ_defvec=bfd_elf32_nbigmips_vec or
> # targ_defvec=bfd_elf32_nlittlemips_vec in config.bfd. When syncing,
> # don't forget that earlier case-matches trump later ones.
> - if { ![istarget "mips*-sde-elf*"] && ![istarget "mips64*-*-openbsd*"] } {
> + if { ![istarget "mips*-sde-elf*"] && ![istarget "mips*-mti-elf*"]
> + && ![istarget "mips64*-*-openbsd*"] } {
> setup_xfail "mips*-*-irix5*" "mips*-*-irix6*" "mips*-*-elf*" \
> "mips*-*-rtems*" "mips*-*-windiss" "mips*-*-none" \
> "mips*-*-openbsd*" "mips*-*-chorus*"
> diff --git a/binutils/testsuite/binutils-all/readelf.exp b/binutils/testsuite/binutils-all/readelf.exp
> index db56a86..9a3e6bd 100644
> --- a/binutils/testsuite/binutils-all/readelf.exp
> +++ b/binutils/testsuite/binutils-all/readelf.exp
> @@ -102,6 +102,7 @@ proc readelf_test { options binary_file regexp_file xfails } {
> if [istarget "mips*-*-*"] then {
> if { [istarget "mips*-*-*linux*"]
> || [istarget "mips*-sde-elf*"]
> + || [istarget "mips*-mti-elf*"]
> || [istarget "mips*-*freebsd*"] } then {
> set target_machine tmips
> } else {
> diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
> index d632c4f..f962135 100644
> --- a/gas/testsuite/gas/mips/mips.exp
> +++ b/gas/testsuite/gas/mips/mips.exp
> @@ -466,10 +466,12 @@ if { [istarget mips*-*-vxworks*] } {
> run_dump_test "vxworks1-xgot-el"
> } elseif { [istarget mips*-*-*] } {
> set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*]]
> - set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]]
> + set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
> + || [istarget mips*-sde-elf*] || [istarget mips*-mti-elf*]]
>
> if { [istarget "mips*-*-*linux*"]
> || [istarget "mips*-sde-elf*"]
> + || [istarget "mips*-mti-elf*"]
> || [istarget "mips*-*-*bsd*"] } then {
> set tmips "t"
> } else {
> diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp b/ld/testsuite/ld-mips-elf/mips-elf.exp
> index a66a289..a9d16ec 100644
> --- a/ld/testsuite/ld-mips-elf/mips-elf.exp
> +++ b/ld/testsuite/ld-mips-elf/mips-elf.exp
> @@ -55,7 +55,8 @@ if {![istarget mips*-*-*] || ![is_elf_format]} {
>
> set has_newabi [expr [istarget *-*-irix6*] \
> || [istarget mips*-*-linux*] \
> - || [istarget mips*-sde-elf*]]
> + || [istarget mips*-sde-elf*] \
> + || [istarget mips*-mti-elf*]]
> set linux_gnu [expr [istarget mips*-*-linux*]]
> set embedded_elf [expr [istarget mips*-*-elf]]
>
> @@ -78,7 +79,8 @@ if { [istarget *-*-irix6*] } {
> set abi_asflags(o32) "-32 -EB"
> set abi_ldflags(o32) -melf32btsmip_fbsd
> }
> -if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*] } {
> +if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]
> + || [istarget mips*-mti-elf*] } {
> set abi_ldflags(n32) -melf32btsmipn32
> set abi_ldflags(n64) -melf64btsmip
> } elseif { [istarget mips64*-*freebsd*] } {
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] Update testsuite configurations for mips-mti-elf
2013-11-26 8:54 ` Eric Christopher
@ 2013-11-26 8:54 ` Matthew Fortune
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Fortune @ 2013-11-26 8:54 UTC (permalink / raw)
To: Eric Christopher; +Cc: binutils
Indeed it is just mechanical. It was simply an omission when the new triplet was added.
As long as this gets in at some point it's not urgent.
Matthew
> -----Original Message-----
> From: Eric Christopher [mailto:echristo@gmail.com]
> Sent: 25 November 2013 21:18
> To: Matthew Fortune
> Cc: binutils@sourceware.org
> Subject: Re: [PATCH] Update testsuite configurations for mips-mti-elf
>
> FWIW this seems like a totally mechanical change and is likely just fine. I
> haven't had time to apply and test it myself.
>
> -eric
>
> On Mon, Nov 11, 2013 at 4:09 AM, Matthew Fortune
> <Matthew.Fortune@imgtec.com> wrote:
> > Update testsuite configurations to treat mips-mti-elf in the same way
> > as mips-sde-elf. The primary difference between these triplets is in
> > the default architecture, all other aspects are the same.
> >
> > This change resolves some spurious test failures for mips16 and
> > enables previously omitted ld tests when using the mips-mti-elf triplet.
> >
> > I do not have write access so will require someone to commit this for
> > me (or allow me to have commit access if that is possible).
> >
> > binutils/testsuite/ChangeLog:
> >
> > 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> > * binutils-all/objcopy.exp: Consider mips-mti-elf the same as mips-
> sde-elf
> > * binutils-all/readelf.exp: Likewise
> >
> > gas/testsuite/ChangeLog:
> >
> > 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> > * gas/mips/mips.exp: Consider mips-mti-elf the same as
> > mips-sde-elf
> >
> > ld/testsuite/ChangeLog:
> >
> > 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> > * ld-mips-elf/mips-elf.exp: Consider mips-mti-elf the same as
> > mips-sde-elf
> > ---
> > binutils/testsuite/binutils-all/objcopy.exp | 3 ++-
> > binutils/testsuite/binutils-all/readelf.exp | 1 +
> > gas/testsuite/gas/mips/mips.exp | 4 +++-
> > ld/testsuite/ld-mips-elf/mips-elf.exp | 6 ++++--
> > 4 files changed, 10 insertions(+), 4 deletions(-)
> >
> > From d789db742564fdd1a8430660fe5431a94dff8b62 Mon Sep 17 00:00:00
> 2001
> > From: mfortune <matthew.fortune@imgtec.com>
> > Date: Mon, 11 Nov 2013 11:45:39 +0000
> > Subject: [PATCH] Update testsuite configurations for mips-mti-elf
> >
> > Update testsuite configurations to treat mips-mti-elf in the same way
> > as mips-sde-elf. The primary difference between these triplets is in
> > the default architecture, all other aspects are the same.
> >
> > binutils/testsuite/ChangeLog:
> >
> > 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> > * binutils-all/objcopy.exp: Consider mips-mti-elf the same as mips-
> sde-elf
> > * binutils-all/objcopy.exp: Likewise
> >
> > gas/testsuite/ChangeLog:
> >
> > 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> > * gas/mips/mips.exp: Consider mips-mti-elf the same as
> > mips-sde-elf
> >
> > ld/testsuite/ChangeLog:
> >
> > 2013-11-11 Matthew Fortune <matthew.fortune@imgtec.com>
> > * ld-mips-elf/mips-elf.exp: Consider mips-mti-elf the same as
> > mips-sde-elf
> > ---
> > binutils/testsuite/binutils-all/objcopy.exp | 3 ++-
> > binutils/testsuite/binutils-all/readelf.exp | 1 +
> > gas/testsuite/gas/mips/mips.exp | 4 +++-
> > ld/testsuite/ld-mips-elf/mips-elf.exp | 6 ++++--
> > 4 files changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/binutils/testsuite/binutils-all/objcopy.exp
> > b/binutils/testsuite/binutils-all/objcopy.exp
> > index 4dfb73c..dca962d 100644
> > --- a/binutils/testsuite/binutils-all/objcopy.exp
> > +++ b/binutils/testsuite/binutils-all/objcopy.exp
> > @@ -988,7 +988,8 @@ if [is_elf_format] {
> > # targ_defvec=bfd_elf32_nbigmips_vec or
> > # targ_defvec=bfd_elf32_nlittlemips_vec in config.bfd. When syncing,
> > # don't forget that earlier case-matches trump later ones.
> > - if { ![istarget "mips*-sde-elf*"] && ![istarget "mips64*-*-openbsd*"] } {
> > + if { ![istarget "mips*-sde-elf*"] && ![istarget "mips*-mti-elf*"]
> > + && ![istarget "mips64*-*-openbsd*"] } {
> > setup_xfail "mips*-*-irix5*" "mips*-*-irix6*" "mips*-*-elf*" \
> > "mips*-*-rtems*" "mips*-*-windiss" "mips*-*-none" \
> > "mips*-*-openbsd*" "mips*-*-chorus*"
> > diff --git a/binutils/testsuite/binutils-all/readelf.exp
> > b/binutils/testsuite/binutils-all/readelf.exp
> > index db56a86..9a3e6bd 100644
> > --- a/binutils/testsuite/binutils-all/readelf.exp
> > +++ b/binutils/testsuite/binutils-all/readelf.exp
> > @@ -102,6 +102,7 @@ proc readelf_test { options binary_file regexp_file
> xfails } {
> > if [istarget "mips*-*-*"] then {
> > if { [istarget "mips*-*-*linux*"]
> > || [istarget "mips*-sde-elf*"]
> > + || [istarget "mips*-mti-elf*"]
> > || [istarget "mips*-*freebsd*"] } then {
> > set target_machine tmips
> > } else {
> > diff --git a/gas/testsuite/gas/mips/mips.exp
> > b/gas/testsuite/gas/mips/mips.exp index d632c4f..f962135 100644
> > --- a/gas/testsuite/gas/mips/mips.exp
> > +++ b/gas/testsuite/gas/mips/mips.exp
> > @@ -466,10 +466,12 @@ if { [istarget mips*-*-vxworks*] } {
> > run_dump_test "vxworks1-xgot-el"
> > } elseif { [istarget mips*-*-*] } {
> > set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] ||
> [istarget mipsel-*-linux*]]
> > - set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] ||
> [istarget mips*-sde-elf*]]
> > + set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
> > + || [istarget mips*-sde-elf*] || [istarget
> > + mips*-mti-elf*]]
> >
> > if { [istarget "mips*-*-*linux*"]
> > || [istarget "mips*-sde-elf*"]
> > + || [istarget "mips*-mti-elf*"]
> > || [istarget "mips*-*-*bsd*"] } then {
> > set tmips "t"
> > } else {
> > diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp
> > b/ld/testsuite/ld-mips-elf/mips-elf.exp
> > index a66a289..a9d16ec 100644
> > --- a/ld/testsuite/ld-mips-elf/mips-elf.exp
> > +++ b/ld/testsuite/ld-mips-elf/mips-elf.exp
> > @@ -55,7 +55,8 @@ if {![istarget mips*-*-*] || ![is_elf_format]} {
> >
> > set has_newabi [expr [istarget *-*-irix6*] \
> > || [istarget mips*-*-linux*] \
> > - || [istarget mips*-sde-elf*]]
> > + || [istarget mips*-sde-elf*] \
> > + || [istarget mips*-mti-elf*]]
> > set linux_gnu [expr [istarget mips*-*-linux*]] set embedded_elf
> > [expr [istarget mips*-*-elf]]
> >
> > @@ -78,7 +79,8 @@ if { [istarget *-*-irix6*] } {
> > set abi_asflags(o32) "-32 -EB"
> > set abi_ldflags(o32) -melf32btsmip_fbsd } -if { [istarget
> > mips*-*-linux*] || [istarget mips*-sde-elf*] } {
> > +if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]
> > + || [istarget mips*-mti-elf*] } {
> > set abi_ldflags(n32) -melf32btsmipn32
> > set abi_ldflags(n64) -melf64btsmip } elseif { [istarget
> > mips64*-*freebsd*] } {
> > --
> > 1.7.1
> >
> > diff --git a/binutils/testsuite/binutils-all/objcopy.exp
> > b/binutils/testsuite/binutils-all/objcopy.exp
> > index 4dfb73c..dca962d 100644
> > --- a/binutils/testsuite/binutils-all/objcopy.exp
> > +++ b/binutils/testsuite/binutils-all/objcopy.exp
> > @@ -988,7 +988,8 @@ if [is_elf_format] {
> > # targ_defvec=bfd_elf32_nbigmips_vec or
> > # targ_defvec=bfd_elf32_nlittlemips_vec in config.bfd. When syncing,
> > # don't forget that earlier case-matches trump later ones.
> > - if { ![istarget "mips*-sde-elf*"] && ![istarget "mips64*-*-openbsd*"] } {
> > + if { ![istarget "mips*-sde-elf*"] && ![istarget "mips*-mti-elf*"]
> > + && ![istarget "mips64*-*-openbsd*"] } {
> > setup_xfail "mips*-*-irix5*" "mips*-*-irix6*" "mips*-*-elf*" \
> > "mips*-*-rtems*" "mips*-*-windiss" "mips*-*-none" \
> > "mips*-*-openbsd*" "mips*-*-chorus*"
> > diff --git a/binutils/testsuite/binutils-all/readelf.exp
> > b/binutils/testsuite/binutils-all/readelf.exp
> > index db56a86..9a3e6bd 100644
> > --- a/binutils/testsuite/binutils-all/readelf.exp
> > +++ b/binutils/testsuite/binutils-all/readelf.exp
> > @@ -102,6 +102,7 @@ proc readelf_test { options binary_file regexp_file
> xfails } {
> > if [istarget "mips*-*-*"] then {
> > if { [istarget "mips*-*-*linux*"]
> > || [istarget "mips*-sde-elf*"]
> > + || [istarget "mips*-mti-elf*"]
> > || [istarget "mips*-*freebsd*"] } then {
> > set target_machine tmips
> > } else {
> > diff --git a/gas/testsuite/gas/mips/mips.exp
> > b/gas/testsuite/gas/mips/mips.exp index d632c4f..f962135 100644
> > --- a/gas/testsuite/gas/mips/mips.exp
> > +++ b/gas/testsuite/gas/mips/mips.exp
> > @@ -466,10 +466,12 @@ if { [istarget mips*-*-vxworks*] } {
> > run_dump_test "vxworks1-xgot-el"
> > } elseif { [istarget mips*-*-*] } {
> > set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] ||
> [istarget mipsel-*-linux*]]
> > - set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] ||
> [istarget mips*-sde-elf*]]
> > + set has_newabi [expr [istarget *-*-irix6*] || [istarget mips*-*-linux*] \
> > + || [istarget mips*-sde-elf*] || [istarget
> > + mips*-mti-elf*]]
> >
> > if { [istarget "mips*-*-*linux*"]
> > || [istarget "mips*-sde-elf*"]
> > + || [istarget "mips*-mti-elf*"]
> > || [istarget "mips*-*-*bsd*"] } then {
> > set tmips "t"
> > } else {
> > diff --git a/ld/testsuite/ld-mips-elf/mips-elf.exp
> > b/ld/testsuite/ld-mips-elf/mips-elf.exp
> > index a66a289..a9d16ec 100644
> > --- a/ld/testsuite/ld-mips-elf/mips-elf.exp
> > +++ b/ld/testsuite/ld-mips-elf/mips-elf.exp
> > @@ -55,7 +55,8 @@ if {![istarget mips*-*-*] || ![is_elf_format]} {
> >
> > set has_newabi [expr [istarget *-*-irix6*] \
> > || [istarget mips*-*-linux*] \
> > - || [istarget mips*-sde-elf*]]
> > + || [istarget mips*-sde-elf*] \
> > + || [istarget mips*-mti-elf*]]
> > set linux_gnu [expr [istarget mips*-*-linux*]] set embedded_elf
> > [expr [istarget mips*-*-elf]]
> >
> > @@ -78,7 +79,8 @@ if { [istarget *-*-irix6*] } {
> > set abi_asflags(o32) "-32 -EB"
> > set abi_ldflags(o32) -melf32btsmip_fbsd } -if { [istarget
> > mips*-*-linux*] || [istarget mips*-sde-elf*] } {
> > +if { [istarget mips*-*-linux*] || [istarget mips*-sde-elf*]
> > + || [istarget mips*-mti-elf*] } {
> > set abi_ldflags(n32) -melf32btsmipn32
> > set abi_ldflags(n64) -melf64btsmip } elseif { [istarget
> > mips64*-*freebsd*] } {
> > --
> > 1.7.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update testsuite configurations for mips-mti-elf
2013-11-11 12:09 [PATCH] Update testsuite configurations for mips-mti-elf Matthew Fortune
2013-11-26 8:54 ` Eric Christopher
@ 2013-11-27 11:44 ` Richard Sandiford
1 sibling, 0 replies; 4+ messages in thread
From: Richard Sandiford @ 2013-11-27 11:44 UTC (permalink / raw)
To: Matthew Fortune; +Cc: binutils
Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
> Update testsuite configurations to treat mips-mti-elf in the same way as
> mips-sde-elf. The primary difference between these triplets is in the
> default architecture, all other aspects are the same.
>
> This change resolves some spurious test failures for mips16 and enables
> previously omitted ld tests when using the mips-mti-elf triplet.
Applied, thanks.
I'm really sorry for the excessive delay. I'd missed this thread until now.
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-27 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-11 12:09 [PATCH] Update testsuite configurations for mips-mti-elf Matthew Fortune
2013-11-26 8:54 ` Eric Christopher
2013-11-26 8:54 ` Matthew Fortune
2013-11-27 11:44 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).